* [PATCH] remoteproc/davinci: Use %zx for formating size_t
@ 2018-08-17 0:49 Bjorn Andersson
2018-08-17 1:51 ` Suman Anna
2018-08-17 7:39 ` Bartosz Golaszewski
0 siblings, 2 replies; 4+ messages in thread
From: Bjorn Andersson @ 2018-08-17 0:49 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson
Cc: linux-remoteproc, linux-kernel, Bartosz Golaszewski, Suman Anna
da8xx_rproc_mem size is of type size_t, so use %zx to format the debug
print of it to avoid a compile warning.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/remoteproc/da8xx_remoteproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
index e230bef71be1..d200334577f6 100644
--- a/drivers/remoteproc/da8xx_remoteproc.c
+++ b/drivers/remoteproc/da8xx_remoteproc.c
@@ -226,7 +226,7 @@ static int da8xx_rproc_get_internal_memories(struct platform_device *pdev,
res->start & DA8XX_RPROC_LOCAL_ADDRESS_MASK;
drproc->mem[i].size = resource_size(res);
- dev_dbg(dev, "memory %8s: bus addr %pa size 0x%x va %p da 0x%x\n",
+ dev_dbg(dev, "memory %8s: bus addr %pa size 0x%zx va %p da 0x%x\n",
mem_names[i], &drproc->mem[i].bus_addr,
drproc->mem[i].size, drproc->mem[i].cpu_addr,
drproc->mem[i].dev_addr);
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc/davinci: Use %zx for formating size_t
2018-08-17 0:49 [PATCH] remoteproc/davinci: Use %zx for formating size_t Bjorn Andersson
@ 2018-08-17 1:51 ` Suman Anna
2018-08-17 7:39 ` Bartosz Golaszewski
1 sibling, 0 replies; 4+ messages in thread
From: Suman Anna @ 2018-08-17 1:51 UTC (permalink / raw)
To: Bjorn Andersson, Ohad Ben-Cohen
Cc: linux-remoteproc, linux-kernel, Bartosz Golaszewski
On 08/16/2018 07:49 PM, Bjorn Andersson wrote:
> da8xx_rproc_mem size is of type size_t, so use %zx to format the debug
> print of it to avoid a compile warning.
>
Thanks for the improvement,
Acked-by: Suman Anna <s-anna@ti.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/remoteproc/da8xx_remoteproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index e230bef71be1..d200334577f6 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -226,7 +226,7 @@ static int da8xx_rproc_get_internal_memories(struct platform_device *pdev,
> res->start & DA8XX_RPROC_LOCAL_ADDRESS_MASK;
> drproc->mem[i].size = resource_size(res);
>
> - dev_dbg(dev, "memory %8s: bus addr %pa size 0x%x va %p da 0x%x\n",
> + dev_dbg(dev, "memory %8s: bus addr %pa size 0x%zx va %p da 0x%x\n",
> mem_names[i], &drproc->mem[i].bus_addr,
> drproc->mem[i].size, drproc->mem[i].cpu_addr,
> drproc->mem[i].dev_addr);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc/davinci: Use %zx for formating size_t
2018-08-17 0:49 [PATCH] remoteproc/davinci: Use %zx for formating size_t Bjorn Andersson
2018-08-17 1:51 ` Suman Anna
@ 2018-08-17 7:39 ` Bartosz Golaszewski
2018-08-17 8:04 ` Sekhar Nori
1 sibling, 1 reply; 4+ messages in thread
From: Bartosz Golaszewski @ 2018-08-17 7:39 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Ohad Ben-Cohen, linux-remoteproc, Linux Kernel Mailing List,
Bartosz Golaszewski, Suman Anna, David Lechner
2018-08-17 2:49 GMT+02:00 Bjorn Andersson <bjorn.andersson@linaro.org>:
> da8xx_rproc_mem size is of type size_t, so use %zx to format the debug
> print of it to avoid a compile warning.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/remoteproc/da8xx_remoteproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index e230bef71be1..d200334577f6 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -226,7 +226,7 @@ static int da8xx_rproc_get_internal_memories(struct platform_device *pdev,
> res->start & DA8XX_RPROC_LOCAL_ADDRESS_MASK;
> drproc->mem[i].size = resource_size(res);
>
> - dev_dbg(dev, "memory %8s: bus addr %pa size 0x%x va %p da 0x%x\n",
> + dev_dbg(dev, "memory %8s: bus addr %pa size 0x%zx va %p da 0x%x\n",
> mem_names[i], &drproc->mem[i].bus_addr,
> drproc->mem[i].size, drproc->mem[i].cpu_addr,
> drproc->mem[i].dev_addr);
> --
> 2.18.0
>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Can you also pick up this patch[1] for v4.19? David Lechner already
has a patch queued for v4.20 that depends on this one.
Thanks,
Bartosz
[1] https://patchwork.kernel.org/patch/10479365/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc/davinci: Use %zx for formating size_t
2018-08-17 7:39 ` Bartosz Golaszewski
@ 2018-08-17 8:04 ` Sekhar Nori
0 siblings, 0 replies; 4+ messages in thread
From: Sekhar Nori @ 2018-08-17 8:04 UTC (permalink / raw)
To: Bartosz Golaszewski, Bjorn Andersson
Cc: Ohad Ben-Cohen, linux-remoteproc, Linux Kernel Mailing List,
Bartosz Golaszewski, Suman Anna, David Lechner
On Friday 17 August 2018 01:09 PM, Bartosz Golaszewski wrote:
> 2018-08-17 2:49 GMT+02:00 Bjorn Andersson <bjorn.andersson@linaro.org>:
>> da8xx_rproc_mem size is of type size_t, so use %zx to format the debug
>> print of it to avoid a compile warning.
>>
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> ---
>> drivers/remoteproc/da8xx_remoteproc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
>> index e230bef71be1..d200334577f6 100644
>> --- a/drivers/remoteproc/da8xx_remoteproc.c
>> +++ b/drivers/remoteproc/da8xx_remoteproc.c
>> @@ -226,7 +226,7 @@ static int da8xx_rproc_get_internal_memories(struct platform_device *pdev,
>> res->start & DA8XX_RPROC_LOCAL_ADDRESS_MASK;
>> drproc->mem[i].size = resource_size(res);
>>
>> - dev_dbg(dev, "memory %8s: bus addr %pa size 0x%x va %p da 0x%x\n",
>> + dev_dbg(dev, "memory %8s: bus addr %pa size 0x%zx va %p da 0x%x\n",
>> mem_names[i], &drproc->mem[i].bus_addr,
>> drproc->mem[i].size, drproc->mem[i].cpu_addr,
>> drproc->mem[i].dev_addr);
>> --
>> 2.18.0
>>
>
> Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Can you also pick up this patch[1] for v4.19? David Lechner already
> has a patch queued for v4.20 that depends on this one.
Looks like Bjorn added it to next yesterday.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b2201ee554a5811f569f31280b0079e7d6177606
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-17 8:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-17 0:49 [PATCH] remoteproc/davinci: Use %zx for formating size_t Bjorn Andersson
2018-08-17 1:51 ` Suman Anna
2018-08-17 7:39 ` Bartosz Golaszewski
2018-08-17 8:04 ` Sekhar Nori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).