* [PATCH] dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles
@ 2023-12-10 13:39 ` Krzysztof Kozlowski
2023-12-11 2:18 ` Jaewon Kim
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-10 13:39 UTC (permalink / raw)
To: Tomasz Figa, Krzysztof Kozlowski, Sylwester Nawrocki,
Alim Akhtar, Linus Walleij, Rob Herring, Conor Dooley,
Jaewon Kim, linux-arm-kernel, linux-samsung-soc, linux-gpio,
devicetree, linux-kernel
ExynosAutov920 SoC wake-up pin controller has different register layout
than Exynos7, thus it should not be marked as compatible. Neither DTS
nor Linux driver was merged yet, so the change does not impact ABI.
Cc: Jaewon Kim <jaewon02.kim@samsung.com>
Fixes: 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Fix for my for-next branch.
---
.../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
index 2bafa867aea2..f64da7f58faa 100644
--- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
@@ -36,6 +36,7 @@ properties:
- samsung,s5pv210-wakeup-eint
- samsung,exynos4210-wakeup-eint
- samsung,exynos7-wakeup-eint
+ - samsung,exynosautov920-wakeup-eint
- items:
- enum:
- samsung,exynos5433-wakeup-eint
@@ -45,7 +46,6 @@ properties:
- items:
- enum:
- samsung,exynosautov9-wakeup-eint
- - samsung,exynosautov920-wakeup-eint
- const: samsung,exynos850-wakeup-eint
- const: samsung,exynos7-wakeup-eint
@@ -112,6 +112,7 @@ allOf:
contains:
enum:
- samsung,exynos850-wakeup-eint
+ - samsung,exynosautov920-wakeup-eint
then:
properties:
interrupts: false
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles
2023-12-10 13:39 ` [PATCH] dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles Krzysztof Kozlowski
@ 2023-12-11 2:18 ` Jaewon Kim
2023-12-11 7:28 ` Krzysztof Kozlowski
2023-12-11 7:34 ` Krzysztof Kozlowski
2023-12-11 7:36 ` Krzysztof Kozlowski
2023-12-13 16:09 ` Alim Akhtar
2 siblings, 2 replies; 7+ messages in thread
From: Jaewon Kim @ 2023-12-11 2:18 UTC (permalink / raw)
To: Krzysztof Kozlowski, Tomasz Figa, Sylwester Nawrocki,
Alim Akhtar, Linus Walleij, Rob Herring, Conor Dooley,
linux-arm-kernel, linux-samsung-soc, linux-gpio, devicetree,
linux-kernel
On 23. 12. 10. 22:39, Krzysztof Kozlowski wrote:
> ExynosAutov920 SoC wake-up pin controller has different register layout
> than Exynos7, thus it should not be marked as compatible. Neither DTS
> nor Linux driver was merged yet, so the change does not impact ABI.
>
> Cc: Jaewon Kim <jaewon02.kim@samsung.com>
> Fixes: 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>
It is reasonable.
I will also fix this in v4 patch.
Reviewed-by:Jaewon Kim <jaewon02.kim@samsung.com>
Thanks,
Jaewon Kim
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles
2023-12-11 2:18 ` Jaewon Kim
@ 2023-12-11 7:28 ` Krzysztof Kozlowski
2023-12-11 7:34 ` Krzysztof Kozlowski
1 sibling, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-11 7:28 UTC (permalink / raw)
To: Jaewon Kim, Tomasz Figa, Sylwester Nawrocki, Alim Akhtar,
Linus Walleij, Rob Herring, Conor Dooley, linux-arm-kernel,
linux-samsung-soc, linux-gpio, devicetree, linux-kernel
On 11/12/2023 03:18, Jaewon Kim wrote:
>
> On 23. 12. 10. 22:39, Krzysztof Kozlowski wrote:
>> ExynosAutov920 SoC wake-up pin controller has different register layout
>> than Exynos7, thus it should not be marked as compatible. Neither DTS
>> nor Linux driver was merged yet, so the change does not impact ABI.
>>
>> Cc: Jaewon Kim <jaewon02.kim@samsung.com>
>> Fixes: 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers")
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>>
>
> It is reasonable.
>
> I will also fix this in v4 patch.
>
>
> Reviewed-by:Jaewon Kim <jaewon02.kim@samsung.com>
This is based on your patchset, because autov920 is not compatible there
with the others.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles
2023-12-11 2:18 ` Jaewon Kim
2023-12-11 7:28 ` Krzysztof Kozlowski
@ 2023-12-11 7:34 ` Krzysztof Kozlowski
2023-12-11 8:24 ` Jaewon Kim
1 sibling, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-11 7:34 UTC (permalink / raw)
To: Jaewon Kim, Tomasz Figa, Sylwester Nawrocki, Alim Akhtar,
Linus Walleij, Rob Herring, Conor Dooley, linux-arm-kernel,
linux-samsung-soc, linux-gpio, devicetree, linux-kernel
On 11/12/2023 03:18, Jaewon Kim wrote:
>
> On 23. 12. 10. 22:39, Krzysztof Kozlowski wrote:
>> ExynosAutov920 SoC wake-up pin controller has different register layout
>> than Exynos7, thus it should not be marked as compatible. Neither DTS
>> nor Linux driver was merged yet, so the change does not impact ABI.
>>
>> Cc: Jaewon Kim <jaewon02.kim@samsung.com>
>> Fixes: 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers")
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>>
>
> It is reasonable.
>
> I will also fix this in v4 patch.
>
>
> Reviewed-by:Jaewon Kim <jaewon02.kim@samsung.com>
Please send correct tags so I won't need to manually fix them. Otherwise
they get ignored by b4.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles
2023-12-10 13:39 ` [PATCH] dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles Krzysztof Kozlowski
2023-12-11 2:18 ` Jaewon Kim
@ 2023-12-11 7:36 ` Krzysztof Kozlowski
2023-12-13 16:09 ` Alim Akhtar
2 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-11 7:36 UTC (permalink / raw)
To: Tomasz Figa, Sylwester Nawrocki, Alim Akhtar, Linus Walleij,
Rob Herring, Conor Dooley, Jaewon Kim, linux-arm-kernel,
linux-samsung-soc, linux-gpio, devicetree, linux-kernel,
Krzysztof Kozlowski
On Sun, 10 Dec 2023 14:39:15 +0100, Krzysztof Kozlowski wrote:
> ExynosAutov920 SoC wake-up pin controller has different register layout
> than Exynos7, thus it should not be marked as compatible. Neither DTS
> nor Linux driver was merged yet, so the change does not impact ABI.
>
>
Applied, thanks!
[1/1] dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles
https://git.kernel.org/pinctrl/samsung/c/e1564d6f93496bcea3a6b2110eb54cc08f2aca72
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles
2023-12-11 7:34 ` Krzysztof Kozlowski
@ 2023-12-11 8:24 ` Jaewon Kim
0 siblings, 0 replies; 7+ messages in thread
From: Jaewon Kim @ 2023-12-11 8:24 UTC (permalink / raw)
To: Krzysztof Kozlowski, Tomasz Figa, Sylwester Nawrocki,
Alim Akhtar, Linus Walleij, Rob Herring, Conor Dooley,
linux-arm-kernel, linux-samsung-soc, linux-gpio, devicetree,
linux-kernel
On 23. 12. 11. 16:34, Krzysztof Kozlowski wrote:
> On 11/12/2023 03:18, Jaewon Kim wrote:
>> On 23. 12. 10. 22:39, Krzysztof Kozlowski wrote:
>>> ExynosAutov920 SoC wake-up pin controller has different register layout
>>> than Exynos7, thus it should not be marked as compatible. Neither DTS
>>> nor Linux driver was merged yet, so the change does not impact ABI.
>>>
>>> Cc: Jaewon Kim <jaewon02.kim@samsung.com>
>>> Fixes: 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers")
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>>>
>> It is reasonable.
>>
>> I will also fix this in v4 patch.
>>
>>
>> Reviewed-by:Jaewon Kim <jaewon02.kim@samsung.com>
> Please send correct tags so I won't need to manually fix them. Otherwise
> they get ignored by b4.
Thanks Krzysztof
I miss space. I will check it again next time.
>
> Best regards,
> Krzysztof
>
>
>
Thanks
Jaewon Kim
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles
2023-12-10 13:39 ` [PATCH] dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles Krzysztof Kozlowski
2023-12-11 2:18 ` Jaewon Kim
2023-12-11 7:36 ` Krzysztof Kozlowski
@ 2023-12-13 16:09 ` Alim Akhtar
2 siblings, 0 replies; 7+ messages in thread
From: Alim Akhtar @ 2023-12-13 16:09 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Tomasz Figa',
'Sylwester Nawrocki', 'Linus Walleij',
'Rob Herring', 'Conor Dooley',
'Jaewon Kim',
linux-arm-kernel, linux-samsung-soc, linux-gpio, devicetree,
linux-kernel
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Sunday, December 10, 2023 7:09 PM
> To: Tomasz Figa <tomasz.figa@gmail.com>; Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org>; Sylwester Nawrocki
> <s.nawrocki@samsung.com>; Alim Akhtar <alim.akhtar@samsung.com>;
> Linus Walleij <linus.walleij@linaro.org>; Rob Herring
<robh+dt@kernel.org>;
> Conor Dooley <conor+dt@kernel.org>; Jaewon Kim
> <jaewon02.kim@samsung.com>; linux-arm-kernel@lists.infradead.org;
> linux-samsung-soc@vger.kernel.org; linux-gpio@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] dt-bindings: pinctrl: samsung: correct ExynosAutov920
> wake-up compatibles
>
> ExynosAutov920 SoC wake-up pin controller has different register layout
> than Exynos7, thus it should not be marked as compatible. Neither DTS nor
> Linux driver was merged yet, so the change does not impact ABI.
>
> Cc: Jaewon Kim <jaewon02.kim@samsung.com>
> Fixes: 904140fa4553 ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks
for
> newer wake-up controllers")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
>
.
.
.
--
> 2.34.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-12-13 16:09 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20231210133927epcas2p3e2633ad371b03d5ab19f9b44118fcb58@epcas2p3.samsung.com>
2023-12-10 13:39 ` [PATCH] dt-bindings: pinctrl: samsung: correct ExynosAutov920 wake-up compatibles Krzysztof Kozlowski
2023-12-11 2:18 ` Jaewon Kim
2023-12-11 7:28 ` Krzysztof Kozlowski
2023-12-11 7:34 ` Krzysztof Kozlowski
2023-12-11 8:24 ` Jaewon Kim
2023-12-11 7:36 ` Krzysztof Kozlowski
2023-12-13 16:09 ` Alim Akhtar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).