* [PATCH] platform/x86: int3472/discrete: add LEDS_CLASS dependency
@ 2023-02-08 16:36 Arnd Bergmann
2023-02-09 9:11 ` Sakari Ailus
2023-02-10 16:12 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2023-02-08 16:36 UTC (permalink / raw)
To: Daniel Scally, Hans de Goede, Mark Gross, Sakari Ailus
Cc: Arnd Bergmann, platform-driver-x86, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
int3472 now fails to link when the LED support is disabled:
x86_64-linux-ld: drivers/platform/x86/intel/int3472/led.o: in function `skl_int3472_register_pled':
led.c:(.text+0xf4): undefined reference to `led_classdev_register_ext'
x86_64-linux-ld: led.c:(.text+0x131): undefined reference to `led_add_lookup'
x86_64-linux-ld: drivers/platform/x86/intel/int3472/led.o: in function `skl_int3472_unregister_pled':
led.c:(.text+0x16b): undefined reference to `led_remove_lookup'
x86_64-linux-ld: led.c:(.text+0x177): undefined reference to `led_classdev_unregister'
Add an explicit Kconfig dependency.
Fixes: 5ae20a8050d0 ("platform/x86: int3472/discrete: Create a LED class device for the privacy LED")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/platform/x86/intel/int3472/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/intel/int3472/Kconfig b/drivers/platform/x86/intel/int3472/Kconfig
index 62e5d4cf9ee5..17ae997f93ea 100644
--- a/drivers/platform/x86/intel/int3472/Kconfig
+++ b/drivers/platform/x86/intel/int3472/Kconfig
@@ -4,6 +4,7 @@ config INTEL_SKL_INT3472
depends on COMMON_CLK
depends on I2C
depends on GPIOLIB
+ depends on LEDS_CLASS
depends on REGULATOR
select MFD_CORE
select REGMAP_I2C
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: int3472/discrete: add LEDS_CLASS dependency
2023-02-08 16:36 [PATCH] platform/x86: int3472/discrete: add LEDS_CLASS dependency Arnd Bergmann
@ 2023-02-09 9:11 ` Sakari Ailus
2023-02-10 16:12 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2023-02-09 9:11 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Daniel Scally, Hans de Goede, Mark Gross, Arnd Bergmann,
platform-driver-x86, linux-kernel
On Wed, Feb 08, 2023 at 05:36:52PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> int3472 now fails to link when the LED support is disabled:
>
> x86_64-linux-ld: drivers/platform/x86/intel/int3472/led.o: in function `skl_int3472_register_pled':
> led.c:(.text+0xf4): undefined reference to `led_classdev_register_ext'
> x86_64-linux-ld: led.c:(.text+0x131): undefined reference to `led_add_lookup'
> x86_64-linux-ld: drivers/platform/x86/intel/int3472/led.o: in function `skl_int3472_unregister_pled':
> led.c:(.text+0x16b): undefined reference to `led_remove_lookup'
> x86_64-linux-ld: led.c:(.text+0x177): undefined reference to `led_classdev_unregister'
>
> Add an explicit Kconfig dependency.
>
> Fixes: 5ae20a8050d0 ("platform/x86: int3472/discrete: Create a LED class device for the privacy LED")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: int3472/discrete: add LEDS_CLASS dependency
2023-02-08 16:36 [PATCH] platform/x86: int3472/discrete: add LEDS_CLASS dependency Arnd Bergmann
2023-02-09 9:11 ` Sakari Ailus
@ 2023-02-10 16:12 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2023-02-10 16:12 UTC (permalink / raw)
To: Arnd Bergmann, Daniel Scally, Mark Gross, Sakari Ailus
Cc: Arnd Bergmann, platform-driver-x86, linux-kernel
Hi,
On 2/8/23 17:36, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> int3472 now fails to link when the LED support is disabled:
>
> x86_64-linux-ld: drivers/platform/x86/intel/int3472/led.o: in function `skl_int3472_register_pled':
> led.c:(.text+0xf4): undefined reference to `led_classdev_register_ext'
> x86_64-linux-ld: led.c:(.text+0x131): undefined reference to `led_add_lookup'
> x86_64-linux-ld: drivers/platform/x86/intel/int3472/led.o: in function `skl_int3472_unregister_pled':
> led.c:(.text+0x16b): undefined reference to `led_remove_lookup'
> x86_64-linux-ld: led.c:(.text+0x177): undefined reference to `led_classdev_unregister'
>
> Add an explicit Kconfig dependency.
>
> Fixes: 5ae20a8050d0 ("platform/x86: int3472/discrete: Create a LED class device for the privacy LED")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thank you for your patch, I've applied this to the pdx86/for-next
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next
Regards,
Hans
> ---
> drivers/platform/x86/intel/int3472/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/intel/int3472/Kconfig b/drivers/platform/x86/intel/int3472/Kconfig
> index 62e5d4cf9ee5..17ae997f93ea 100644
> --- a/drivers/platform/x86/intel/int3472/Kconfig
> +++ b/drivers/platform/x86/intel/int3472/Kconfig
> @@ -4,6 +4,7 @@ config INTEL_SKL_INT3472
> depends on COMMON_CLK
> depends on I2C
> depends on GPIOLIB
> + depends on LEDS_CLASS
> depends on REGULATOR
> select MFD_CORE
> select REGMAP_I2C
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-10 16:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 16:36 [PATCH] platform/x86: int3472/discrete: add LEDS_CLASS dependency Arnd Bergmann
2023-02-09 9:11 ` Sakari Ailus
2023-02-10 16:12 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).