From: sibis@codeaurora.org To: Matthias Kaehlcke <mka@chromium.org> Cc: bjorn.andersson@linaro.org, p.zabel@pengutronix.de, robh+dt@kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, ohad@wizery.com, mark.rutland@arm.com, sricharan@codeaurora.org, akdwived@codeaurora.org, linux-arm-msm@vger.kernel.org, tsoni@codeaurora.org Subject: Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs Date: Tue, 28 Aug 2018 11:38:26 +0530 Message-ID: <c675b609fcd0d243e4db2e6637c70902@codeaurora.org> (raw) In-Reply-To: <20180828003823.GY160295@google.com> Hi Matthias, Thanks for the review On 2018-08-28 06:08, Matthias Kaehlcke wrote: > Hi Sibi, > > On Fri, Aug 24, 2018 at 06:48:55PM +0530, Sibi Sankar wrote: >> Add PDC Global(Power Domain Controller) binding for SDM845 SoCs. > > nit: missing blank before the opening parenthesis. > Will fix it >> >> Signed-off-by: Sibi Sankar <sibis@codeaurora.org> >> --- >> .../bindings/reset/qcom,pdc-global.txt | 52 >> +++++++++++++++++++ >> include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++++++ >> 2 files changed, 72 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/reset/qcom,pdc-global.txt >> create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h >> >> diff --git >> a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt >> b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt >> new file mode 100644 >> index 000000000000..69f9edca9503 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt >> @@ -0,0 +1,52 @@ >> +PDC Global >> +====================================== >> + >> +This binding describes a reset-controller found on PDC-Global(Power >> Domain >> +Controller) block for Qualcomm Technologies Inc SDM845 SoCs. > > Are there other PDC reset controllers that aren't 'global'? Otherwise > I'd suggest to use 'pdc-reset' instead of 'pdc-global', which is more > specific and in line with the name of the driver added by this series. > Or something like 'pdc-reset-global/main' if there are other > controllers? > These are the only reset lines found in the pdc-global register space. But as explained by Bjorn, wouldn't it be better to leave it as such since pdc-global best describes the hardware without being limited by the current functionality it is being used for? >> +Required properties: >> +- compatible: >> + Usage: required >> + Value type: <string> >> + Definition: must be: >> + "qcom,sdm845-pdc-global" >> + >> +- reg: >> + Usage: required >> + Value type: <prop-encoded-array> >> + Definition: must specify the base address and size of the register >> + space. >> + >> +- #reset-cells: >> + Usage: required >> + Value type: <uint> >> + Definition: must be 1; cell entry represents the reset index. >> + >> +Example: >> + >> +pdc_reset: reset-controller@b2e0000 { >> + compatible = "qcom,sdm845-pdc-global"; >> + reg = <0xb2e0000 0x20000>; >> + #reset-cells = <1>; >> +}; >> + >> +PDC reset clients >> +====================================== >> + >> +Device nodes that need access to reset lines should >> +specify them as a reset phandle in their corresponding node as >> +specified in reset.txt. >> + >> +For list of all valid reset indicies see > > s/indicies/indices/ (or s/indicies/lines/ ?) > > Cheers > > Matthias
next prev parent reply index Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-24 13:18 [PATCH v2 0/6] Add support for PDC Global on " Sibi Sankar 2018-08-24 13:18 ` [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for " Sibi Sankar 2018-08-28 0:33 ` Bjorn Andersson 2018-08-28 0:38 ` Matthias Kaehlcke 2018-08-28 6:08 ` sibis [this message] 2018-08-28 17:11 ` Matthias Kaehlcke 2018-08-29 0:43 ` Rob Herring 2018-08-24 13:18 ` [PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller Sibi Sankar 2018-08-28 0:22 ` Matthias Kaehlcke 2018-08-28 3:02 ` Bjorn Andersson 2018-08-28 7:11 ` Sibi Sankar 2018-08-28 16:56 ` Matthias Kaehlcke 2018-08-24 13:18 ` [PATCH v2 3/6] dt-bindings: remoteproc: Remove additional definition tag Sibi Sankar 2018-08-28 0:44 ` Matthias Kaehlcke 2018-08-29 16:38 ` Sibi Sankar 2018-08-24 13:18 ` [PATCH v2 4/6] dt-bindings: remoteproc: Add PDC reset binding for Q6V5 PIL Sibi Sankar 2018-08-29 0:44 ` Rob Herring 2018-08-24 13:18 ` [PATCH v2 5/6] remoteproc: qcom: q6v5-pil: Explicitly get mss_restart line Sibi Sankar 2018-08-24 13:19 ` [PATCH v2 6/6] remoteproc: qcom: q6v5-pil: Add PDC reset for modem on SDM845 SoCs Sibi Sankar
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c675b609fcd0d243e4db2e6637c70902@codeaurora.org \ --to=sibis@codeaurora.org \ --cc=akdwived@codeaurora.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mka@chromium.org \ --cc=ohad@wizery.com \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ --cc=sricharan@codeaurora.org \ --cc=tsoni@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org public-inbox-index lkml Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/ public-inbox