* Re: [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return statements
[not found] <KL1PR04MB12050202C107FB05AAB8EAEA80380@KL1PR04MB1205.apcprd04.prod.outlook.com>
@ 2016-07-04 12:23 ` Martin Kepplinger
2016-07-05 20:04 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Martin Kepplinger @ 2016-07-04 12:23 UTC (permalink / raw)
To: Bijosh Thykkoottathil, jic23, knaack.h, lars, pmeerw, christoph.muellner
Cc: linux-iio, linux-kernel
Am 2016-07-04 um 13:15 schrieb Bijosh Thykkoottathil:
> Removed unwanted return statements from the function
> mma8452_set_freefall_mode.
You could've said "Don't unnecessarily save a return value.", but
whatever :) Thanks for your review!
>
> Signed-off-by: Bijosh Thykkoottathil <bijosh.t@hotmail.com>
Reviewed-by: Martin Kepplinger <martink@posteo.de>
> ---
> drivers/iio/accel/mma8452.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index e225d3c..d4a6d44 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -518,11 +518,7 @@ static int mma8452_set_freefall_mode(struct mma8452_data *data, bool state)
> val |= MMA8452_FF_MT_CFG_OAE;
> }
>
> - val = mma8452_change_config(data, chip->ev_cfg, val);
> - if (val)
> - return val;
> -
> - return 0;
> + return mma8452_change_config(data, chip->ev_cfg, val);
> }
>
> static int mma8452_set_hp_filter_frequency(struct mma8452_data *data,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return statements
2016-07-04 12:23 ` [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return statements Martin Kepplinger
@ 2016-07-05 20:04 ` Jonathan Cameron
2016-07-06 14:14 ` Martin Kepplinger
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2016-07-05 20:04 UTC (permalink / raw)
To: Martin Kepplinger, Bijosh Thykkoottathil, knaack.h, lars, pmeerw,
christoph.muellner
Cc: linux-iio, linux-kernel
On 04/07/16 13:23, Martin Kepplinger wrote:
> Am 2016-07-04 um 13:15 schrieb Bijosh Thykkoottathil:
>> Removed unwanted return statements from the function
>> mma8452_set_freefall_mode.
>
> You could've said "Don't unnecessarily save a return value.", but
> whatever :) Thanks for your review!
>
>>
>> Signed-off-by: Bijosh Thykkoottathil <bijosh.t@hotmail.com>
> Reviewed-by: Martin Kepplinger <martink@posteo.de>
Hi Martin,
I've flipped that tag over to an Acked-by which is more
appropriate in this case as an in depth review as signalled
by Reviewed-by would be 'interesting' here ;)
I'm enjoying the slightly doom laden commit messages :)
Applied.
Jonathan
>
>> ---
>> drivers/iio/accel/mma8452.c | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
>> index e225d3c..d4a6d44 100644
>> --- a/drivers/iio/accel/mma8452.c
>> +++ b/drivers/iio/accel/mma8452.c
>> @@ -518,11 +518,7 @@ static int mma8452_set_freefall_mode(struct mma8452_data *data, bool state)
>> val |= MMA8452_FF_MT_CFG_OAE;
>> }
>>
>> - val = mma8452_change_config(data, chip->ev_cfg, val);
>> - if (val)
>> - return val;
>> -
>> - return 0;
>> + return mma8452_change_config(data, chip->ev_cfg, val);
>> }
>>
>> static int mma8452_set_hp_filter_frequency(struct mma8452_data *data,
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return statements
2016-07-05 20:04 ` Jonathan Cameron
@ 2016-07-06 14:14 ` Martin Kepplinger
0 siblings, 0 replies; 3+ messages in thread
From: Martin Kepplinger @ 2016-07-06 14:14 UTC (permalink / raw)
To: Jonathan Cameron, Bijosh Thykkoottathil, knaack.h, lars, pmeerw,
christoph.muellner
Cc: linux-iio, linux-kernel
Am 2016-07-05 um 22:04 schrieb Jonathan Cameron:
> On 04/07/16 13:23, Martin Kepplinger wrote:
>> Am 2016-07-04 um 13:15 schrieb Bijosh Thykkoottathil:
>>> Removed unwanted return statements from the function
>>> mma8452_set_freefall_mode.
>>
>> You could've said "Don't unnecessarily save a return value.", but
>> whatever :) Thanks for your review!
>>
>>>
>>> Signed-off-by: Bijosh Thykkoottathil <bijosh.t@hotmail.com>
>> Reviewed-by: Martin Kepplinger <martink@posteo.de>
> Hi Martin,
>
> I've flipped that tag over to an Acked-by which is more
> appropriate in this case as an in depth review as signalled
> by Reviewed-by would be 'interesting' here ;)
Sure, thanks!
>
> I'm enjoying the slightly doom laden commit messages :)
>
> Applied.
>
> Jonathan
>>
>>> ---
>>> drivers/iio/accel/mma8452.c | 6 +-----
>>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
>>> index e225d3c..d4a6d44 100644
>>> --- a/drivers/iio/accel/mma8452.c
>>> +++ b/drivers/iio/accel/mma8452.c
>>> @@ -518,11 +518,7 @@ static int mma8452_set_freefall_mode(struct mma8452_data *data, bool state)
>>> val |= MMA8452_FF_MT_CFG_OAE;
>>> }
>>>
>>> - val = mma8452_change_config(data, chip->ev_cfg, val);
>>> - if (val)
>>> - return val;
>>> -
>>> - return 0;
>>> + return mma8452_change_config(data, chip->ev_cfg, val);
>>> }
>>>
>>> static int mma8452_set_hp_filter_frequency(struct mma8452_data *data,
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-06 14:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <KL1PR04MB12050202C107FB05AAB8EAEA80380@KL1PR04MB1205.apcprd04.prod.outlook.com>
2016-07-04 12:23 ` [PATCH v1] drivers:iio:accel:mma8452: removed unwanted return statements Martin Kepplinger
2016-07-05 20:04 ` Jonathan Cameron
2016-07-06 14:14 ` Martin Kepplinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).