From: Roger Quadros <rogerq@ti.com>
To: Rob Herring <robh+dt@kernel.org>, Robin Murphy <robin.murphy@arm.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Péter Ujfalusi" <peter.ujfalusi@ti.com>,
"Murali Karicheri" <m-karicheri2@ti.com>,
"Nori, Sekhar" <nsekhar@ti.com>, "Anna, Suman" <s-anna@ti.com>,
"Stefan Wahren" <stefan.wahren@i2se.com>,
"Andreas Färber" <afaerber@suse.de>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Nishanth Menon" <nm@ti.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>
Subject: Re: dma_mask limited to 32-bits with OF platform device
Date: Wed, 4 Mar 2020 10:28:28 +0200 [thread overview]
Message-ID: <c753a232-403d-6ed2-89fd-09476c887391@ti.com> (raw)
In-Reply-To: <CAL_Jsq+zx5qkv1DZdj1p2HHz5siYZwv6WGLe1F7xw9b019UWbQ@mail.gmail.com>
Hi,
On 03/03/2020 21:26, Rob Herring wrote:
> On Tue, Mar 3, 2020 at 8:06 AM Robin Murphy <robin.murphy@arm.com> wrote:
>>
>> On 03/03/2020 8:27 am, Roger Quadros wrote:
>> [...]
>>>> With the patch (in the end). dev->bus_dma_limit is still set to 0 and
>>>> so is not being used.
>>>>
>>>> from of_dma_configure()
>>>> ret = of_dma_get_range(np, &dma_addr, &paddr, &size);
>>>> ...
>>>> /* ...but only set bus limit if we found valid dma-ranges
>>>> earlier */
>>>> if (!ret)
>>>> dev->bus_dma_limit = end;
>>>>
>>>> There is no other place bus_dma_limit is set. Looks like every device
>>>> should inherit that
>>>> from it's parent right?
>>>
>>> Any ideas how to expect this to work?
>>
>> Is of_dma_get_range() actually succeeding, or is it tripping up on some
>> aspect of the DT (in which case there should be errors in the log)?
>>
of_dma_get_range() was failing but no errors in the log.
>> Looking again at the fragment below, are you sure it's correct? It
>> appears to me like it might actually be defining a 1-byte-long DMA
>> range, which indeed I wouldn't really expect to work.
>
> Indeed, though it took me a minute to see why.
>
>>
>> Robin.
>>
>>>>
>>>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>>>> index 64a0f90f5b52..5418c31d4da7 100644
>>>> --- a/arch/arm/boot/dts/dra7.dtsi
>>>> +++ b/arch/arm/boot/dts/dra7.dtsi
>>>> @@ -680,15 +680,22 @@
>>>> };
>>>>
>>>> /* OCP2SCP3 */
>>>> - sata: sata@4a141100 {
>>>> - compatible = "snps,dwc-ahci";
>>>> - reg = <0x4a140000 0x1100>, <0x4a141100 0x7>;
>
> Based on this, the parent address size is 1 cell...
>
>>>> - interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
>>>> - phys = <&sata_phy>;
>>>> - phy-names = "sata-phy";
>>>> - clocks = <&l3init_clkctrl DRA7_L3INIT_SATA_CLKCTRL 8>;
>>>> - ti,hwmods = "sata";
>>>> - ports-implemented = <0x1>;
>>>> + sata_aux_bus {
>>>> + #address-cells = <2>;
>>>> + #size-cells = <2>;
>>>> + compatible = "simple-bus";
>>>> + ranges = <0x0 0x0 0x4a140000 0x0 0x1200>;
>>>> + dma-ranges = <0x0 0x0 0x0 0x0 0x1 0x00000000>;
>
> So this is:
> child addr: 0x0 0x0
> parent addr: 0x0
> size: 0x0 0x1
Good catch.
So I fixed it to
dma-ranges = <0x0 0x0 0x0 0x1 0x00000000>;
And now it works :).
Thanks!
>
> The last cell is just ignored I guess if you aren't seeing any errors.
> We check this in dtc for ranges, but not dma-ranges. So I'm fixing
> that.
Great!
>
>>>> + sata: sata@4a141100 {
>>>> + compatible = "snps,dwc-ahci";
>>>> + reg = <0x0 0x0 0x0 0x1100>, <0x0 0x1100 0x0 0x7>;
>>>> + interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
>>>> + phys = <&sata_phy>;
>>>> + phy-names = "sata-phy";
>>>> + clocks = <&l3init_clkctrl DRA7_L3INIT_SATA_CLKCTRL 8>;
>>>> + ti,hwmods = "sata";
>>>> + ports-implemented = <0x1>;
>>>> + };
>>>> };
>>>>
>>>> /* OCP2SCP1 */
>>>>
>>>
--
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
prev parent reply other threads:[~2020-03-04 8:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 10:49 dma_mask limited to 32-bits with OF platform device Roger Quadros
2020-02-12 11:37 ` Robin Murphy
2020-02-12 12:33 ` Roger Quadros
2020-02-12 14:04 ` Robin Murphy
2020-02-12 17:57 ` Christoph Hellwig
2020-02-17 13:21 ` Christoph Hellwig
2020-02-17 14:54 ` Peter Ujfalusi
2020-02-18 7:26 ` Peter Ujfalusi
2020-02-18 8:28 ` Roger Quadros
2020-02-18 17:22 ` Rob Herring
2020-02-19 14:29 ` Roger Quadros
2020-02-19 15:25 ` Robin Murphy
2020-02-19 15:40 ` Roger Quadros
2020-02-26 11:33 ` Roger Quadros
2020-03-03 8:27 ` Roger Quadros
2020-03-03 14:06 ` Robin Murphy
2020-03-03 19:26 ` Rob Herring
2020-03-04 8:28 ` Roger Quadros [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c753a232-403d-6ed2-89fd-09476c887391@ti.com \
--to=rogerq@ti.com \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=hch@lst.de \
--cc=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=s-anna@ti.com \
--cc=stefan.wahren@i2se.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).