* [PATCH] parisc: time: stop validating rtc_time in .read_time
@ 2018-02-21 21:40 Alexandre Belloni
2018-03-06 21:20 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Belloni @ 2018-02-21 21:40 UTC (permalink / raw)
To: Helge Deller
Cc: James E . J . Bottomley, linux-parisc, linux-rtc, linux-kernel,
Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
arch/parisc/kernel/time.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c
index 4b8fd6dc22da..f2890bd240f8 100644
--- a/arch/parisc/kernel/time.c
+++ b/arch/parisc/kernel/time.c
@@ -173,7 +173,7 @@ static int rtc_generic_get_time(struct device *dev, struct rtc_time *tm)
/* we treat tod_sec as unsigned, so this can work until year 2106 */
rtc_time64_to_tm(tod_data.tod_sec, tm);
- return rtc_valid_tm(tm);
+ return 0;
}
static int rtc_generic_set_time(struct device *dev, struct rtc_time *tm)
--
2.16.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] parisc: time: stop validating rtc_time in .read_time
2018-02-21 21:40 [PATCH] parisc: time: stop validating rtc_time in .read_time Alexandre Belloni
@ 2018-03-06 21:20 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2018-03-06 21:20 UTC (permalink / raw)
To: Alexandre Belloni
Cc: James E . J . Bottomley, linux-parisc, linux-rtc, linux-kernel
On 21.02.2018 22:40, Alexandre Belloni wrote:
> The RTC core is always calling rtc_valid_tm after the read_time callback.
> It is not necessary to call it just before returning from the callback.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Helge Deller <deller@gmx.de>
Thanks!
Helge
> ---
> arch/parisc/kernel/time.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c
> index 4b8fd6dc22da..f2890bd240f8 100644
> --- a/arch/parisc/kernel/time.c
> +++ b/arch/parisc/kernel/time.c
> @@ -173,7 +173,7 @@ static int rtc_generic_get_time(struct device *dev, struct rtc_time *tm)
>
> /* we treat tod_sec as unsigned, so this can work until year 2106 */
> rtc_time64_to_tm(tod_data.tod_sec, tm);
> - return rtc_valid_tm(tm);
> + return 0;
> }
>
> static int rtc_generic_set_time(struct device *dev, struct rtc_time *tm)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-06 21:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-21 21:40 [PATCH] parisc: time: stop validating rtc_time in .read_time Alexandre Belloni
2018-03-06 21:20 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).