From: Mike Travis <mike.travis@hpe.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Borislav Petkov <bp@suse.de>
Cc: x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] x86/platform updates for v5.10
Date: Mon, 12 Oct 2020 14:15:55 -0700 [thread overview]
Message-ID: <c8cfb3d2-d3c4-6d8d-1dfd-aeb349e26303@hpe.com> (raw)
In-Reply-To: <CAHk-=wiwBYoAKQ6H=n0ppZfMe6nVDwDw6cruv7jxZZw4XEmUsg@mail.gmail.com>
On 10/12/2020 2:10 PM, Linus Torvalds wrote:
> On Mon, Oct 12, 2020 at 3:10 AM Borislav Petkov <bp@suse.de> wrote:
>>
>> please pull the x86/platform queue.
>
> Hmm. I didn't immediately notice this new warning, because it only
> happens with the clang build that I don't do in between every pull.
>
> But this pull causes new warnings from clang:
>
> arch/x86/platform/uv/uv_nmi.c:250:23: warning: implicit conversion
> from 'unsigned long' to 'int' changes value from 1152921504606846976
> to 0 [-Wconstant-conversion]
> uvh_nmi_mmrx_mask = UVH_EVENT_OCCURRED0_EXTIO_INT0_MASK;
> ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> and I think that warning is correct, and the code is wrong.
>
> In particular, we have
>
> static int uvh_nmi_mmrx_mask;
>
> so it's a signed 32-bit integer, and the code is treating it like it's
> a 64-bit mask.
>
> Of course, it also looks like that 'uvh_nmi_mmrx_mask' thing is a
> write-only variable so it doesn't matter, but can we _please_ get this
> code fixed ASAP?
Yes, I'll look at it right now. Thanks.
>
> Linus
>
next prev parent reply other threads:[~2020-10-12 21:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 10:10 [GIT PULL] x86/platform updates for v5.10 Borislav Petkov
2020-10-12 18:21 ` pr-tracker-bot
2020-10-12 21:10 ` Linus Torvalds
2020-10-12 21:15 ` Mike Travis [this message]
2020-10-12 21:27 ` Borislav Petkov
2020-10-12 21:42 ` Mike Travis
2020-10-12 21:46 ` Linus Torvalds
2020-10-12 21:56 ` Borislav Petkov
2020-10-12 22:00 ` Mike Travis
2020-10-12 21:58 ` Mike Travis
2020-10-13 11:11 ` Borislav Petkov
2020-10-13 12:33 ` Mike Travis
2020-10-13 13:29 ` Borislav Petkov
2020-10-13 13:37 ` Mike Travis
2020-10-13 14:25 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8cfb3d2-d3c4-6d8d-1dfd-aeb349e26303@hpe.com \
--to=mike.travis@hpe.com \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).