linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Travis <mike.travis@hpe.com>
To: Borislav Petkov <bp@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] x86/platform updates for v5.10
Date: Mon, 12 Oct 2020 14:58:07 -0700	[thread overview]
Message-ID: <d865e9cd-38c9-2210-116b-935336a3738f@hpe.com> (raw)
In-Reply-To: <f778b25e-68e7-98ec-9032-b35696948405@hpe.com>



On 10/12/2020 2:42 PM, Mike Travis wrote:
> 
> 
> On 10/12/2020 2:27 PM, Borislav Petkov wrote:
>> On Mon, Oct 12, 2020 at 02:15:55PM -0700, Mike Travis wrote:
>>>> Of course, it also looks like that 'uvh_nmi_mmrx_mask' thing is a
>>>> write-only variable so it doesn't matter, but can we _please_ get this
>>>> code fixed ASAP?
>>>
>>> Yes, I'll look at it right now.  Thanks.
>>
>> As this variable is write-only you could simply zap it now with a patch
>> ontop to fix the build and then introduce it properly later, when you
>> really need it?
>>
> 
> It should have been an unsigned long instead of an int as Linus 
> suggested.  I'm not sure it's a write only variable as I think the mask 
> is used to check if the interrupt occurred (I'll have to look closer). 
> I'm trying now to send the fixed patch.  It only has this change:
> 
> dog 74> diff -u patches/uv5_update_nmi{.v1,}
> --- patches/uv5_update_nmi.v1   2020-10-12 16:30:06.083941459 -0500
> +++ patches/uv5_update_nmi      2020-10-12 16:30:46.663903731 -0500
> @@ -55,7 +55,7 @@
>   +static unsigned long uvh_nmi_mmrx;            /* 
> UVH_EVENT_OCCURRED0/1 */
>   +static unsigned long uvh_nmi_mmrx_clear;      /* 
> UVH_EVENT_OCCURRED0/1_ALIAS */
>   +static int uvh_nmi_mmrx_shift;                        /* 
> UVH_EVENT_OCCURRED0/1_EXTIO_INT0_SHFT */
> -+static int uvh_nmi_mmrx_mask;                 /* 
> UVH_EVENT_OCCURRED0/1_EXTIO_INT0_MASK */
> ++static unsigned long uvh_nmi_mmrx_mask;               /* 
> UVH_EVENT_OCCURRED0/1_EXTIO_INT0_MASK */
>   +static char *uvh_nmi_mmrx_type;                       /* "EXTIO_INT0" */
>   +
>   +/* Non-zero indicates newer SMM NMI handler present */
> 
> (or quoted)
> 
>> dog 74> diff -u patches/uv5_update_nmi{.v1,}
>> --- patches/uv5_update_nmi.v1   2020-10-12 16:30:06.083941459 -0500
>> +++ patches/uv5_update_nmi      2020-10-12 16:30:46.663903731 -0500
>> @@ -55,7 +55,7 @@
>>  +static unsigned long uvh_nmi_mmrx;            /* 
>> UVH_EVENT_OCCURRED0/1 */
>>  +static unsigned long uvh_nmi_mmrx_clear;      /* 
>> UVH_EVENT_OCCURRED0/1_ALIAS */
>>  +static int uvh_nmi_mmrx_shift;                        /* 
>> UVH_EVENT_OCCURRED0/1_EXTIO_INT0_SHFT */
>> -+static int uvh_nmi_mmrx_mask;                 /* 
>> UVH_EVENT_OCCURRED0/1_EXTIO_INT0_MASK */
>> ++static unsigned long uvh_nmi_mmrx_mask;               /* 
>> UVH_EVENT_OCCURRED0/1_EXTIO_INT0_MASK */
>>  +static char *uvh_nmi_mmrx_type;                       /* 
>> "EXTIO_INT0" */
>>  +
>>  +/* Non-zero indicates newer SMM NMI handler present */

I was in the process of tracing it through and perhaps it does need a 
bit more analysis to be correct.  What does it mean to send a patch to 
fix the compile error, just remove it?

  parent reply	other threads:[~2020-10-12 21:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 10:10 [GIT PULL] x86/platform updates for v5.10 Borislav Petkov
2020-10-12 18:21 ` pr-tracker-bot
2020-10-12 21:10 ` Linus Torvalds
2020-10-12 21:15   ` Mike Travis
2020-10-12 21:27     ` Borislav Petkov
2020-10-12 21:42       ` Mike Travis
2020-10-12 21:46         ` Linus Torvalds
2020-10-12 21:56           ` Borislav Petkov
2020-10-12 22:00             ` Mike Travis
2020-10-12 21:58         ` Mike Travis [this message]
2020-10-13 11:11           ` Borislav Petkov
2020-10-13 12:33             ` Mike Travis
2020-10-13 13:29               ` Borislav Petkov
2020-10-13 13:37                 ` Mike Travis
2020-10-13 14:25                   ` Mike Travis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d865e9cd-38c9-2210-116b-935336a3738f@hpe.com \
    --to=mike.travis@hpe.com \
    --cc=bp@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).