From: Gavin Shan <firstname.lastname@example.org>
To: Randy Dunlap <email@example.com>, firstname.lastname@example.org
Cc: email@example.com, firstname.lastname@example.org,
Subject: Re: [PATCH v3] Documentation, dt, numa: Add note to empty NUMA node
Date: Fri, 25 Jun 2021 15:25:19 +1000 [thread overview]
Message-ID: <email@example.com> (raw)
On 6/25/21 2:49 PM, Randy Dunlap wrote:
> On 6/24/21 9:32 PM, Gavin Shan wrote:
>> On 6/25/21 1:47 PM, Randy Dunlap wrote:
>>> On 6/24/21 9:30 PM, Gavin Shan wrote:
>>>> The empty NUMA nodes, where no memory resides in, are allowed. For
>>>> these empty NUMA nodes, the 'len' of 'reg' property is zero. These
>>>> empty NUMA node IDs are still valid and parsed. I finds difficulty
>>>> to get where it's properly documented.
>>>> So lets add note to empty NUMA nodes in the NUMA binding doc.
>>>> Signed-off-by: Gavin Shan <firstname.lastname@example.org>
>>>> Documentation/devicetree/bindings/numa.txt | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>> diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt
>>>> index 21b35053ca5a..edf728cff155 100644
>>>> --- a/Documentation/devicetree/bindings/numa.txt
>>>> +++ b/Documentation/devicetree/bindings/numa.txt
>>>> @@ -109,6 +109,10 @@ Example:
>>>> Dual socket system consists of 2 boards connected through ccn bus and
>>>> each board having one socket/soc of 8 cpus, memory and pci bus.
>>>> +Note that the empty NUMA nodes, which no memory resides in, are allowed.
>>> I would write that without "the":
>>> +Note that empty NUMA nodes, which no memory resides in, are allowed.
>>> BTW, AFAIK, NUMA nodes may contain memory, CPU(s), or I/O -- any one, two, or
>>> three, without the other types of resources being present.
>> Sure, I will drop "the" in v4.
>> The NUMA nodes here are memory nodes here. Since the NUMA node usually means
>> memory node. I'm not sure if I change the term "NUMA node" to "NUMA memory
>> node" in v4. If you agree, I would have something like this:
>> Note that empty memory nodes, which no memory resides in, are allowed.
>> The NUMA node IDs in these empty memory nodes are still valid, but memory
>> can be added into them through hotplug afterwards.
> OK, that sounds fine to me.
Thanks, Randy. I just posted v4 to include the changes.
prev parent reply other threads:[~2021-06-25 5:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 4:30 [PATCH v3] Documentation, dt, numa: Add note to empty NUMA node Gavin Shan
2021-06-25 3:47 ` Randy Dunlap
2021-06-25 4:32 ` Gavin Shan
2021-06-25 4:49 ` Randy Dunlap
2021-06-25 5:25 ` Gavin Shan [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).