* [PATCH -next] HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices
@ 2019-05-25 14:09 YueHaibing
2019-06-11 3:00 ` Yuehaibing
0 siblings, 1 reply; 4+ messages in thread
From: YueHaibing @ 2019-05-25 14:09 UTC (permalink / raw)
To: jikos, benjamin.tissoires; +Cc: linux-kernel, linux-input, YueHaibing
We should return 'retval' as the correct return value
instead of always zero.
Fixes: 74808f9115ce ("HID: logitech-dj: add support for non unifying receivers")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/hid/hid-logitech-dj.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
index 41baa4dbbfcc..7f8db602eec0 100644
--- a/drivers/hid/hid-logitech-dj.c
+++ b/drivers/hid/hid-logitech-dj.c
@@ -1133,7 +1133,7 @@ static int logi_dj_recv_query_hidpp_devices(struct dj_receiver_dev *djrcv_dev)
HID_REQ_SET_REPORT);
kfree(hidpp_report);
- return 0;
+ return retval;
}
static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices
2019-05-25 14:09 [PATCH -next] HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices YueHaibing
@ 2019-06-11 3:00 ` Yuehaibing
2019-06-11 8:39 ` Hans de Goede
2019-06-11 10:48 ` Benjamin Tissoires
0 siblings, 2 replies; 4+ messages in thread
From: Yuehaibing @ 2019-06-11 3:00 UTC (permalink / raw)
To: jikos, benjamin.tissoires, hdegoede, jkosina, benjamin.tissoires
Cc: linux-kernel, linux-input
Hi all,
Friendly ping...
On 2019/5/25 22:09, YueHaibing wrote:
> We should return 'retval' as the correct return value
> instead of always zero.
>
> Fixes: 74808f9115ce ("HID: logitech-dj: add support for non unifying receivers")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/hid/hid-logitech-dj.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> index 41baa4dbbfcc..7f8db602eec0 100644
> --- a/drivers/hid/hid-logitech-dj.c
> +++ b/drivers/hid/hid-logitech-dj.c
> @@ -1133,7 +1133,7 @@ static int logi_dj_recv_query_hidpp_devices(struct dj_receiver_dev *djrcv_dev)
> HID_REQ_SET_REPORT);
>
> kfree(hidpp_report);
> - return 0;
> + return retval;
> }
>
> static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev)
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices
2019-06-11 3:00 ` Yuehaibing
@ 2019-06-11 8:39 ` Hans de Goede
2019-06-11 10:48 ` Benjamin Tissoires
1 sibling, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2019-06-11 8:39 UTC (permalink / raw)
To: Yuehaibing, jikos, benjamin.tissoires, jkosina; +Cc: linux-kernel, linux-input
Hi,
On 11-06-19 05:00, Yuehaibing wrote:
> Hi all,
>
> Friendly ping...
>
> On 2019/5/25 22:09, YueHaibing wrote:
>> We should return 'retval' as the correct return value
>> instead of always zero.
>>
>> Fixes: 74808f9115ce ("HID: logitech-dj: add support for non unifying receivers")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
>> ---
>> drivers/hid/hid-logitech-dj.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
>> index 41baa4dbbfcc..7f8db602eec0 100644
>> --- a/drivers/hid/hid-logitech-dj.c
>> +++ b/drivers/hid/hid-logitech-dj.c
>> @@ -1133,7 +1133,7 @@ static int logi_dj_recv_query_hidpp_devices(struct dj_receiver_dev *djrcv_dev)
>> HID_REQ_SET_REPORT);
>>
>> kfree(hidpp_report);
>> - return 0;
>> + return retval;
>> }
>>
>> static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev)
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices
2019-06-11 3:00 ` Yuehaibing
2019-06-11 8:39 ` Hans de Goede
@ 2019-06-11 10:48 ` Benjamin Tissoires
1 sibling, 0 replies; 4+ messages in thread
From: Benjamin Tissoires @ 2019-06-11 10:48 UTC (permalink / raw)
To: Yuehaibing
Cc: Jiri Kosina, Hans de Goede, jkosina, lkml, open list:HID CORE LAYER
On Tue, Jun 11, 2019 at 5:01 AM Yuehaibing <yuehaibing@huawei.com> wrote:
>
> Hi all,
>
> Friendly ping...
Applied to for-5.3/logitech
Thanks!
Cheers,
Benjamin
>
> On 2019/5/25 22:09, YueHaibing wrote:
> > We should return 'retval' as the correct return value
> > instead of always zero.
> >
> > Fixes: 74808f9115ce ("HID: logitech-dj: add support for non unifying receivers")
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> > drivers/hid/hid-logitech-dj.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> > index 41baa4dbbfcc..7f8db602eec0 100644
> > --- a/drivers/hid/hid-logitech-dj.c
> > +++ b/drivers/hid/hid-logitech-dj.c
> > @@ -1133,7 +1133,7 @@ static int logi_dj_recv_query_hidpp_devices(struct dj_receiver_dev *djrcv_dev)
> > HID_REQ_SET_REPORT);
> >
> > kfree(hidpp_report);
> > - return 0;
> > + return retval;
> > }
> >
> > static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev)
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-11 10:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-25 14:09 [PATCH -next] HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices YueHaibing
2019-06-11 3:00 ` Yuehaibing
2019-06-11 8:39 ` Hans de Goede
2019-06-11 10:48 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).