[PATCH 5.4 000/134] 5.4.231-rc1 review

[PATCH 5.4 000/134] 5.4.231-rc1 review

[Greg Kroah-Hartman]

This is the start of the stable review cycle for the 5.4.231 release.
There are 134 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.

Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.231-rc1.gz
or in the git tree and branch at:
	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Linux 5.4.231-rc1

Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Revert "xprtrdma: Fix regbuf data not freed in rpcrdma_req_create()"

Peter Chen <peter.chen@nxp.com>
    usb: host: xhci-plat: add wakeup entry at sysfs

Soenke Huster <soenke.huster@eknoes.de>
    Bluetooth: fix null ptr deref on hci_sync_conn_complete_evt

Eric Dumazet <edumazet@google.com>
    ipv6: ensure sane device mtu in tunnels

Kees Cook <keescook@chromium.org>
    exit: Use READ_ONCE() for all oops/warn limit reads

Kees Cook <keescook@chromium.org>
    docs: Fix path paste-o for /sys/kernel/warn_count

Kees Cook <keescook@chromium.org>
    panic: Expose "warn_count" to sysfs

Kees Cook <keescook@chromium.org>
    panic: Introduce warn_limit

Kees Cook <keescook@chromium.org>
    panic: Consolidate open-coded panic_on_warn checks

Kees Cook <keescook@chromium.org>
    exit: Allow oops_limit to be disabled

Kees Cook <keescook@chromium.org>
    exit: Expose "oops_count" to sysfs

Jann Horn <jannh@google.com>
    exit: Put an upper limit on how often we can oops

Randy Dunlap <rdunlap@infradead.org>
    ia64: make IA64_MCA_RECOVERY bool instead of tristate

Nathan Chancellor <nathan@kernel.org>
    csky: Fix function name in csky_alignment() and die()

Nathan Chancellor <nathan@kernel.org>
    h8300: Fix build errors from do_exit() to make_task_dead() transition

Nathan Chancellor <nathan@kernel.org>
    hexagon: Fix function name in die()

Eric W. Biederman <ebiederm@xmission.com>
    objtool: Add a missing comma to avoid string concatenation

Eric W. Biederman <ebiederm@xmission.com>
    exit: Add and use make_task_dead.

David Gow <davidgow@google.com>
    mm: kasan: do not panic if both panic_on_warn and kasan_multishot set

Tiezhu Yang <yangtiezhu@loongson.cn>
    panic: unset panic_on_warn inside panic()

Xiaoming Ni <nixiaoming@huawei.com>
    sysctl: add a new register_sysctl_init() interface

Hui Wang <hui.wang@canonical.com>
    dmaengine: imx-sdma: Fix a possible memory leak in sdma_transfer_init

Yu Kuai <yukuai3@huawei.com>
    blk-cgroup: fix missing pd_online_fn() while activating policy

Hao Sun <sunhao.th@gmail.com>
    bpf: Skip task with pid=1 in send_signal_common()

Geert Uytterhoeven <geert+renesas@glider.be>
    ARM: dts: imx: Fix pca9547 i2c-mux node name

Mikulas Patocka <mpatocka@redhat.com>
    x86/asm: Fix an assembler warning with current binutils

Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    clk: Fix pointer casting to prevent oops in devm_clk_release()

Colin Ian King <colin.i.king@gmail.com>
    perf/x86/amd: fix potential integer overflow on shift of a int

Sriram Yagnaraman <sriram.yagnaraman@est.tech>
    netfilter: conntrack: unify established states for SCTP paths

Thomas Gleixner <tglx@linutronix.de>
    x86/i8259: Mark legacy PIC interrupts with IRQ_LEVEL

Christoph Hellwig <hch@lst.de>
    block: fix and cleanup bio_check_ro

Trond Myklebust <trond.myklebust@hammerspace.com>
    nfsd: Ensure knfsd shuts down when the "nfsd" pseudofs is unmounted

Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Revert "Input: synaptics - switch touchpad on HP Laptop 15-da3001TU to RMI mode"

Jerome Brunet <jbrunet@baylibre.com>
    net: mdio-mux-meson-g12a: force internal PHY off on mux switch

Andrew Lunn <andrew@lunn.ch>
    net: xgene: Move shared header file into include/linux

Andrew Lunn <andrew@lunn.ch>
    net/phy/mdio-i2c: Move header file to include/linux/mdio

David Christensen <drc@linux.vnet.ibm.com>
    net/tg3: resolve deadlock in tg3_reset_task() during EEH

Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    thermal: intel: int340x: Add locking to int340x_thermal_get_trip_type()

Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
    net: ravb: Fix possible hang if RIS2_QFF1 happen

Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
    sctp: fail if no bound addresses can be used for a given scope

Eric Dumazet <edumazet@google.com>
    net/sched: sch_taprio: do not schedule in taprio_reset()

Kuniyuki Iwashima <kuniyu@amazon.com>
    netrom: Fix use-after-free of a listening socket.

Sriram Yagnaraman <sriram.yagnaraman@est.tech>
    netfilter: conntrack: fix vtag checks for ABORT/SHUTDOWN_COMPLETE

Eric Dumazet <edumazet@google.com>
    ipv4: prevent potential spectre v1 gadget in fib_metrics_match()

Eric Dumazet <edumazet@google.com>
    ipv4: prevent potential spectre v1 gadget in ip_metrics_convert()

Eric Dumazet <edumazet@google.com>
    netlink: annotate data races around sk_state

Eric Dumazet <edumazet@google.com>
    netlink: annotate data races around dst_portid and dst_group

Eric Dumazet <edumazet@google.com>
    netlink: annotate data races around nlk->portid

Pablo Neira Ayuso <pablo@netfilter.org>
    netfilter: nft_set_rbtree: skip elements in transaction from garbage collection

Paolo Abeni <pabeni@redhat.com>
    net: fix UaF in netns ops registration error path

Eric Dumazet <edumazet@google.com>
    netlink: prevent potential spectre v1 gadgets

Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    EDAC/qcom: Do not pass llcc_driv_data as edac_device_ctl_info's pvt_info

Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    EDAC/device: Respect any driver-supplied workqueue polling value

Giulio Benetti <giulio.benetti@benettiengineering.com>
    ARM: 9280/1: mm: fix warning on phys_addr_t to void pointer assignment

Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
    thermal: intel: int340x: Protect trip temperature from concurrent updates

Hendrik Borghorst <hborghor@amazon.de>
    KVM: x86/vmx: Do not skip segment attributes if unusable bit is set

David Howells <dhowells@redhat.com>
    cifs: Fix oops due to uncleared server->smbd_conn in reconnect

Steven Rostedt (Google) <rostedt@goodmis.org>
    ftrace/scripts: Update the instructions for ftrace-bisect.sh

Natalia Petrova <n.petrova@fintech.ru>
    trace_events_hist: add check for return value of 'create_hist_field'

Steven Rostedt (Google) <rostedt@goodmis.org>
    tracing: Make sure trace_printk() can output as soon as it can be used

Petr Pavlu <petr.pavlu@suse.com>
    module: Don't wait for GOING modules

Alexey V. Vissarionov <gremlin@altlinux.org>
    scsi: hpsa: Fix allocation size for scsi_host_alloc()

Archie Pusaka <apusaka@chromium.org>
    Bluetooth: hci_sync: cancel cmd_timer if hci_open failed

Sasha Levin <sashal@kernel.org>
    Revert "Revert "xhci: Set HCD flag to defer primary roothub registration""

Dongliang Mu <mudongliangabcd@gmail.com>
    fs: reiserfs: remove useless new_opts in reiserfs_remount

Florian Westphal <fw@strlen.de>
    netfilter: conntrack: do not renew entry stuck in tcp SYN_SENT state

Sasha Levin <sashal@kernel.org>
    Revert "selftests/bpf: check null propagation only neither reg is PTR_TO_BTF_ID"

Haibo Chen <haibo.chen@nxp.com>
    mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting

Haibo Chen <haibo.chen@nxp.com>
    mmc: sdhci-esdhc-imx: disable the CMD CRC check for standard tuning

Haibo Chen <haibo.chen@nxp.com>
    mmc: sdhci-esdhc-imx: clear pending interrupt and halt cqhci

Mateusz Guzik <mjguzik@gmail.com>
    lockref: stop doing cpu_relax in the cmpxchg loop

Hans de Goede <hdegoede@redhat.com>
    platform/x86: asus-nb-wmi: Add alternate mapping for KEY_SCREENLOCK

Michael Klein <m.klein@mvz-labor-lb.de>
    platform/x86: touchscreen_dmi: Add info for the CSL Panther Tab HD

Yihang Li <liyihang9@huawei.com>
    scsi: hisi_sas: Set a port invalid only if there are no devices attached when refreshing port id

Heiko Carstens <hca@linux.ibm.com>
    KVM: s390: interrupt: use READ_ONCE() before cmpxchg()

Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
    spi: spidev: remove debug messages that access spidev->spi without locking

Mark Brown <broonie@kernel.org>
    ASoC: fsl-asoc-card: Fix naming of AC'97 CODEC widgets

Mark Brown <broonie@kernel.org>
    ASoC: fsl_ssi: Rename AC'97 streams to avoid collisions with AC'97 CODEC

Miles Chen <miles.chen@mediatek.com>
    cpufreq: armada-37xx: stop using 0 as NULL pointer

Niklas Schnelle <schnelle@linux.ibm.com>
    s390/debug: add _ASM_S390_ prefix to header guard

Patrick Thompson <ptf@google.com>
    drm: Add orientation quirk for Lenovo ideapad D330-10IGL

Chancel Liu <chancel.liu@nxp.com>
    ASoC: fsl_micfil: Correct the number of steps on SX controls

Sumit Gupta <sumitg@nvidia.com>
    cpufreq: Add Tegra234 to cpufreq-dt-platdev blocklist

David Morley <morleyd@google.com>
    tcp: fix rate_app_limited to default to 1

Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>
    net: dsa: microchip: ksz9477: port map correction in ALU table entry register

Chen Zhongjin <chenzhongjin@huawei.com>
    driver core: Fix test_async_probe_init saves device in wrong array

Yang Yingliang <yangyingliang@huawei.com>
    w1: fix WARNING after calling w1_process()

Yang Yingliang <yangyingliang@huawei.com>
    w1: fix deadloop in __w1_remove_master_device()

Jason Xing <kernelxing@tencent.com>
    tcp: avoid the lookup process failing to get sk in ehash table

Liu Shixin <liushixin2@huawei.com>
    dmaengine: xilinx_dma: call of_node_put() when breaking out of for_each_child_of_node()

Swati Agarwal <swati.agarwal@xilinx.com>
    dmaengine: xilinx_dma: Fix devm_platform_ioremap_resource error handling

Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
    dmaengine: xilinx_dma: use devm_platform_ioremap_resource()

Pietro Borrello <borrello@diag.uniroma1.it>
    HID: betop: check shape of output reports

Robert Hancock <robert.hancock@calian.com>
    net: macb: fix PTP TX timestamp failure due to packet padding

Koba Ko <koba.ko@canonical.com>
    dmaengine: Fix double increment of client_count in dma_chan_get()

Arnd Bergmann <arnd@arndb.de>
    drm/panfrost: fix GENERIC_ATOMIC64 dependency

Randy Dunlap <rdunlap@infradead.org>
    net: mlx5: eliminate anonymous module_init & module_exit

Udipto Goswami <quic_ugoswami@quicinc.com>
    usb: gadget: f_fs: Ensure ep0req is dequeued before free_request

Udipto Goswami <quic_ugoswami@quicinc.com>
    usb: gadget: f_fs: Prevent race during ffs_ep0_queue_wait

Jiri Kosina <jkosina@suse.cz>
    HID: revert CHERRY_MOUSE_000C quirk

Heiner Kallweit <hkallweit1@gmail.com>
    net: stmmac: fix invalid call to mdiobus_get_phy()

Pietro Borrello <borrello@diag.uniroma1.it>
    HID: check empty report_list in bigben_probe()

Pietro Borrello <borrello@diag.uniroma1.it>
    HID: check empty report_list in hid_validate_values()

Heiner Kallweit <hkallweit1@gmail.com>
    net: mdio: validate parameter addr in mdiobus_get_phy()

Szymon Heidrich <szymon.heidrich@gmail.com>
    net: usb: sr9700: Handle negative len

Jakub Sitnicki <jakub@cloudflare.com>
    l2tp: Don't sleep and disable BH under writer-side sk_callback_lock

Jakub Sitnicki <jakub@cloudflare.com>
    l2tp: Serialize access to sk_user_data with sk_callback_lock

Gong, Sishuai <sishuai@purdue.edu>
    net: fix a concurrency bug in l2tp_tunnel_register()

Eric Dumazet <edumazet@google.com>
    net/sched: sch_taprio: fix possible use-after-free

Szymon Heidrich <szymon.heidrich@gmail.com>
    wifi: rndis_wlan: Prevent buffer overflow in rndis_query_oid

Marek Vasut <marex@denx.de>
    gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode

Esina Ekaterina <eesina@astralinux.ru>
    net: wan: Add checks for NULL for utdm in undo_uhdlc_init and unmap_si_regs

Jisoo Jang <jisoo.jang@yonsei.ac.kr>
    net: nfc: Fix use-after-free in local_cleanup()

Shang XiaoJing <shangxiaojing@huawei.com>
    phy: rockchip-inno-usb2: Fix missing clk_disable_unprepare() in rockchip_usb2phy_power_on()

Luis Gerhorst <gerhorst@cs.fau.de>
    bpf: Fix pointer-leak due to insufficient speculative store bypass mitigation

Raju Rangoju <Raju.Rangoju@amd.com>
    amd-xgbe: Delay AN timeout during KR training

Raju Rangoju <Raju.Rangoju@amd.com>
    amd-xgbe: TX Flow Ctrl Registers are h/w ver dependent

Alexander Potapenko <glider@google.com>
    affs: initialize fsdata in affs_truncate()

Dean Luick <dean.luick@cornelisnetworks.com>
    IB/hfi1: Fix expected receive setup error exit issues

Dean Luick <dean.luick@cornelisnetworks.com>
    IB/hfi1: Reserve user expected TIDs

Dean Luick <dean.luick@cornelisnetworks.com>
    IB/hfi1: Reject a zero-length user expected buffer

Yonatan Nachum <ynachum@amazon.com>
    RDMA/core: Fix ib block iterator counter overflow

Masahiro Yamada <masahiroy@kernel.org>
    tomoyo: fix broken dependency on *.conf.default

Miaoqian Lin <linmq006@gmail.com>
    EDAC/highbank: Fix memory leak in highbank_mc_probe()

Jiasheng Jiang <jiasheng@iscas.ac.cn>
    HID: intel_ish-hid: Add check for ishtp_dma_tx_map

Dario Binacchi <dario.binacchi@amarulasolutions.com>
    ARM: imx: add missing of_node_put()

Fabio Estevam <festevam@gmail.com>
    ARM: imx35: Retrieve the IIM base address from devicetree

Fabio Estevam <festevam@gmail.com>
    ARM: imx31: Retrieve the IIM base address from devicetree

Fabio Estevam <festevam@gmail.com>
    ARM: imx27: Retrieve the SYSCTRL base address from devicetree

Fabio Estevam <festevam@denx.de>
    ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'

Gaosheng Cui <cuigaosheng1@huawei.com>
    memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()

Gaosheng Cui <cuigaosheng1@huawei.com>
    memory: atmel-sdramc: Fix missing clk_disable_unprepare in atmel_ramc_probe()

Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    clk: Provide new devm_clk helpers for prepared and enabled clocks

Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    clk: generalize devm_clk_get() a bit


-------------

Diffstat:

 Documentation/ABI/testing/sysfs-kernel-oops_count  |   6 ++
 Documentation/ABI/testing/sysfs-kernel-warn_count  |   6 ++
 Documentation/admin-guide/sysctl/kernel.rst        |  19 ++++
 MAINTAINERS                                        |   1 +
 Makefile                                           |   4 +-
 arch/alpha/kernel/traps.c                          |   6 +-
 arch/alpha/mm/fault.c                              |   2 +-
 arch/arm/boot/dts/imx53-ppd.dts                    |   2 +-
 arch/arm/boot/dts/imx6qdl-gw560x.dtsi              |   1 -
 arch/arm/kernel/traps.c                            |   2 +-
 arch/arm/mach-imx/cpu-imx25.c                      |   1 +
 arch/arm/mach-imx/cpu-imx27.c                      |  11 +-
 arch/arm/mach-imx/cpu-imx31.c                      |  10 +-
 arch/arm/mach-imx/cpu-imx35.c                      |  10 +-
 arch/arm/mach-imx/cpu-imx5.c                       |   1 +
 arch/arm/mm/fault.c                                |   2 +-
 arch/arm/mm/nommu.c                                |   2 +-
 arch/arm64/kernel/traps.c                          |   2 +-
 arch/arm64/mm/fault.c                              |   2 +-
 arch/csky/abiv1/alignment.c                        |   2 +-
 arch/csky/kernel/traps.c                           |   2 +-
 arch/h8300/kernel/traps.c                          |   3 +-
 arch/h8300/mm/fault.c                              |   2 +-
 arch/hexagon/kernel/traps.c                        |   2 +-
 arch/ia64/Kconfig                                  |   2 +-
 arch/ia64/kernel/mca_drv.c                         |   2 +-
 arch/ia64/kernel/traps.c                           |   2 +-
 arch/ia64/mm/fault.c                               |   2 +-
 arch/m68k/kernel/traps.c                           |   2 +-
 arch/m68k/mm/fault.c                               |   2 +-
 arch/microblaze/kernel/exceptions.c                |   4 +-
 arch/mips/kernel/traps.c                           |   2 +-
 arch/nds32/kernel/fpu.c                            |   2 +-
 arch/nds32/kernel/traps.c                          |   8 +-
 arch/nios2/kernel/traps.c                          |   4 +-
 arch/openrisc/kernel/traps.c                       |   2 +-
 arch/parisc/kernel/traps.c                         |   2 +-
 arch/powerpc/kernel/traps.c                        |   2 +-
 arch/riscv/kernel/traps.c                          |   2 +-
 arch/riscv/mm/fault.c                              |   2 +-
 arch/s390/include/asm/debug.h                      |   6 +-
 arch/s390/kernel/dumpstack.c                       |   2 +-
 arch/s390/kernel/nmi.c                             |   2 +-
 arch/s390/kvm/interrupt.c                          |  12 ++-
 arch/sh/kernel/traps.c                             |   2 +-
 arch/sparc/kernel/traps_32.c                       |   4 +-
 arch/sparc/kernel/traps_64.c                       |   4 +-
 arch/x86/entry/entry_32.S                          |   6 +-
 arch/x86/entry/entry_64.S                          |   6 +-
 arch/x86/events/amd/core.c                         |   2 +-
 arch/x86/kernel/dumpstack.c                        |   4 +-
 arch/x86/kernel/i8259.c                            |   1 +
 arch/x86/kernel/irqinit.c                          |   4 +-
 arch/x86/kvm/vmx/vmx.c                             |  21 ++--
 arch/x86/lib/iomap_copy_64.S                       |   2 +-
 arch/xtensa/kernel/traps.c                         |   2 +-
 block/blk-cgroup.c                                 |   4 +
 block/blk-core.c                                   |   5 +-
 drivers/base/test/test_async_driver_probe.c        |   2 +-
 drivers/clk/clk-devres.c                           |  91 +++++++++++++---
 drivers/cpufreq/armada-37xx-cpufreq.c              |   2 +-
 drivers/cpufreq/cpufreq-dt-platdev.c               |   1 +
 drivers/dma/dmaengine.c                            |   7 +-
 drivers/dma/imx-sdma.c                             |   4 +-
 drivers/dma/xilinx/xilinx_dma.c                    |  21 ++--
 drivers/edac/edac_device.c                         |  15 ++-
 drivers/edac/highbank_mc_edac.c                    |   7 +-
 drivers/edac/qcom_edac.c                           |   5 +-
 drivers/gpio/gpio-mxc.c                            |   2 +-
 drivers/gpu/drm/drm_panel_orientation_quirks.c     |   6 ++
 drivers/gpu/drm/panfrost/Kconfig                   |   3 +-
 drivers/hid/hid-betopff.c                          |  17 +--
 drivers/hid/hid-bigbenff.c                         |   5 +
 drivers/hid/hid-core.c                             |   4 +-
 drivers/hid/hid-ids.h                              |   1 -
 drivers/hid/hid-quirks.c                           |   1 -
 drivers/hid/intel-ish-hid/ishtp/dma-if.c           |  10 ++
 drivers/infiniband/core/verbs.c                    |   7 +-
 drivers/infiniband/hw/hfi1/user_exp_rcv.c          | 101 ++++++++++--------
 drivers/input/mouse/synaptics.c                    |   1 -
 drivers/memory/atmel-sdramc.c                      |   6 +-
 drivers/memory/mvebu-devbus.c                      |   3 +-
 drivers/mmc/host/sdhci-esdhc-imx.c                 |  53 +++++++--
 drivers/net/dsa/microchip/ksz9477.c                |   4 +-
 drivers/net/ethernet/amd/xgbe/xgbe-dev.c           |  23 ++--
 drivers/net/ethernet/amd/xgbe/xgbe-mdio.c          |  24 +++++
 drivers/net/ethernet/amd/xgbe/xgbe.h               |   2 +
 drivers/net/ethernet/apm/xgene/xgene_enet_main.h   |   2 +-
 drivers/net/ethernet/broadcom/tg3.c                |   8 +-
 drivers/net/ethernet/cadence/macb_main.c           |   9 +-
 drivers/net/ethernet/mellanox/mlx5/core/main.c     |   8 +-
 drivers/net/ethernet/renesas/ravb_main.c           |   4 +-
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c  |   5 +
 drivers/net/phy/mdio-i2c.c                         |   3 +-
 drivers/net/phy/mdio-mux-meson-g12a.c              |  23 ++--
 drivers/net/phy/mdio-xgene.c                       |   2 +-
 drivers/net/phy/mdio_bus.c                         |   7 +-
 drivers/net/phy/sfp.c                              |   2 +-
 drivers/net/usb/sr9700.c                           |   2 +-
 drivers/net/wan/fsl_ucc_hdlc.c                     |   6 +-
 drivers/net/wireless/rndis_wlan.c                  |  19 ++--
 drivers/phy/rockchip/phy-rockchip-inno-usb2.c      |   4 +-
 drivers/platform/x86/asus-nb-wmi.c                 |   1 +
 drivers/platform/x86/touchscreen_dmi.c             |  25 +++++
 drivers/scsi/hisi_sas/hisi_sas_main.c              |   2 +-
 drivers/scsi/hpsa.c                                |   2 +-
 drivers/spi/spidev.c                               |   2 -
 .../intel/int340x_thermal/int340x_thermal_zone.c   |  28 +++--
 .../intel/int340x_thermal/int340x_thermal_zone.h   |   1 +
 drivers/usb/gadget/function/f_fs.c                 |   7 ++
 drivers/usb/host/xhci-plat.c                       |   2 +-
 drivers/usb/host/xhci.c                            |   1 +
 drivers/w1/w1.c                                    |   6 +-
 drivers/w1/w1_int.c                                |   5 +-
 fs/affs/file.c                                     |   2 +-
 fs/cifs/smbdirect.c                                |   1 +
 fs/nfsd/netns.h                                    |   6 +-
 fs/nfsd/nfs4state.c                                |   8 +-
 fs/nfsd/nfsctl.c                                   |  14 +--
 fs/nfsd/nfsd.h                                     |   3 +-
 fs/nfsd/nfssvc.c                                   |  35 +++++-
 fs/proc/proc_sysctl.c                              |  33 ++++++
 fs/reiserfs/super.c                                |   6 --
 include/linux/clk.h                                | 109 +++++++++++++++++++
 include/linux/kernel.h                             |   1 +
 {drivers/net/phy => include/linux/mdio}/mdio-i2c.h |   0
 .../net/phy => include/linux/mdio}/mdio-xgene.h    |   0
 include/linux/sched/task.h                         |   1 +
 include/linux/sysctl.h                             |   3 +
 include/net/sch_generic.h                          |   7 ++
 include/net/sock.h                                 |   2 +-
 include/uapi/linux/netfilter/nf_conntrack_sctp.h   |   2 +-
 include/uapi/linux/netfilter/nfnetlink_cttimeout.h |   2 +-
 kernel/bpf/verifier.c                              |   4 +-
 kernel/exit.c                                      |  72 +++++++++++++
 kernel/module.c                                    |  26 ++++-
 kernel/panic.c                                     |  75 +++++++++++--
 kernel/sched/core.c                                |   3 +-
 kernel/trace/bpf_trace.c                           |   3 +
 kernel/trace/trace.c                               |   2 +
 kernel/trace/trace.h                               |   1 +
 kernel/trace/trace_events_hist.c                   |   2 +
 kernel/trace/trace_output.c                        |   3 +-
 lib/lockref.c                                      |   1 -
 lib/nlattr.c                                       |   3 +
 mm/kasan/report.c                                  |   4 +-
 net/bluetooth/hci_core.c                           |   1 +
 net/bluetooth/hci_event.c                          |  13 +++
 net/core/net_namespace.c                           |   2 +-
 net/ipv4/fib_semantics.c                           |   2 +
 net/ipv4/inet_hashtables.c                         |  17 ++-
 net/ipv4/inet_timewait_sock.c                      |   8 +-
 net/ipv4/metrics.c                                 |   2 +
 net/ipv4/tcp.c                                     |   2 +
 net/ipv6/ip6_gre.c                                 |  12 ++-
 net/ipv6/ip6_tunnel.c                              |  10 +-
 net/ipv6/sit.c                                     |   8 +-
 net/l2tp/l2tp_core.c                               |  30 ++++--
 net/netfilter/nf_conntrack_proto_sctp.c            | 118 ++++++++++-----------
 net/netfilter/nf_conntrack_proto_tcp.c             |  10 ++
 net/netfilter/nf_conntrack_standalone.c            |   8 --
 net/netfilter/nft_set_rbtree.c                     |  16 ++-
 net/netlink/af_netlink.c                           |  38 ++++---
 net/netrom/nr_timer.c                              |   1 +
 net/nfc/llcp_core.c                                |   1 +
 net/sched/sch_taprio.c                             |   2 +
 net/sctp/bind_addr.c                               |   6 ++
 net/sunrpc/xprtrdma/verbs.c                        |   1 -
 scripts/tracing/ftrace-bisect.sh                   |  34 ++++--
 security/tomoyo/Makefile                           |   2 +-
 sound/soc/fsl/fsl-asoc-card.c                      |   8 +-
 sound/soc/fsl/fsl_micfil.c                         |  16 +--
 sound/soc/fsl/fsl_ssi.c                            |   4 +-
 tools/objtool/check.c                              |   3 +-
 .../selftests/bpf/prog_tests/jeq_infer_not_null.c  |   9 --
 .../selftests/bpf/progs/jeq_infer_not_null_fail.c  |  42 --------
 176 files changed, 1178 insertions(+), 528 deletions(-)

[PATCH 5.4 109/134] x86/asm: Fix an assembler warning with current binutils

[Greg Kroah-Hartman]

From: Mikulas Patocka <mpatocka@redhat.com>

commit 55d235361fccef573990dfa5724ab453866e7816 upstream.

Fix a warning: "found `movsd'; assuming `movsl' was meant"

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 arch/x86/lib/iomap_copy_64.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/lib/iomap_copy_64.S
+++ b/arch/x86/lib/iomap_copy_64.S
@@ -10,6 +10,6 @@
  */
 ENTRY(__iowrite32_copy)
 	movl %edx,%ecx
-	rep movsd
+	rep movsl
 	ret
 ENDPROC(__iowrite32_copy)

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Guenter Roeck]

On Fri, Feb 03, 2023 at 11:11:45AM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.231 release.
> There are 134 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> Anything received after that time might be too late.
> 

Building ia64:defconfig ... failed
--------------
Error log:
<stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
arch/ia64/kernel/mca_drv.c: In function 'mca_handler_bh':
arch/ia64/kernel/mca_drv.c:179:9: error: implicit declaration of function 'make_task_dead'

Caused by "exit: Add and use make_task_dead.". Did that really have to be backported ?

Guenter

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Greg Kroah-Hartman]

On Fri, Feb 03, 2023 at 07:56:19AM -0800, Guenter Roeck wrote:
> On Fri, Feb 03, 2023 at 11:11:45AM +0100, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.4.231 release.
> > There are 134 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> > Anything received after that time might be too late.
> > 
> 
> Building ia64:defconfig ... failed
> --------------
> Error log:
> <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> arch/ia64/kernel/mca_drv.c: In function 'mca_handler_bh':
> arch/ia64/kernel/mca_drv.c:179:9: error: implicit declaration of function 'make_task_dead'
> 
> Caused by "exit: Add and use make_task_dead.". Did that really have to be backported ?

Yup, it does!

Eric, any help with this?

thanks,

greg k-h

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Guenter Roeck]

On Fri, Feb 03, 2023 at 05:45:19PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Feb 03, 2023 at 07:56:19AM -0800, Guenter Roeck wrote:
> > On Fri, Feb 03, 2023 at 11:11:45AM +0100, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.4.231 release.
> > > There are 134 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > 
> > > Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> > > Anything received after that time might be too late.
> > > 
> > 
> > Building ia64:defconfig ... failed
> > --------------
> > Error log:
> > <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > arch/ia64/kernel/mca_drv.c: In function 'mca_handler_bh':
> > arch/ia64/kernel/mca_drv.c:179:9: error: implicit declaration of function 'make_task_dead'
> > 
> > Caused by "exit: Add and use make_task_dead.". Did that really have to be backported ?
> 
> Yup, it does!
> 
> Eric, any help with this?
> 

Adding "#include <linux/sched/task.h>" to the affected file would probably
be the easy fix. I did a quick check, and it works.

Note that the same problem is seen in v4.14.y and v4.19.y. Later
kernels don't have the problem.

Guenter

> thanks,
> 
> greg k-h

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Florian Fainelli]

On 2/3/23 02:11, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.231 release.
> There are 134 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.231-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h

On ARCH_BRCMSTB using 32-bit and 64-bit, build tested on BMIPS_GENERIC:

Tested-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Eric Biggers]

On Fri, Feb 03, 2023 at 09:18:26AM -0800, Guenter Roeck wrote:
> On Fri, Feb 03, 2023 at 05:45:19PM +0100, Greg Kroah-Hartman wrote:
> > On Fri, Feb 03, 2023 at 07:56:19AM -0800, Guenter Roeck wrote:
> > > On Fri, Feb 03, 2023 at 11:11:45AM +0100, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 5.4.231 release.
> > > > There are 134 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> > > > Anything received after that time might be too late.
> > > > 
> > > 
> > > Building ia64:defconfig ... failed
> > > --------------
> > > Error log:
> > > <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > > arch/ia64/kernel/mca_drv.c: In function 'mca_handler_bh':
> > > arch/ia64/kernel/mca_drv.c:179:9: error: implicit declaration of function 'make_task_dead'
> > > 
> > > Caused by "exit: Add and use make_task_dead.". Did that really have to be backported ?
> > 
> > Yup, it does!
> > 
> > Eric, any help with this?
> > 
> 
> Adding "#include <linux/sched/task.h>" to the affected file would probably
> be the easy fix. I did a quick check, and it works.
> 
> Note that the same problem is seen in v4.14.y and v4.19.y. Later
> kernels don't have the problem.
> 

This problem arises because <linux/mm.h> transitively includes
<linux/sched/task.h> in 5.10 and later, but not in 5.4 and earlier.

Greg, any preference for how to handle this situation?

Just add '#include <linux/sched/task.h>' to the affected .c file (and hope there
are no more affected .c files in the other arch directories) and call it a day?

Or should we backport the transitive inclusion (i.e., the #include added by
commit 80fbaf1c3f29)?  Or move the declaration of make_task_dead() into
<linux/kernel.h> so that it's next to do_exit()?

- Eric

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Eric Biggers]

On Fri, Feb 03, 2023 at 10:54:21AM -0800, Eric Biggers wrote:
> On Fri, Feb 03, 2023 at 09:18:26AM -0800, Guenter Roeck wrote:
> > On Fri, Feb 03, 2023 at 05:45:19PM +0100, Greg Kroah-Hartman wrote:
> > > On Fri, Feb 03, 2023 at 07:56:19AM -0800, Guenter Roeck wrote:
> > > > On Fri, Feb 03, 2023 at 11:11:45AM +0100, Greg Kroah-Hartman wrote:
> > > > > This is the start of the stable review cycle for the 5.4.231 release.
> > > > > There are 134 patches in this series, all will be posted as a response
> > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > > 
> > > > > Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> > > > > Anything received after that time might be too late.
> > > > > 
> > > > 
> > > > Building ia64:defconfig ... failed
> > > > --------------
> > > > Error log:
> > > > <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > > > arch/ia64/kernel/mca_drv.c: In function 'mca_handler_bh':
> > > > arch/ia64/kernel/mca_drv.c:179:9: error: implicit declaration of function 'make_task_dead'
> > > > 
> > > > Caused by "exit: Add and use make_task_dead.". Did that really have to be backported ?
> > > 
> > > Yup, it does!
> > > 
> > > Eric, any help with this?
> > > 
> > 
> > Adding "#include <linux/sched/task.h>" to the affected file would probably
> > be the easy fix. I did a quick check, and it works.
> > 
> > Note that the same problem is seen in v4.14.y and v4.19.y. Later
> > kernels don't have the problem.
> > 
> 
> This problem arises because <linux/mm.h> transitively includes
> <linux/sched/task.h> in 5.10 and later, but not in 5.4 and earlier.
> 
> Greg, any preference for how to handle this situation?
> 
> Just add '#include <linux/sched/task.h>' to the affected .c file (and hope there
> are no more affected .c files in the other arch directories) and call it a day?
> 
> Or should we backport the transitive inclusion (i.e., the #include added by
> commit 80fbaf1c3f29)?  Or move the declaration of make_task_dead() into
> <linux/kernel.h> so that it's next to do_exit()?

One question: do *all* the arches actually get built as part of the testing for
each stable release?  If so, we can just add the #include to the .c files that
need it.  If not, then it would be safer to take one of the other approaches.

- Eric

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Guenter Roeck]

On 2/3/23 11:07, Eric Biggers wrote:
> On Fri, Feb 03, 2023 at 10:54:21AM -0800, Eric Biggers wrote:
>> On Fri, Feb 03, 2023 at 09:18:26AM -0800, Guenter Roeck wrote:
>>> On Fri, Feb 03, 2023 at 05:45:19PM +0100, Greg Kroah-Hartman wrote:
>>>> On Fri, Feb 03, 2023 at 07:56:19AM -0800, Guenter Roeck wrote:
>>>>> On Fri, Feb 03, 2023 at 11:11:45AM +0100, Greg Kroah-Hartman wrote:
>>>>>> This is the start of the stable review cycle for the 5.4.231 release.
>>>>>> There are 134 patches in this series, all will be posted as a response
>>>>>> to this one.  If anyone has any issues with these being applied, please
>>>>>> let me know.
>>>>>>
>>>>>> Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
>>>>>> Anything received after that time might be too late.
>>>>>>
>>>>>
>>>>> Building ia64:defconfig ... failed
>>>>> --------------
>>>>> Error log:
>>>>> <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
>>>>> arch/ia64/kernel/mca_drv.c: In function 'mca_handler_bh':
>>>>> arch/ia64/kernel/mca_drv.c:179:9: error: implicit declaration of function 'make_task_dead'
>>>>>
>>>>> Caused by "exit: Add and use make_task_dead.". Did that really have to be backported ?
>>>>
>>>> Yup, it does!
>>>>
>>>> Eric, any help with this?
>>>>
>>>
>>> Adding "#include <linux/sched/task.h>" to the affected file would probably
>>> be the easy fix. I did a quick check, and it works.
>>>
>>> Note that the same problem is seen in v4.14.y and v4.19.y. Later
>>> kernels don't have the problem.
>>>
>>
>> This problem arises because <linux/mm.h> transitively includes
>> <linux/sched/task.h> in 5.10 and later, but not in 5.4 and earlier.
>>
>> Greg, any preference for how to handle this situation?
>>
>> Just add '#include <linux/sched/task.h>' to the affected .c file (and hope there
>> are no more affected .c files in the other arch directories) and call it a day?
>>
>> Or should we backport the transitive inclusion (i.e., the #include added by
>> commit 80fbaf1c3f29)?  Or move the declaration of make_task_dead() into
>> <linux/kernel.h> so that it's next to do_exit()?
> 
> One question: do *all* the arches actually get built as part of the testing for
> each stable release?  If so, we can just add the #include to the .c files that
> need it.  If not, then it would be safer to take one of the other approaches.
> 

Yes, I do build all architectures for each stable release.

FWIW, I only noticed that one build failure due to this problem.

Guenter

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Eric Biggers]

On Fri, Feb 03, 2023 at 11:28:46AM -0800, Guenter Roeck wrote:
> On 2/3/23 11:07, Eric Biggers wrote:
> > On Fri, Feb 03, 2023 at 10:54:21AM -0800, Eric Biggers wrote:
> > > On Fri, Feb 03, 2023 at 09:18:26AM -0800, Guenter Roeck wrote:
> > > > On Fri, Feb 03, 2023 at 05:45:19PM +0100, Greg Kroah-Hartman wrote:
> > > > > On Fri, Feb 03, 2023 at 07:56:19AM -0800, Guenter Roeck wrote:
> > > > > > On Fri, Feb 03, 2023 at 11:11:45AM +0100, Greg Kroah-Hartman wrote:
> > > > > > > This is the start of the stable review cycle for the 5.4.231 release.
> > > > > > > There are 134 patches in this series, all will be posted as a response
> > > > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > > > let me know.
> > > > > > > 
> > > > > > > Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> > > > > > > Anything received after that time might be too late.
> > > > > > > 
> > > > > > 
> > > > > > Building ia64:defconfig ... failed
> > > > > > --------------
> > > > > > Error log:
> > > > > > <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > > > > > arch/ia64/kernel/mca_drv.c: In function 'mca_handler_bh':
> > > > > > arch/ia64/kernel/mca_drv.c:179:9: error: implicit declaration of function 'make_task_dead'
> > > > > > 
> > > > > > Caused by "exit: Add and use make_task_dead.". Did that really have to be backported ?
> > > > > 
> > > > > Yup, it does!
> > > > > 
> > > > > Eric, any help with this?
> > > > > 
> > > > 
> > > > Adding "#include <linux/sched/task.h>" to the affected file would probably
> > > > be the easy fix. I did a quick check, and it works.
> > > > 
> > > > Note that the same problem is seen in v4.14.y and v4.19.y. Later
> > > > kernels don't have the problem.
> > > > 
> > > 
> > > This problem arises because <linux/mm.h> transitively includes
> > > <linux/sched/task.h> in 5.10 and later, but not in 5.4 and earlier.
> > > 
> > > Greg, any preference for how to handle this situation?
> > > 
> > > Just add '#include <linux/sched/task.h>' to the affected .c file (and hope there
> > > are no more affected .c files in the other arch directories) and call it a day?
> > > 
> > > Or should we backport the transitive inclusion (i.e., the #include added by
> > > commit 80fbaf1c3f29)?  Or move the declaration of make_task_dead() into
> > > <linux/kernel.h> so that it's next to do_exit()?
> > 
> > One question: do *all* the arches actually get built as part of the testing for
> > each stable release?  If so, we can just add the #include to the .c files that
> > need it.  If not, then it would be safer to take one of the other approaches.
> > 
> 
> Yes, I do build all architectures for each stable release.
> 
> FWIW, I only noticed that one build failure due to this problem.

Okay, great.  In that case, Greg or Sasha, can you fold the needed #include into
arch/ia64/kernel/mca_drv.c in exit-add-and-use-make_task_dead.patch on 4.14,
4.19, and 5.4?  Or should I just send the whole series again for each?

- Eric

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Shuah Khan]

On 2/3/23 03:11, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.231 release.
> There are 134 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.231-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 

Compiled and booted on my test system. No dmesg regressions.

Tested-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Guenter Roeck]

On Fri, Feb 03, 2023 at 11:11:45AM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.231 release.
> There are 134 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> Anything received after that time might be too late.
> 

Build results:
	total: 159 pass: 158 fail: 1
Failed builds:
	ia64:defconfig
Qemu test results:
	total: 450 pass: 450 fail: 0

ia64 build error as already reported.

Guenter

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Greg Kroah-Hartman]

On Fri, Feb 03, 2023 at 11:49:49AM -0800, Eric Biggers wrote:
> On Fri, Feb 03, 2023 at 11:28:46AM -0800, Guenter Roeck wrote:
> > On 2/3/23 11:07, Eric Biggers wrote:
> > > On Fri, Feb 03, 2023 at 10:54:21AM -0800, Eric Biggers wrote:
> > > > On Fri, Feb 03, 2023 at 09:18:26AM -0800, Guenter Roeck wrote:
> > > > > On Fri, Feb 03, 2023 at 05:45:19PM +0100, Greg Kroah-Hartman wrote:
> > > > > > On Fri, Feb 03, 2023 at 07:56:19AM -0800, Guenter Roeck wrote:
> > > > > > > On Fri, Feb 03, 2023 at 11:11:45AM +0100, Greg Kroah-Hartman wrote:
> > > > > > > > This is the start of the stable review cycle for the 5.4.231 release.
> > > > > > > > There are 134 patches in this series, all will be posted as a response
> > > > > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > > > > let me know.
> > > > > > > > 
> > > > > > > > Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> > > > > > > > Anything received after that time might be too late.
> > > > > > > > 
> > > > > > > 
> > > > > > > Building ia64:defconfig ... failed
> > > > > > > --------------
> > > > > > > Error log:
> > > > > > > <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > > > > > > arch/ia64/kernel/mca_drv.c: In function 'mca_handler_bh':
> > > > > > > arch/ia64/kernel/mca_drv.c:179:9: error: implicit declaration of function 'make_task_dead'
> > > > > > > 
> > > > > > > Caused by "exit: Add and use make_task_dead.". Did that really have to be backported ?
> > > > > > 
> > > > > > Yup, it does!
> > > > > > 
> > > > > > Eric, any help with this?
> > > > > > 
> > > > > 
> > > > > Adding "#include <linux/sched/task.h>" to the affected file would probably
> > > > > be the easy fix. I did a quick check, and it works.
> > > > > 
> > > > > Note that the same problem is seen in v4.14.y and v4.19.y. Later
> > > > > kernels don't have the problem.
> > > > > 
> > > > 
> > > > This problem arises because <linux/mm.h> transitively includes
> > > > <linux/sched/task.h> in 5.10 and later, but not in 5.4 and earlier.
> > > > 
> > > > Greg, any preference for how to handle this situation?
> > > > 
> > > > Just add '#include <linux/sched/task.h>' to the affected .c file (and hope there
> > > > are no more affected .c files in the other arch directories) and call it a day?
> > > > 
> > > > Or should we backport the transitive inclusion (i.e., the #include added by
> > > > commit 80fbaf1c3f29)?  Or move the declaration of make_task_dead() into
> > > > <linux/kernel.h> so that it's next to do_exit()?
> > > 
> > > One question: do *all* the arches actually get built as part of the testing for
> > > each stable release?  If so, we can just add the #include to the .c files that
> > > need it.  If not, then it would be safer to take one of the other approaches.
> > > 
> > 
> > Yes, I do build all architectures for each stable release.
> > 
> > FWIW, I only noticed that one build failure due to this problem.
> 
> Okay, great.  In that case, Greg or Sasha, can you fold the needed #include into
> arch/ia64/kernel/mca_drv.c in exit-add-and-use-make_task_dead.patch on 4.14,
> 4.19, and 5.4?  Or should I just send the whole series again for each?

I'll fold it in later today when I get a chance, no need to resubmit the
whole thing, thanks!

greg k-h

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Naresh Kamboju]

On Fri, 3 Feb 2023 at 15:55, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.4.231 release.
> There are 134 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.231-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>

## Build
* kernel: 5.4.231-rc1
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-5.4.y
* git commit: f094cca7f934dd6b1c62254251d145087d40c30b
* git describe: v5.4.230-135-gf094cca7f934
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.230-135-gf094cca7f934

## Test Regressions (compared to v5.4.230)

## Metric Regressions (compared to v5.4.230)

## Test Fixes (compared to v5.4.230)

## Metric Fixes (compared to v5.4.230)

## Test result summary
total: 130133, pass: 103865, fail: 3011, skip: 22894, xfail: 363

## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 144 total, 143 passed, 1 failed
* arm64: 44 total, 40 passed, 4 failed
* i386: 26 total, 20 passed, 6 failed
* mips: 27 total, 27 passed, 0 failed
* parisc: 6 total, 6 passed, 0 failed
* powerpc: 30 total, 30 passed, 0 failed
* riscv: 12 total, 11 passed, 1 failed
* s390: 6 total, 6 passed, 0 failed
* sh: 12 total, 12 passed, 0 failed
* sparc: 6 total, 6 passed, 0 failed
* x86_64: 37 total, 35 passed, 2 failed

## Test suites summary
* boot
* fwts
* kselftest-android
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-drivers-dma-buf
* kselftest-efivarfs
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-firmware
* kselftest-fpu
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kexec
* kselftest-kvm
* kselftest-lib
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-net-forwarding
* kselftest-net-mptcp
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-tc-testing
* kselftest-timens
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-vm
* kselftest-x86
* kselftest-zram
* kunit
* kvm-unit-tests
* libgpiod
* libhugetlbfs
* log-parser-boot
* log-parser-test
* ltp-cap_bounds
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-fsx
* ltp-hugetlb
* ltp-io
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-open-posix-tests
* ltp-pty
* ltp-sched
* ltp-securebits
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* network-basic-tests
* packetdrill
* perf
* rcutorture
* v4l2-compliance
* vdso

--
Linaro LKFT
https://lkft.linaro.org

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Sasha Levin]

On Sat, Feb 04, 2023 at 08:59:09AM +0100, Greg Kroah-Hartman wrote:
>On Fri, Feb 03, 2023 at 11:49:49AM -0800, Eric Biggers wrote:
>> On Fri, Feb 03, 2023 at 11:28:46AM -0800, Guenter Roeck wrote:
>> > On 2/3/23 11:07, Eric Biggers wrote:
>> > > On Fri, Feb 03, 2023 at 10:54:21AM -0800, Eric Biggers wrote:
>> > > > On Fri, Feb 03, 2023 at 09:18:26AM -0800, Guenter Roeck wrote:
>> > > > > On Fri, Feb 03, 2023 at 05:45:19PM +0100, Greg Kroah-Hartman wrote:
>> > > > > > On Fri, Feb 03, 2023 at 07:56:19AM -0800, Guenter Roeck wrote:
>> > > > > > > On Fri, Feb 03, 2023 at 11:11:45AM +0100, Greg Kroah-Hartman wrote:
>> > > > > > > > This is the start of the stable review cycle for the 5.4.231 release.
>> > > > > > > > There are 134 patches in this series, all will be posted as a response
>> > > > > > > > to this one.  If anyone has any issues with these being applied, please
>> > > > > > > > let me know.
>> > > > > > > >
>> > > > > > > > Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
>> > > > > > > > Anything received after that time might be too late.
>> > > > > > > >
>> > > > > > >
>> > > > > > > Building ia64:defconfig ... failed
>> > > > > > > --------------
>> > > > > > > Error log:
>> > > > > > > <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
>> > > > > > > arch/ia64/kernel/mca_drv.c: In function 'mca_handler_bh':
>> > > > > > > arch/ia64/kernel/mca_drv.c:179:9: error: implicit declaration of function 'make_task_dead'
>> > > > > > >
>> > > > > > > Caused by "exit: Add and use make_task_dead.". Did that really have to be backported ?
>> > > > > >
>> > > > > > Yup, it does!
>> > > > > >
>> > > > > > Eric, any help with this?
>> > > > > >
>> > > > >
>> > > > > Adding "#include <linux/sched/task.h>" to the affected file would probably
>> > > > > be the easy fix. I did a quick check, and it works.
>> > > > >
>> > > > > Note that the same problem is seen in v4.14.y and v4.19.y. Later
>> > > > > kernels don't have the problem.
>> > > > >
>> > > >
>> > > > This problem arises because <linux/mm.h> transitively includes
>> > > > <linux/sched/task.h> in 5.10 and later, but not in 5.4 and earlier.
>> > > >
>> > > > Greg, any preference for how to handle this situation?
>> > > >
>> > > > Just add '#include <linux/sched/task.h>' to the affected .c file (and hope there
>> > > > are no more affected .c files in the other arch directories) and call it a day?
>> > > >
>> > > > Or should we backport the transitive inclusion (i.e., the #include added by
>> > > > commit 80fbaf1c3f29)?  Or move the declaration of make_task_dead() into
>> > > > <linux/kernel.h> so that it's next to do_exit()?
>> > >
>> > > One question: do *all* the arches actually get built as part of the testing for
>> > > each stable release?  If so, we can just add the #include to the .c files that
>> > > need it.  If not, then it would be safer to take one of the other approaches.
>> > >
>> >
>> > Yes, I do build all architectures for each stable release.
>> >
>> > FWIW, I only noticed that one build failure due to this problem.
>>
>> Okay, great.  In that case, Greg or Sasha, can you fold the needed #include into
>> arch/ia64/kernel/mca_drv.c in exit-add-and-use-make_task_dead.patch on 4.14,
>> 4.19, and 5.4?  Or should I just send the whole series again for each?
>
>I'll fold it in later today when I get a chance, no need to resubmit the
>whole thing, thanks!

Greg, I did it for the 5.4 backport. If I do it for 4.19 and 4.14 it's
going to add a bunch of fuzz into those, lmk if you want me to push
those too or whether you'll fix it up.

-- 
Thanks,
Sasha

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Greg Kroah-Hartman]

On Sat, Feb 04, 2023 at 08:48:56AM -0500, Sasha Levin wrote:
> On Sat, Feb 04, 2023 at 08:59:09AM +0100, Greg Kroah-Hartman wrote:
> > On Fri, Feb 03, 2023 at 11:49:49AM -0800, Eric Biggers wrote:
> > > On Fri, Feb 03, 2023 at 11:28:46AM -0800, Guenter Roeck wrote:
> > > > On 2/3/23 11:07, Eric Biggers wrote:
> > > > > On Fri, Feb 03, 2023 at 10:54:21AM -0800, Eric Biggers wrote:
> > > > > > On Fri, Feb 03, 2023 at 09:18:26AM -0800, Guenter Roeck wrote:
> > > > > > > On Fri, Feb 03, 2023 at 05:45:19PM +0100, Greg Kroah-Hartman wrote:
> > > > > > > > On Fri, Feb 03, 2023 at 07:56:19AM -0800, Guenter Roeck wrote:
> > > > > > > > > On Fri, Feb 03, 2023 at 11:11:45AM +0100, Greg Kroah-Hartman wrote:
> > > > > > > > > > This is the start of the stable review cycle for the 5.4.231 release.
> > > > > > > > > > There are 134 patches in this series, all will be posted as a response
> > > > > > > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > > > > > > let me know.
> > > > > > > > > >
> > > > > > > > > > Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> > > > > > > > > > Anything received after that time might be too late.
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > > Building ia64:defconfig ... failed
> > > > > > > > > --------------
> > > > > > > > > Error log:
> > > > > > > > > <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > > > > > > > > arch/ia64/kernel/mca_drv.c: In function 'mca_handler_bh':
> > > > > > > > > arch/ia64/kernel/mca_drv.c:179:9: error: implicit declaration of function 'make_task_dead'
> > > > > > > > >
> > > > > > > > > Caused by "exit: Add and use make_task_dead.". Did that really have to be backported ?
> > > > > > > >
> > > > > > > > Yup, it does!
> > > > > > > >
> > > > > > > > Eric, any help with this?
> > > > > > > >
> > > > > > >
> > > > > > > Adding "#include <linux/sched/task.h>" to the affected file would probably
> > > > > > > be the easy fix. I did a quick check, and it works.
> > > > > > >
> > > > > > > Note that the same problem is seen in v4.14.y and v4.19.y. Later
> > > > > > > kernels don't have the problem.
> > > > > > >
> > > > > >
> > > > > > This problem arises because <linux/mm.h> transitively includes
> > > > > > <linux/sched/task.h> in 5.10 and later, but not in 5.4 and earlier.
> > > > > >
> > > > > > Greg, any preference for how to handle this situation?
> > > > > >
> > > > > > Just add '#include <linux/sched/task.h>' to the affected .c file (and hope there
> > > > > > are no more affected .c files in the other arch directories) and call it a day?
> > > > > >
> > > > > > Or should we backport the transitive inclusion (i.e., the #include added by
> > > > > > commit 80fbaf1c3f29)?  Or move the declaration of make_task_dead() into
> > > > > > <linux/kernel.h> so that it's next to do_exit()?
> > > > >
> > > > > One question: do *all* the arches actually get built as part of the testing for
> > > > > each stable release?  If so, we can just add the #include to the .c files that
> > > > > need it.  If not, then it would be safer to take one of the other approaches.
> > > > >
> > > >
> > > > Yes, I do build all architectures for each stable release.
> > > >
> > > > FWIW, I only noticed that one build failure due to this problem.
> > > 
> > > Okay, great.  In that case, Greg or Sasha, can you fold the needed #include into
> > > arch/ia64/kernel/mca_drv.c in exit-add-and-use-make_task_dead.patch on 4.14,
> > > 4.19, and 5.4?  Or should I just send the whole series again for each?
> > 
> > I'll fold it in later today when I get a chance, no need to resubmit the
> > whole thing, thanks!
> 
> Greg, I did it for the 5.4 backport. If I do it for 4.19 and 4.14 it's
> going to add a bunch of fuzz into those, lmk if you want me to push
> those too or whether you'll fix it up.

I just fixed up those 2 trees, and I don't understand what you mean by
"a bunch of fuzz".  Can you look at my changes to verify I got it right?

thanks,

greg k-h

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Sasha Levin]

On Sat, Feb 04, 2023 at 02:59:46PM +0100, Greg Kroah-Hartman wrote:
>On Sat, Feb 04, 2023 at 08:48:56AM -0500, Sasha Levin wrote:
>> On Sat, Feb 04, 2023 at 08:59:09AM +0100, Greg Kroah-Hartman wrote:
>> > On Fri, Feb 03, 2023 at 11:49:49AM -0800, Eric Biggers wrote:
>> > > On Fri, Feb 03, 2023 at 11:28:46AM -0800, Guenter Roeck wrote:
>> > > > On 2/3/23 11:07, Eric Biggers wrote:
>> > > > > On Fri, Feb 03, 2023 at 10:54:21AM -0800, Eric Biggers wrote:
>> > > > > > On Fri, Feb 03, 2023 at 09:18:26AM -0800, Guenter Roeck wrote:
>> > > > > > > On Fri, Feb 03, 2023 at 05:45:19PM +0100, Greg Kroah-Hartman wrote:
>> > > > > > > > On Fri, Feb 03, 2023 at 07:56:19AM -0800, Guenter Roeck wrote:
>> > > > > > > > > On Fri, Feb 03, 2023 at 11:11:45AM +0100, Greg Kroah-Hartman wrote:
>> > > > > > > > > > This is the start of the stable review cycle for the 5.4.231 release.
>> > > > > > > > > > There are 134 patches in this series, all will be posted as a response
>> > > > > > > > > > to this one.  If anyone has any issues with these being applied, please
>> > > > > > > > > > let me know.
>> > > > > > > > > >
>> > > > > > > > > > Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
>> > > > > > > > > > Anything received after that time might be too late.
>> > > > > > > > > >
>> > > > > > > > >
>> > > > > > > > > Building ia64:defconfig ... failed
>> > > > > > > > > --------------
>> > > > > > > > > Error log:
>> > > > > > > > > <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
>> > > > > > > > > arch/ia64/kernel/mca_drv.c: In function 'mca_handler_bh':
>> > > > > > > > > arch/ia64/kernel/mca_drv.c:179:9: error: implicit declaration of function 'make_task_dead'
>> > > > > > > > >
>> > > > > > > > > Caused by "exit: Add and use make_task_dead.". Did that really have to be backported ?
>> > > > > > > >
>> > > > > > > > Yup, it does!
>> > > > > > > >
>> > > > > > > > Eric, any help with this?
>> > > > > > > >
>> > > > > > >
>> > > > > > > Adding "#include <linux/sched/task.h>" to the affected file would probably
>> > > > > > > be the easy fix. I did a quick check, and it works.
>> > > > > > >
>> > > > > > > Note that the same problem is seen in v4.14.y and v4.19.y. Later
>> > > > > > > kernels don't have the problem.
>> > > > > > >
>> > > > > >
>> > > > > > This problem arises because <linux/mm.h> transitively includes
>> > > > > > <linux/sched/task.h> in 5.10 and later, but not in 5.4 and earlier.
>> > > > > >
>> > > > > > Greg, any preference for how to handle this situation?
>> > > > > >
>> > > > > > Just add '#include <linux/sched/task.h>' to the affected .c file (and hope there
>> > > > > > are no more affected .c files in the other arch directories) and call it a day?
>> > > > > >
>> > > > > > Or should we backport the transitive inclusion (i.e., the #include added by
>> > > > > > commit 80fbaf1c3f29)?  Or move the declaration of make_task_dead() into
>> > > > > > <linux/kernel.h> so that it's next to do_exit()?
>> > > > >
>> > > > > One question: do *all* the arches actually get built as part of the testing for
>> > > > > each stable release?  If so, we can just add the #include to the .c files that
>> > > > > need it.  If not, then it would be safer to take one of the other approaches.
>> > > > >
>> > > >
>> > > > Yes, I do build all architectures for each stable release.
>> > > >
>> > > > FWIW, I only noticed that one build failure due to this problem.
>> > >
>> > > Okay, great.  In that case, Greg or Sasha, can you fold the needed #include into
>> > > arch/ia64/kernel/mca_drv.c in exit-add-and-use-make_task_dead.patch on 4.14,
>> > > 4.19, and 5.4?  Or should I just send the whole series again for each?
>> >
>> > I'll fold it in later today when I get a chance, no need to resubmit the
>> > whole thing, thanks!
>>
>> Greg, I did it for the 5.4 backport. If I do it for 4.19 and 4.14 it's
>> going to add a bunch of fuzz into those, lmk if you want me to push
>> those too or whether you'll fix it up.
>
>I just fixed up those 2 trees, and I don't understand what you mean by
>"a bunch of fuzz".  Can you look at my changes to verify I got it right?

Your changes look right.

We're likely using different tools to format a patch - you can see
differences in things like indentation of the diffstat, which headers
are kept in the patch, and so on...

If I were to regenerate patches you have previously queued up, we'd see
a somewhat big diff because of that.

-- 
Thanks,
Sasha

Re: [PATCH 5.4 000/134] 5.4.231-rc1 review

[Greg Kroah-Hartman]

On Sat, Feb 04, 2023 at 11:08:36AM -0500, Sasha Levin wrote:
> On Sat, Feb 04, 2023 at 02:59:46PM +0100, Greg Kroah-Hartman wrote:
> > On Sat, Feb 04, 2023 at 08:48:56AM -0500, Sasha Levin wrote:
> > > On Sat, Feb 04, 2023 at 08:59:09AM +0100, Greg Kroah-Hartman wrote:
> > > > On Fri, Feb 03, 2023 at 11:49:49AM -0800, Eric Biggers wrote:
> > > > > On Fri, Feb 03, 2023 at 11:28:46AM -0800, Guenter Roeck wrote:
> > > > > > On 2/3/23 11:07, Eric Biggers wrote:
> > > > > > > On Fri, Feb 03, 2023 at 10:54:21AM -0800, Eric Biggers wrote:
> > > > > > > > On Fri, Feb 03, 2023 at 09:18:26AM -0800, Guenter Roeck wrote:
> > > > > > > > > On Fri, Feb 03, 2023 at 05:45:19PM +0100, Greg Kroah-Hartman wrote:
> > > > > > > > > > On Fri, Feb 03, 2023 at 07:56:19AM -0800, Guenter Roeck wrote:
> > > > > > > > > > > On Fri, Feb 03, 2023 at 11:11:45AM +0100, Greg Kroah-Hartman wrote:
> > > > > > > > > > > > This is the start of the stable review cycle for the 5.4.231 release.
> > > > > > > > > > > > There are 134 patches in this series, all will be posted as a response
> > > > > > > > > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > > > > > > > > let me know.
> > > > > > > > > > > >
> > > > > > > > > > > > Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> > > > > > > > > > > > Anything received after that time might be too late.
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > Building ia64:defconfig ... failed
> > > > > > > > > > > --------------
> > > > > > > > > > > Error log:
> > > > > > > > > > > <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > > > > > > > > > > arch/ia64/kernel/mca_drv.c: In function 'mca_handler_bh':
> > > > > > > > > > > arch/ia64/kernel/mca_drv.c:179:9: error: implicit declaration of function 'make_task_dead'
> > > > > > > > > > >
> > > > > > > > > > > Caused by "exit: Add and use make_task_dead.". Did that really have to be backported ?
> > > > > > > > > >
> > > > > > > > > > Yup, it does!
> > > > > > > > > >
> > > > > > > > > > Eric, any help with this?
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > > Adding "#include <linux/sched/task.h>" to the affected file would probably
> > > > > > > > > be the easy fix. I did a quick check, and it works.
> > > > > > > > >
> > > > > > > > > Note that the same problem is seen in v4.14.y and v4.19.y. Later
> > > > > > > > > kernels don't have the problem.
> > > > > > > > >
> > > > > > > >
> > > > > > > > This problem arises because <linux/mm.h> transitively includes
> > > > > > > > <linux/sched/task.h> in 5.10 and later, but not in 5.4 and earlier.
> > > > > > > >
> > > > > > > > Greg, any preference for how to handle this situation?
> > > > > > > >
> > > > > > > > Just add '#include <linux/sched/task.h>' to the affected .c file (and hope there
> > > > > > > > are no more affected .c files in the other arch directories) and call it a day?
> > > > > > > >
> > > > > > > > Or should we backport the transitive inclusion (i.e., the #include added by
> > > > > > > > commit 80fbaf1c3f29)?  Or move the declaration of make_task_dead() into
> > > > > > > > <linux/kernel.h> so that it's next to do_exit()?
> > > > > > >
> > > > > > > One question: do *all* the arches actually get built as part of the testing for
> > > > > > > each stable release?  If so, we can just add the #include to the .c files that
> > > > > > > need it.  If not, then it would be safer to take one of the other approaches.
> > > > > > >
> > > > > >
> > > > > > Yes, I do build all architectures for each stable release.
> > > > > >
> > > > > > FWIW, I only noticed that one build failure due to this problem.
> > > > >
> > > > > Okay, great.  In that case, Greg or Sasha, can you fold the needed #include into
> > > > > arch/ia64/kernel/mca_drv.c in exit-add-and-use-make_task_dead.patch on 4.14,
> > > > > 4.19, and 5.4?  Or should I just send the whole series again for each?
> > > >
> > > > I'll fold it in later today when I get a chance, no need to resubmit the
> > > > whole thing, thanks!
> > > 
> > > Greg, I did it for the 5.4 backport. If I do it for 4.19 and 4.14 it's
> > > going to add a bunch of fuzz into those, lmk if you want me to push
> > > those too or whether you'll fix it up.
> > 
> > I just fixed up those 2 trees, and I don't understand what you mean by
> > "a bunch of fuzz".  Can you look at my changes to verify I got it right?
> 
> Your changes look right.
> 
> We're likely using different tools to format a patch - you can see
> differences in things like indentation of the diffstat, which headers
> are kept in the patch, and so on...

Yeah, I'm using quilt, you're using git, different whitespace in places.

thanks for verifying the change was correct.

greg k-h