* [PATCH v2] ARM: mm: Facilitate debugging CONFIG_KUSER_HELPERS disabled
@ 2018-10-25 19:01 Florian Fainelli
2018-10-25 19:26 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2018-10-25 19:01 UTC (permalink / raw)
To: linux-arm-kernel
Cc: andrew, ebiederm, Florian Fainelli, Russell King, Andrew Morton,
Souptick Joarder, Tony Lindgren, open list
Some software such as perf makes unconditional use of the special
[vectors] page which is only provided when CONFIG_KUSER_HELPERS is
enabled in the kernel.
Facilitate the debugging of such situations by printing a debug message
to the kernel log showing the task name and the faulting address.
Suggested-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/mm/fault.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c
index f4ea4c62c613..58f69fa07df9 100644
--- a/arch/arm/mm/fault.c
+++ b/arch/arm/mm/fault.c
@@ -173,6 +173,12 @@ __do_user_fault(struct task_struct *tsk, unsigned long addr,
show_regs(regs);
}
#endif
+#ifndef CONFIG_KUSER_HELPERS
+ if ((sig == SIGSEGV) && ((addr & PAGE_MASK) == 0xffff0000))
+ printk_ratelimited(KERN_DEBUG
+ "%s: CONFIG_KUSER_HELPERS disabled at 0x%08lx\n",
+ tsk->comm, addr);
+#endif
tsk->thread.address = addr;
tsk->thread.error_code = fsr;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ARM: mm: Facilitate debugging CONFIG_KUSER_HELPERS disabled
2018-10-25 19:01 [PATCH v2] ARM: mm: Facilitate debugging CONFIG_KUSER_HELPERS disabled Florian Fainelli
@ 2018-10-25 19:26 ` Andrew Lunn
2018-10-31 22:54 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2018-10-25 19:26 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-arm-kernel, ebiederm, Russell King, Andrew Morton,
Souptick Joarder, Tony Lindgren, open list
On Thu, Oct 25, 2018 at 12:01:08PM -0700, Florian Fainelli wrote:
> Some software such as perf makes unconditional use of the special
> [vectors] page which is only provided when CONFIG_KUSER_HELPERS is
> enabled in the kernel.
>
> Facilitate the debugging of such situations by printing a debug message
> to the kernel log showing the task name and the faulting address.
Hi Florian
Nice. I wish we had this a couple of months ago.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ARM: mm: Facilitate debugging CONFIG_KUSER_HELPERS disabled
2018-10-25 19:26 ` Andrew Lunn
@ 2018-10-31 22:54 ` Florian Fainelli
0 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2018-10-31 22:54 UTC (permalink / raw)
To: Andrew Lunn
Cc: linux-arm-kernel, ebiederm, Russell King, Andrew Morton,
Souptick Joarder, Tony Lindgren, open list
On 10/25/18 12:26 PM, Andrew Lunn wrote:
> On Thu, Oct 25, 2018 at 12:01:08PM -0700, Florian Fainelli wrote:
>> Some software such as perf makes unconditional use of the special
>> [vectors] page which is only provided when CONFIG_KUSER_HELPERS is
>> enabled in the kernel.
>>
>> Facilitate the debugging of such situations by printing a debug message
>> to the kernel log showing the task name and the faulting address.
>
> Hi Florian
>
> Nice. I wish we had this a couple of months ago.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks Andrew, submitted as 8807/1.
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-31 22:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-25 19:01 [PATCH v2] ARM: mm: Facilitate debugging CONFIG_KUSER_HELPERS disabled Florian Fainelli
2018-10-25 19:26 ` Andrew Lunn
2018-10-31 22:54 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).