linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [v2 PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE
@ 2019-11-26 18:44 Yang Shi
  2019-11-28  9:42 ` Anshuman Khandual
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Shi @ 2019-11-26 18:44 UTC (permalink / raw)
  To: songliubraving, kirill.shutemov, anshuman.khandual, akpm
  Cc: yang.shi, linux-mm, linux-kernel

The commit 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem)
FS") introduced a new khugepaged scan result: SCAN_PAGE_HAS_PRIVATE, but
the corresponding description for trace events were not added.

Cc: Song Liu <songliubraving@fb.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
---
v2: *Adopted the comments from Anshuman Khandual

 include/trace/events/huge_memory.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
index dd4db33..d82a0f4 100644
--- a/include/trace/events/huge_memory.h
+++ b/include/trace/events/huge_memory.h
@@ -31,7 +31,8 @@
 	EM( SCAN_ALLOC_HUGE_PAGE_FAIL,	"alloc_huge_page_failed")	\
 	EM( SCAN_CGROUP_CHARGE_FAIL,	"ccgroup_charge_failed")	\
 	EM( SCAN_EXCEED_SWAP_PTE,	"exceed_swap_pte")		\
-	EMe(SCAN_TRUNCATED,		"truncated")			\
+	EM( SCAN_TRUNCATED,		"truncated")			\
+	EMe(SCAN_PAGE_HAS_PRIVATE,	"page_has_private")		\
 
 #undef EM
 #undef EMe
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [v2 PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE
  2019-11-26 18:44 [v2 PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE Yang Shi
@ 2019-11-28  9:42 ` Anshuman Khandual
  0 siblings, 0 replies; 2+ messages in thread
From: Anshuman Khandual @ 2019-11-28  9:42 UTC (permalink / raw)
  To: Yang Shi, songliubraving, kirill.shutemov, akpm; +Cc: linux-mm, linux-kernel



On 11/27/2019 12:14 AM, Yang Shi wrote:
> The commit 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem)
> FS") introduced a new khugepaged scan result: SCAN_PAGE_HAS_PRIVATE, but
> the corresponding description for trace events were not added.
> 
> Cc: Song Liu <songliubraving@fb.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
> ---
> v2: *Adopted the comments from Anshuman Khandual

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

> 
>  include/trace/events/huge_memory.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
> index dd4db33..d82a0f4 100644
> --- a/include/trace/events/huge_memory.h
> +++ b/include/trace/events/huge_memory.h
> @@ -31,7 +31,8 @@
>  	EM( SCAN_ALLOC_HUGE_PAGE_FAIL,	"alloc_huge_page_failed")	\
>  	EM( SCAN_CGROUP_CHARGE_FAIL,	"ccgroup_charge_failed")	\
>  	EM( SCAN_EXCEED_SWAP_PTE,	"exceed_swap_pte")		\
> -	EMe(SCAN_TRUNCATED,		"truncated")			\
> +	EM( SCAN_TRUNCATED,		"truncated")			\
> +	EMe(SCAN_PAGE_HAS_PRIVATE,	"page_has_private")		\
>  
>  #undef EM
>  #undef EMe
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-28  9:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26 18:44 [v2 PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE Yang Shi
2019-11-28  9:42 ` Anshuman Khandual

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).