linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jiří Prchal" <jiri.prchal@aksignal.cz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Christian Eggers <ceggers@arri.de>, Arnd Bergmann <arnd@arndb.de>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v8 2/5] nvmem: eeprom: at25: add support for FRAM
Date: Tue, 8 Jun 2021 11:57:04 +0200	[thread overview]
Message-ID: <cc57eb8a-bfd6-f314-b408-0c4c8fe01a03@aksignal.cz> (raw)
In-Reply-To: <YL8zZraFXTvGr3dE@kroah.com>



On 08. 06. 21 11:07, Greg Kroah-Hartman wrote:
>> +	int has_sernum;
> 
> bool?

OK.
> 
>> +	spi_message_init(&m);
>> +	memset(t, 0, sizeof(t));
> 
> Are you allowed to send spi messages off of the stack?

I don't know, but it's functional. Copied from read function.
> 
> 
>> -	dev_info(&spi->dev, "%d %s %s eeprom%s, pagesize %u\n",
>> -		(chip.byte_len < 1024) ? chip.byte_len : (chip.byte_len / 1024),
>> -		(chip.byte_len < 1024) ? "Byte" : "KByte",
>> -		at25->chip.name,
>> -		(chip.flags & EE_READONLY) ? " (readonly)" : "",
>> -		at25->chip.page_size);
>> +	dev_info(&spi->dev, "%d %s %s %s%s, pagesize %u\n",
>> +		 (chip.byte_len < 1024) ? chip.byte_len : (chip.byte_len / 1024),
>> +		 (chip.byte_len < 1024) ? "Byte" : "KByte",
>> +		 at25->chip.name, is_fram ? "fram" : "eeprom",
>> +		 (chip.flags & EE_READONLY) ? " (readonly)" : "",
>> +		 at25->chip.page_size);
> 
> When drivers work properly, they should be quiet.  This whole dev_info()
> should be removed in a later patch.

OK, didn't know, originally there is such info output. And keeping 
simplest smallest patch changes.

  reply	other threads:[~2021-06-08  9:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 16:11 [PATCH v8 0/5] add support for FRAM Jiri Prchal
2021-06-07 16:11 ` [PATCH v8 1/5] nvmem: prepare basics for FRAM support Jiri Prchal
2021-06-07 16:11 ` [PATCH v8 2/5] nvmem: eeprom: at25: add support for FRAM Jiri Prchal
2021-06-08  9:07   ` Greg Kroah-Hartman
2021-06-08  9:57     ` Jiří Prchal [this message]
2021-06-07 16:11 ` [PATCH v8 3/5] dt-bindings: nvmem: at25: add for FRAM support Jiri Prchal
2021-06-07 16:12 ` [PATCH v8 4/5] nvmem: eeprom: at25: export FRAM serial num Jiri Prchal
2021-06-08  9:05   ` Greg Kroah-Hartman
2021-06-07 16:12 ` [PATCH v8 5/5] nvmem: eeprom: add documentation of sysfs fram and sernum file Jiri Prchal
2021-06-08  9:05   ` Greg Kroah-Hartman
2021-06-08  9:50     ` Jiří Prchal
2021-06-08 10:04       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc57eb8a-bfd6-f314-b408-0c4c8fe01a03@aksignal.cz \
    --to=jiri.prchal@aksignal.cz \
    --cc=arnd@arndb.de \
    --cc=ceggers@arri.de \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).