From: "Jiří Prchal" <jiri.prchal@aksignal.cz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Christian Eggers <ceggers@arri.de>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v8 5/5] nvmem: eeprom: add documentation of sysfs fram and sernum file
Date: Tue, 8 Jun 2021 11:50:03 +0200 [thread overview]
Message-ID: <d0aa3003-0cb7-53c8-6d0e-f1c2dcd90479@aksignal.cz> (raw)
In-Reply-To: <YL8yveuSWTC9iEEz@kroah.com>
On 08. 06. 21 11:05, Greg Kroah-Hartman wrote:
> On Mon, Jun 07, 2021 at 06:12:01PM +0200, Jiri Prchal wrote:
>> Added sysfs fram and sernum file documentation.
>>
>> Signed-off-by: Jiri Prchal <jiri.prchal@aksignal.cz>
>> ---
>> v5: new
>> v6: no change here
>> v7: no change here
>> v8: added fram file doc
>> ---
>> Documentation/ABI/testing/sysfs-class-spi-eeprom | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>> create mode 100644 Documentation/ABI/testing/sysfs-class-spi-eeprom
>>
>> diff --git a/Documentation/ABI/testing/sysfs-class-spi-eeprom b/Documentation/ABI/testing/sysfs-class-spi-eeprom
>> new file mode 100644
>> index 000000000000..b41420fe1329
>> --- /dev/null
>> +++ b/Documentation/ABI/testing/sysfs-class-spi-eeprom
>> @@ -0,0 +1,13 @@
>> +What: /sys/class/spi_master/spi<bus>/spi<bus>.<dev>/sernum
>> +Date: May 2021
>> +KernelVersion: 5.13
>> +Contact: Jiri Prchal <jiri.prchal@aksignal.cz>
>> +Description:
>> + (RO) Exports serial number of Cypress FRAM (FM25VN). 8 bytes as is in chip in hex string.
>
> Please properly wrap your lines.
>
> What is "(RO)" here?
Read Only, as seen in another doc.
>
> And the grammer is a bit odd, what is the second sentence supposed to
> mean?
>
>> +
>> +What: /sys/class/spi_master/spi<bus>/spi<bus>.<dev>/fram
>> +Date: June 2021
>> +KernelVersion: 5.13
>
> Obviously it can not make 5.13, right?
Sorry for missunderstanding, what number should be here?
next prev parent reply other threads:[~2021-06-08 9:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 16:11 [PATCH v8 0/5] add support for FRAM Jiri Prchal
2021-06-07 16:11 ` [PATCH v8 1/5] nvmem: prepare basics for FRAM support Jiri Prchal
2021-06-07 16:11 ` [PATCH v8 2/5] nvmem: eeprom: at25: add support for FRAM Jiri Prchal
2021-06-08 9:07 ` Greg Kroah-Hartman
2021-06-08 9:57 ` Jiří Prchal
2021-06-07 16:11 ` [PATCH v8 3/5] dt-bindings: nvmem: at25: add for FRAM support Jiri Prchal
2021-06-07 16:12 ` [PATCH v8 4/5] nvmem: eeprom: at25: export FRAM serial num Jiri Prchal
2021-06-08 9:05 ` Greg Kroah-Hartman
2021-06-07 16:12 ` [PATCH v8 5/5] nvmem: eeprom: add documentation of sysfs fram and sernum file Jiri Prchal
2021-06-08 9:05 ` Greg Kroah-Hartman
2021-06-08 9:50 ` Jiří Prchal [this message]
2021-06-08 10:04 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0aa3003-0cb7-53c8-6d0e-f1c2dcd90479@aksignal.cz \
--to=jiri.prchal@aksignal.cz \
--cc=arnd@arndb.de \
--cc=ceggers@arri.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).