* [PATCH 0/2] M68K: Fine-tuning for two function implementations
@ 2016-10-23 21:10 SF Markus Elfring
2016-10-23 21:11 ` [PATCH 1/2] M68K-Amiga: Use seq_puts() in amiga_get_hardware_list() SF Markus Elfring
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: SF Markus Elfring @ 2016-10-23 21:10 UTC (permalink / raw)
To: linux-m68k, Alexandre Belloni, Arnd Bergmann, Finn Thain,
Geert Uytterhoeven
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 23 Oct 2016 23:05:23 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use seq_puts() in amiga_get_hardware_list()
Use seq_puts() in atari_get_hardware_list()
arch/m68k/amiga/config.c | 3 +--
arch/m68k/atari/config.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
--
2.10.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] M68K-Amiga: Use seq_puts() in amiga_get_hardware_list()
2016-10-23 21:10 [PATCH 0/2] M68K: Fine-tuning for two function implementations SF Markus Elfring
@ 2016-10-23 21:11 ` SF Markus Elfring
2016-10-23 21:12 ` [PATCH 2/2] M68K-Atari: Use seq_puts() in atari_get_hardware_list() SF Markus Elfring
2016-10-24 9:10 ` [PATCH 0/2] M68K: Fine-tuning for two function implementations Geert Uytterhoeven
2 siblings, 0 replies; 4+ messages in thread
From: SF Markus Elfring @ 2016-10-23 21:11 UTC (permalink / raw)
To: linux-m68k, Alexandre Belloni, Arnd Bergmann, Finn Thain,
Geert Uytterhoeven
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 23 Oct 2016 22:55:03 +0200
A string which did not contain a data format specification should be put
into a sequence. Thus use the corresponding function "seq_puts".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/m68k/amiga/config.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/m68k/amiga/config.c b/arch/m68k/amiga/config.c
index ddb8192..65f63a4 100644
--- a/arch/m68k/amiga/config.c
+++ b/arch/m68k/amiga/config.c
@@ -786,8 +786,7 @@ static void amiga_get_hardware_list(struct seq_file *m)
if (AMIGAHW_PRESENT(name)) \
seq_printf (m, "\t%s\n", str)
- seq_printf (m, "Detected hardware:\n");
-
+ seq_puts(m, "Detected hardware:\n");
AMIGAHW_ANNOUNCE(AMI_VIDEO, "Amiga Video");
AMIGAHW_ANNOUNCE(AMI_BLITTER, "Blitter");
AMIGAHW_ANNOUNCE(AMBER_FF, "Amber Flicker Fixer");
--
2.10.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] M68K-Atari: Use seq_puts() in atari_get_hardware_list()
2016-10-23 21:10 [PATCH 0/2] M68K: Fine-tuning for two function implementations SF Markus Elfring
2016-10-23 21:11 ` [PATCH 1/2] M68K-Amiga: Use seq_puts() in amiga_get_hardware_list() SF Markus Elfring
@ 2016-10-23 21:12 ` SF Markus Elfring
2016-10-24 9:10 ` [PATCH 0/2] M68K: Fine-tuning for two function implementations Geert Uytterhoeven
2 siblings, 0 replies; 4+ messages in thread
From: SF Markus Elfring @ 2016-10-23 21:12 UTC (permalink / raw)
To: linux-m68k, Alexandre Belloni, Arnd Bergmann, Finn Thain,
Geert Uytterhoeven
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 23 Oct 2016 23:00:22 +0200
A string which did not contain a data format specification should be put
into a sequence. Thus use the corresponding function "seq_puts".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/m68k/atari/config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/m68k/atari/config.c b/arch/m68k/atari/config.c
index 97a3c38..e328eaf 100644
--- a/arch/m68k/atari/config.c
+++ b/arch/m68k/atari/config.c
@@ -629,7 +629,7 @@ static void atari_get_hardware_list(struct seq_file *m)
if (ATARIHW_PRESENT(name)) \
seq_printf(m, "\t%s\n", str)
- seq_printf(m, "Detected hardware:\n");
+ seq_puts(m, "Detected hardware:\n");
ATARIHW_ANNOUNCE(STND_SHIFTER, "ST Shifter");
ATARIHW_ANNOUNCE(EXTD_SHIFTER, "STe Shifter");
ATARIHW_ANNOUNCE(TT_SHIFTER, "TT Shifter");
--
2.10.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] M68K: Fine-tuning for two function implementations
2016-10-23 21:10 [PATCH 0/2] M68K: Fine-tuning for two function implementations SF Markus Elfring
2016-10-23 21:11 ` [PATCH 1/2] M68K-Amiga: Use seq_puts() in amiga_get_hardware_list() SF Markus Elfring
2016-10-23 21:12 ` [PATCH 2/2] M68K-Atari: Use seq_puts() in atari_get_hardware_list() SF Markus Elfring
@ 2016-10-24 9:10 ` Geert Uytterhoeven
2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2016-10-24 9:10 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-m68k, Alexandre Belloni, Arnd Bergmann, Finn Thain, LKML,
kernel-janitors
On Sun, Oct 23, 2016 at 11:10 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 23 Oct 2016 23:05:23 +0200
>
> A few update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (2):
> Use seq_puts() in amiga_get_hardware_list()
> Use seq_puts() in atari_get_hardware_list()
Thanks, will apply and queue for v4.10, after changing the one line summary
prefixes with prefixes matching the subsystem
(e.g. "s@M68K-Amiga@m68k/amiga@").
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-24 9:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-23 21:10 [PATCH 0/2] M68K: Fine-tuning for two function implementations SF Markus Elfring
2016-10-23 21:11 ` [PATCH 1/2] M68K-Amiga: Use seq_puts() in amiga_get_hardware_list() SF Markus Elfring
2016-10-23 21:12 ` [PATCH 2/2] M68K-Atari: Use seq_puts() in atari_get_hardware_list() SF Markus Elfring
2016-10-24 9:10 ` [PATCH 0/2] M68K: Fine-tuning for two function implementations Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).