From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Darren Hart <dvhart@infradead.org>,
Wolfram Sang <wsa@the-dreams.de>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v5 3/4] ACPI / x86-utils: Remove status workaround from acpi_device_always_present()
Date: Thu, 09 Aug 2018 13:08:47 +0300 [thread overview]
Message-ID: <cddf24980ccbb312f1e02eed632038fc0aa8b6fe.camel@linux.intel.com> (raw)
In-Reply-To: <20180809091558.4317-4-hdegoede@redhat.com>
On Thu, 2018-08-09 at 11:15 +0200, Hans de Goede wrote:
> Now that we init the status field to ACPI_STA_DEFAULT rather then to
> 0,
> the workaround for acpi_match_device_ids() always returning -ENOENT
> when
> status is 0 is no longer needed.
>
Always good to have only "minus" statistics
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v3:
> -New patch in v3 of this patch-set
> ---
> drivers/acpi/x86/utils.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
> index ec5b0f190231..a4fb97d64b3b 100644
> --- a/drivers/acpi/x86/utils.c
> +++ b/drivers/acpi/x86/utils.c
> @@ -103,13 +103,9 @@ static const struct always_present_id
> always_present_ids[] = {
>
> bool acpi_device_always_present(struct acpi_device *adev)
> {
> - u32 *status = (u32 *)&adev->status;
> - u32 old_status = *status;
> bool ret = false;
> unsigned int i;
>
> - /* acpi_match_device_ids checks status, so set it to default */
> - *status = ACPI_STA_DEFAULT;
> for (i = 0; i < ARRAY_SIZE(always_present_ids); i++) {
> if (acpi_match_device_ids(adev,
> always_present_ids[i].hid))
> continue;
> @@ -125,15 +121,9 @@ bool acpi_device_always_present(struct
> acpi_device *adev)
> !dmi_check_system(always_present_ids[i].dmi_ids))
> continue;
>
> - if (old_status != ACPI_STA_DEFAULT) /* Log only once */
> - dev_info(&adev->dev,
> - "Device [%s] is in always present
> list\n",
> - adev->pnp.bus_id);
> -
> ret = true;
> break;
> }
> - *status = old_status;
>
> return ret;
> }
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-08-09 10:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 9:15 [PATCH v5 0/4] i2c-multi-instantiate pseudo driver Hans de Goede
2018-08-09 9:15 ` [PATCH v5 1/4] ACPI / scan: Initialize status to ACPI_STA_DEFAULT Hans de Goede
2018-08-09 9:35 ` Rafael J. Wysocki
2018-08-09 9:39 ` Hans de Goede
2018-08-09 9:51 ` Andy Shevchenko
2018-08-09 9:58 ` Hans de Goede
2018-08-09 9:59 ` Rafael J. Wysocki
2018-08-09 11:36 ` Hans de Goede
2018-08-09 11:48 ` Andy Shevchenko
2018-08-09 10:00 ` Wolfram Sang
2018-08-09 9:15 ` [PATCH v5 2/4] ACPI / scan: Create platform device for fwnodes with multiple i2c devices Hans de Goede
2018-08-09 10:08 ` Andy Shevchenko
2018-08-09 9:15 ` [PATCH v5 3/4] ACPI / x86-utils: Remove status workaround from acpi_device_always_present() Hans de Goede
2018-08-09 10:08 ` Andy Shevchenko [this message]
2018-08-09 9:15 ` [PATCH v5 4/4] platform/x86: Add ACPI i2c-multi-instantiate pseudo driver Hans de Goede
2018-08-09 9:59 ` Wolfram Sang
2018-08-09 10:12 ` Andy Shevchenko
2018-08-09 11:09 ` Heikki Krogerus
2018-08-09 11:30 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cddf24980ccbb312f1e02eed632038fc0aa8b6fe.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).