From: Thomas Zimmermann <tzimmermann@suse.de>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Dave Airlie <airlied@redhat.com>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Thomas Gleixner <tglx@linutronix.de>,
Gerd Hoffmann <kraxel@redhat.com>,
Sam Ravnborg <sam@ravnborg.org>,
Kate Stewart <kstewart@linuxfoundation.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] drm/mgag200: Fix typo in parameter description
Date: Fri, 10 Jan 2020 09:28:07 +0100 [thread overview]
Message-ID: <ce1a17c8-2af9-a449-16d5-36ddfd7a976e@suse.de> (raw)
In-Reply-To: <20200110012523.33053-1-weiyongjun1@huawei.com>
[-- Attachment #1.1: Type: text/plain, Size: 1600 bytes --]
Hi
Am 10.01.20 um 02:25 schrieb Wei Yongjun:
> Fix typo in parameter description.
As Dan said, please mention that it's about a module parameter. The
current commit message appears to refer to a function's parameter.
With the commit message fixed, you can add
Reviewed-by: Thomas Zimemrmann <tzimmermann@suse.de>
Thanks for fixing this bug.
Best regards
Thomas
>
> Fixes: 3cacb2086e41 ("drm/mgag200: Add module parameter to pin all buffers at offset 0")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index 7a5bad2f57d7..2236f8ef20a4 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -28,7 +28,7 @@ MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
> module_param_named(modeset, mgag200_modeset, int, 0400);
>
> int mgag200_hw_bug_no_startadd = -1;
> -MODULE_PARM_DESC(modeset, "HW does not interpret scanout-buffer start address correctly");
> +MODULE_PARM_DESC(hw_bug_no_startadd, "HW does not interpret scanout-buffer start address correctly");
> module_param_named(hw_bug_no_startadd, mgag200_hw_bug_no_startadd, int, 0400);
>
> static struct drm_driver driver;
>
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-10 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 1:25 [PATCH -next] drm/mgag200: Fix typo in parameter description Wei Yongjun
2020-01-10 3:49 ` Dan Carpenter
2020-01-10 8:28 ` Thomas Zimmermann [this message]
2020-01-11 7:42 ` [PATCH -next v2] drm/mgag200: Fix typo in module " Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce1a17c8-2af9-a449-16d5-36ddfd7a976e@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kraxel@redhat.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).