* [PATCH -next] drm/mgag200: Fix typo in parameter description
@ 2020-01-10 1:25 Wei Yongjun
2020-01-10 3:49 ` Dan Carpenter
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wei Yongjun @ 2020-01-10 1:25 UTC (permalink / raw)
To: Dave Airlie, David Airlie, Daniel Vetter, Thomas Gleixner,
Thomas Zimmermann, Gerd Hoffmann, Sam Ravnborg, Kate Stewart
Cc: Wei Yongjun, dri-devel, linux-kernel, kernel-janitors
Fix typo in parameter description.
Fixes: 3cacb2086e41 ("drm/mgag200: Add module parameter to pin all buffers at offset 0")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
index 7a5bad2f57d7..2236f8ef20a4 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -28,7 +28,7 @@ MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
module_param_named(modeset, mgag200_modeset, int, 0400);
int mgag200_hw_bug_no_startadd = -1;
-MODULE_PARM_DESC(modeset, "HW does not interpret scanout-buffer start address correctly");
+MODULE_PARM_DESC(hw_bug_no_startadd, "HW does not interpret scanout-buffer start address correctly");
module_param_named(hw_bug_no_startadd, mgag200_hw_bug_no_startadd, int, 0400);
static struct drm_driver driver;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] drm/mgag200: Fix typo in parameter description
2020-01-10 1:25 [PATCH -next] drm/mgag200: Fix typo in parameter description Wei Yongjun
@ 2020-01-10 3:49 ` Dan Carpenter
2020-01-10 8:28 ` Thomas Zimmermann
2020-01-11 7:42 ` [PATCH -next v2] drm/mgag200: Fix typo in module " Wei Yongjun
2 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-01-10 3:49 UTC (permalink / raw)
To: Wei Yongjun
Cc: Dave Airlie, David Airlie, Daniel Vetter, Thomas Gleixner,
Thomas Zimmermann, Gerd Hoffmann, Sam Ravnborg, Kate Stewart,
dri-devel, linux-kernel, kernel-janitors
On Fri, Jan 10, 2020 at 01:25:23AM +0000, Wei Yongjun wrote:
> Fix typo in parameter description.
>
This commit message isn't totally clear. Maybe say something like:
There was a typo in the MODULE_PARM_DESC(). It said that the module
parameter was "modeset" but it's actually the description for
"hw_bug_no_startadd".
> Fixes: 3cacb2086e41 ("drm/mgag200: Add module parameter to pin all buffers at offset 0")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] drm/mgag200: Fix typo in parameter description
2020-01-10 1:25 [PATCH -next] drm/mgag200: Fix typo in parameter description Wei Yongjun
2020-01-10 3:49 ` Dan Carpenter
@ 2020-01-10 8:28 ` Thomas Zimmermann
2020-01-11 7:42 ` [PATCH -next v2] drm/mgag200: Fix typo in module " Wei Yongjun
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2020-01-10 8:28 UTC (permalink / raw)
To: Wei Yongjun, Dave Airlie, David Airlie, Daniel Vetter,
Thomas Gleixner, Gerd Hoffmann, Sam Ravnborg, Kate Stewart
Cc: dri-devel, linux-kernel, kernel-janitors
[-- Attachment #1.1: Type: text/plain, Size: 1600 bytes --]
Hi
Am 10.01.20 um 02:25 schrieb Wei Yongjun:
> Fix typo in parameter description.
As Dan said, please mention that it's about a module parameter. The
current commit message appears to refer to a function's parameter.
With the commit message fixed, you can add
Reviewed-by: Thomas Zimemrmann <tzimmermann@suse.de>
Thanks for fixing this bug.
Best regards
Thomas
>
> Fixes: 3cacb2086e41 ("drm/mgag200: Add module parameter to pin all buffers at offset 0")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index 7a5bad2f57d7..2236f8ef20a4 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -28,7 +28,7 @@ MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
> module_param_named(modeset, mgag200_modeset, int, 0400);
>
> int mgag200_hw_bug_no_startadd = -1;
> -MODULE_PARM_DESC(modeset, "HW does not interpret scanout-buffer start address correctly");
> +MODULE_PARM_DESC(hw_bug_no_startadd, "HW does not interpret scanout-buffer start address correctly");
> module_param_named(hw_bug_no_startadd, mgag200_hw_bug_no_startadd, int, 0400);
>
> static struct drm_driver driver;
>
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH -next v2] drm/mgag200: Fix typo in module parameter description
2020-01-10 1:25 [PATCH -next] drm/mgag200: Fix typo in parameter description Wei Yongjun
2020-01-10 3:49 ` Dan Carpenter
2020-01-10 8:28 ` Thomas Zimmermann
@ 2020-01-11 7:42 ` Wei Yongjun
2 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2020-01-11 7:42 UTC (permalink / raw)
To: Dave Airlie, David Airlie, Daniel Vetter, Thomas Gleixner,
Thomas Zimmermann, Gerd Hoffmann, Sam Ravnborg, Kate Stewart,
Dan Carpenter
Cc: Wei Yongjun, dri-devel, linux-kernel, kernel-janitors
There was a typo in the MODULE_PARM_DESC(). It said that the
module parameter was "modeset" but it's actually the description
for "hw_bug_no_startadd".
Fixes: 3cacb2086e41 ("drm/mgag200: Add module parameter to pin all buffers at offset 0")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: Fix the description
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
index 7a5bad2f57d7..2236f8ef20a4 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -28,7 +28,7 @@ MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
module_param_named(modeset, mgag200_modeset, int, 0400);
int mgag200_hw_bug_no_startadd = -1;
-MODULE_PARM_DESC(modeset, "HW does not interpret scanout-buffer start address correctly");
+MODULE_PARM_DESC(hw_bug_no_startadd, "HW does not interpret scanout-buffer start address correctly");
module_param_named(hw_bug_no_startadd, mgag200_hw_bug_no_startadd, int, 0400);
static struct drm_driver driver;
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-11 7:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-10 1:25 [PATCH -next] drm/mgag200: Fix typo in parameter description Wei Yongjun
2020-01-10 3:49 ` Dan Carpenter
2020-01-10 8:28 ` Thomas Zimmermann
2020-01-11 7:42 ` [PATCH -next v2] drm/mgag200: Fix typo in module " Wei Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).