From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Sathvika Vasireddy <sv@linux.vnet.ibm.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"mbenes@suse.cz" <mbenes@suse.cz>,
"aik@ozlabs.ru" <aik@ozlabs.ru>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"naveen.n.rao@linux.vnet.ibm.com"
<naveen.n.rao@linux.vnet.ibm.com>,
Sathvika Vasireddy <sv@linux.ibm.com>
Subject: Re: [RFC PATCH 2/4] objtool: Enable objtool to run only on files with ftrace enabled
Date: Tue, 24 May 2022 13:28:34 +0000 [thread overview]
Message-ID: <ce4d2b3c-5cd9-d33a-648c-7f294e9eb94f@csgroup.eu> (raw)
In-Reply-To: <d28a9bf0-65ac-797c-3640-8af7e0beec33@linux.vnet.ibm.com>
Hi Sathvika
Le 24/05/2022 à 12:53, Sathvika Vasireddy a écrit :
> [Vous ne recevez pas souvent de courriers de la part de
> sv@linux.vnet.ibm.com. Découvrez pourquoi cela peut être important à
> l’adresse https://aka.ms/LearnAboutSenderIdentification.]
>
> Hi Christophe,
>
> On 24/05/22 14:27, Christophe Leroy wrote:
>>
>> Le 23/05/2022 à 19:55, Sathvika Vasireddy a écrit :
>>> This patch makes sure objtool runs only on the object files
>>> that have ftrace enabled, instead of running on all the object
>>> files.
>> Why do that ?
> This was done to address the issue discussed here:
> https://lore.kernel.org/all/b06bb9bc-22d1-acce-fe68-c7c4cb7c15b5@csgroup.eu/
Ah ? Ok.
But how does x86 do it at the moment ? Shouldn't we use
OBJECT_FILES_NON_STANDARD instead ?
>
>
>>
>> What about static_calls ? There may be files without ftrace but with
>> static calls.
> Yes, this prevents objtool from running on those files. We can
> restrict this change to FTRACE_MCOUNT_USE_OBJTOOL
>>
>> By the way, it would be nice if we could use it only on C files.
>> I get the following errors for ASM files:
>>
>> arch/powerpc/kernel/entry_32.o: warning: objtool: .text+0x1b4:
>> unannotated intra-function call
>
> I'm looking into ways to address this.
>
Nice.
Christophe
next prev parent reply other threads:[~2022-05-24 13:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 17:55 [RFC PATCH 0/4] objtool: Enable and implement --mcount option on powerpc Sathvika Vasireddy
2022-05-23 17:55 ` [RFC PATCH 1/4] objtool: Add --mnop as an option to --mcount Sathvika Vasireddy
2022-05-24 8:54 ` Christophe Leroy
2022-05-24 10:15 ` Naveen N. Rao
2022-05-24 10:20 ` Christophe Leroy
2022-05-24 10:31 ` Naveen N. Rao
2022-05-25 11:36 ` Peter Zijlstra
2022-05-26 11:51 ` Naveen N. Rao
2022-05-23 17:55 ` [RFC PATCH 2/4] objtool: Enable objtool to run only on files with ftrace enabled Sathvika Vasireddy
2022-05-24 8:57 ` Christophe Leroy
2022-05-24 10:53 ` Sathvika Vasireddy
2022-05-24 13:28 ` Christophe Leroy [this message]
2022-05-23 17:55 ` [RFC PATCH 3/4] objtool/powerpc: Enable objtool to be built on ppc Sathvika Vasireddy
2022-05-24 9:13 ` Christophe Leroy
2022-05-23 17:55 ` [RFC PATCH 4/4] objtool/powerpc: Add --mcount specific implementation Sathvika Vasireddy
2022-05-24 9:35 ` Christophe Leroy
2022-05-24 11:00 ` Sathvika Vasireddy
2022-05-24 13:33 ` Christophe Leroy
2022-05-25 17:27 ` Christophe Leroy
2022-05-31 6:20 ` Christophe Leroy
2022-06-16 13:34 ` Naveen N. Rao
2022-06-16 13:40 ` Christophe Leroy
2022-06-16 13:57 ` Peter Zijlstra
2022-06-16 14:06 ` Christophe Leroy
2022-06-17 14:04 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce4d2b3c-5cd9-d33a-648c-7f294e9eb94f@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=aik@ozlabs.ru \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mbenes@suse.cz \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sv@linux.ibm.com \
--cc=sv@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).