From: Anton Yakovlev <anton.yakovlev@opensynergy.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: <virtualization@lists.linux-foundation.org>,
<alsa-devel@alsa-project.org>, <virtio-dev@lists.oasis-open.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Jason Wang <jasowang@redhat.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 2/9] ALSA: virtio: add virtio sound driver
Date: Thu, 25 Feb 2021 12:51:36 +0100 [thread overview]
Message-ID: <cea4164d-345e-393b-9328-731c2f874eb7@opensynergy.com> (raw)
In-Reply-To: <s5h7dmwqvo4.wl-tiwai@suse.de>
On 25.02.2021 11:38, Takashi Iwai wrote:
> On Mon, 22 Feb 2021 16:34:37 +0100,
> Anton Yakovlev wrote:
>> +static int virtsnd_find_vqs(struct virtio_snd *snd)
>> +{
>> + struct virtio_device *vdev = snd->vdev;
>> + vq_callback_t *callbacks[VIRTIO_SND_VQ_MAX] = {
>> + [VIRTIO_SND_VQ_EVENT] = virtsnd_event_notify_cb
>> + };
>> + const char *names[VIRTIO_SND_VQ_MAX] = {
>
> Shouldn't be static?
Well, yes. Although in this particular case, I do not think it is that
critical. :)
> Also it's often const char * const names[] = { ... }
> unless you overwrite something.
I tried to use the same type names as in the function prototype.
Otherwise the compiler or static analyzer may complain.
>> +/**
>> + * virtsnd_reset_fn() - Kernel worker's function to reset the device.
>> + * @work: Reset device work.
>> + *
>> + * Context: Process context.
>> + */
>> +static void virtsnd_reset_fn(struct work_struct *work)
>> +{
>> + struct virtio_snd *snd =
>> + container_of(work, struct virtio_snd, reset_work);
>> + struct virtio_device *vdev = snd->vdev;
>> + struct device *dev = &vdev->dev;
>> + int rc;
>> +
>> + dev_info(dev, "sound device needs reset\n");
>> +
>> + /*
>> + * It seems that the only way to properly reset the device is to remove
>> + * and re-create the ALSA sound card device.
>> + */
>> + rc = device_reprobe(dev);
>> + if (rc)
>> + dev_err(dev, "failed to reprobe sound device: %d\n", rc);
>
> Now I'm wondering whether it's safe to do that from this place.
> Basically device_reprobe() unbinds the device that releases the full
> resources once including the devm_* stuff. And this work itself is in
> a part of devm allocated resource, so it'll be released there. That
> said, we might hit use-after-free... This needs to be verified.
It's safe. Suicide kernel workers are funny but possible things. Since
the kernel itself (AFAIU) assumes such a situation and does not access
the worker structure after the callback function call.
> thanks,
>
> Takashi
>
--
Anton Yakovlev
Senior Software Engineer
OpenSynergy GmbH
Rotherstr. 20, 10245 Berlin
next prev parent reply other threads:[~2021-02-25 11:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210222153444.348390-1-anton.yakovlev@opensynergy.com>
2021-02-22 15:34 ` [PATCH v5 1/9] uapi: virtio_ids: add a sound device type ID from OASIS spec Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 2/9] ALSA: virtio: add virtio sound driver Anton Yakovlev
2021-02-25 10:38 ` Takashi Iwai
2021-02-25 10:39 ` Takashi Iwai
2021-02-25 11:51 ` Anton Yakovlev [this message]
2021-02-25 12:08 ` Takashi Iwai
2021-02-22 15:34 ` [PATCH v5 3/9] ALSA: virtio: handling control messages Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 4/9] ALSA: virtio: build PCM devices and substream hardware descriptors Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 5/9] ALSA: virtio: handling control and I/O messages for the PCM device Anton Yakovlev
2021-02-25 10:45 ` Takashi Iwai
2021-02-22 15:34 ` [PATCH v5 6/9] ALSA: virtio: PCM substream operators Anton Yakovlev
2021-02-25 10:55 ` Takashi Iwai
2021-02-25 12:14 ` Anton Yakovlev
2021-02-25 12:51 ` Takashi Iwai
2021-02-25 19:02 ` Michael S. Tsirkin
2021-02-25 20:30 ` Takashi Iwai
2021-02-25 22:19 ` Anton Yakovlev
2021-02-26 14:23 ` Takashi Iwai
2021-02-26 20:16 ` Anton Yakovlev
2021-02-26 20:19 ` Anton Yakovlev
2021-02-27 7:50 ` Takashi Iwai
2021-02-22 15:34 ` [PATCH v5 7/9] ALSA: virtio: introduce jack support Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 8/9] ALSA: virtio: introduce PCM channel map support Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 9/9] ALSA: virtio: introduce device suspend/resume support Anton Yakovlev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cea4164d-345e-393b-9328-731c2f874eb7@opensynergy.com \
--to=anton.yakovlev@opensynergy.com \
--cc=alsa-devel@alsa-project.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).