From: Takashi Iwai <tiwai@suse.de>
To: Anton Yakovlev <anton.yakovlev@opensynergy.com>
Cc: <virtualization@lists.linux-foundation.org>,
<alsa-devel@alsa-project.org>, <virtio-dev@lists.oasis-open.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 5/9] ALSA: virtio: handling control and I/O messages for the PCM device
Date: Thu, 25 Feb 2021 11:45:24 +0100 [thread overview]
Message-ID: <s5h4ki0qvcr.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210222153444.348390-6-anton.yakovlev@opensynergy.com>
On Mon, 22 Feb 2021 16:34:40 +0100,
Anton Yakovlev wrote:
>
> +void virtsnd_pcm_event(struct virtio_snd *snd, struct virtio_snd_event *event)
> +{
> + struct virtio_pcm_substream *vss;
> + u32 sid = le32_to_cpu(event->data);
> +
> + if (sid >= snd->nsubstreams)
> + return;
> +
> + vss = &snd->substreams[sid];
> +
> + switch (le32_to_cpu(event->hdr.code)) {
> + case VIRTIO_SND_EVT_PCM_PERIOD_ELAPSED:
> + /* TODO: deal with shmem elapsed period */
> + break;
> + case VIRTIO_SND_EVT_PCM_XRUN:
> + spin_lock(&vss->lock);
> + if (vss->xfer_enabled)
> + vss->xfer_xrun = true;
> + spin_unlock(&vss->lock);
You can stop the stream at xrun, too.
But it often messes up with the locking, so it's no mandatory
implementation. You seem to pass the xrun state at the pointer
callback, and this should be enough for normal uses.
thanks,
Takashi
next prev parent reply other threads:[~2021-02-25 10:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210222153444.348390-1-anton.yakovlev@opensynergy.com>
2021-02-22 15:34 ` [PATCH v5 1/9] uapi: virtio_ids: add a sound device type ID from OASIS spec Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 2/9] ALSA: virtio: add virtio sound driver Anton Yakovlev
2021-02-25 10:38 ` Takashi Iwai
2021-02-25 10:39 ` Takashi Iwai
2021-02-25 11:51 ` Anton Yakovlev
2021-02-25 12:08 ` Takashi Iwai
2021-02-22 15:34 ` [PATCH v5 3/9] ALSA: virtio: handling control messages Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 4/9] ALSA: virtio: build PCM devices and substream hardware descriptors Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 5/9] ALSA: virtio: handling control and I/O messages for the PCM device Anton Yakovlev
2021-02-25 10:45 ` Takashi Iwai [this message]
2021-02-22 15:34 ` [PATCH v5 6/9] ALSA: virtio: PCM substream operators Anton Yakovlev
2021-02-25 10:55 ` Takashi Iwai
2021-02-25 12:14 ` Anton Yakovlev
2021-02-25 12:51 ` Takashi Iwai
2021-02-25 19:02 ` Michael S. Tsirkin
2021-02-25 20:30 ` Takashi Iwai
2021-02-25 22:19 ` Anton Yakovlev
2021-02-26 14:23 ` Takashi Iwai
2021-02-26 20:16 ` Anton Yakovlev
2021-02-26 20:19 ` Anton Yakovlev
2021-02-27 7:50 ` Takashi Iwai
2021-02-22 15:34 ` [PATCH v5 7/9] ALSA: virtio: introduce jack support Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 8/9] ALSA: virtio: introduce PCM channel map support Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 9/9] ALSA: virtio: introduce device suspend/resume support Anton Yakovlev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4ki0qvcr.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=anton.yakovlev@opensynergy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).