* [PATCH] media: radio: aimslab: restore RADIO_ISA dependency
@ 2018-06-05 11:33 Arnd Bergmann
2018-06-05 15:20 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-06-05 11:33 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Arnd Bergmann, Takashi Iwai, linux-media, linux-kernel
The patch that allowed all the ISA drivers to build across architectures
accidentally removed one 'select' statement, which now causes a rare
randconfig build failure in case all the other drivers are disabled:
drivers/media/radio/radio-aimslab.o:(.data+0x0): undefined reference to `radio_isa_match'
drivers/media/radio/radio-aimslab.o:(.data+0x4): undefined reference to `radio_isa_probe'
drivers/media/radio/radio-aimslab.o:(.data+0x8): undefined reference to `radio_isa_remove'
This puts the statement back where it belongs.
Fixes: 258c524bdaab ("media: radio: allow building ISA drivers with COMPILE_TEST")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/media/radio/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
index 8fa403c7149e..39b04ad924c0 100644
--- a/drivers/media/radio/Kconfig
+++ b/drivers/media/radio/Kconfig
@@ -257,6 +257,7 @@ config RADIO_RTRACK
tristate "AIMSlab RadioTrack (aka RadioReveal) support"
depends on ISA || COMPILE_TEST
depends on VIDEO_V4L2
+ select RADIO_ISA
---help---
Choose Y here if you have one of these FM radio cards, and then fill
in the port address below.
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: radio: aimslab: restore RADIO_ISA dependency
2018-06-05 11:33 [PATCH] media: radio: aimslab: restore RADIO_ISA dependency Arnd Bergmann
@ 2018-06-05 15:20 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2018-06-05 15:20 UTC (permalink / raw)
To: Arnd Bergmann, Mauro Carvalho Chehab
Cc: Takashi Iwai, linux-media, linux-kernel
On 06/05/2018 04:33 AM, Arnd Bergmann wrote:
> The patch that allowed all the ISA drivers to build across architectures
> accidentally removed one 'select' statement, which now causes a rare
> randconfig build failure in case all the other drivers are disabled:
>
> drivers/media/radio/radio-aimslab.o:(.data+0x0): undefined reference to `radio_isa_match'
> drivers/media/radio/radio-aimslab.o:(.data+0x4): undefined reference to `radio_isa_probe'
> drivers/media/radio/radio-aimslab.o:(.data+0x8): undefined reference to `radio_isa_remove'
>
> This puts the statement back where it belongs.
>
> Fixes: 258c524bdaab ("media: radio: allow building ISA drivers with COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/media/radio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
> index 8fa403c7149e..39b04ad924c0 100644
> --- a/drivers/media/radio/Kconfig
> +++ b/drivers/media/radio/Kconfig
> @@ -257,6 +257,7 @@ config RADIO_RTRACK
> tristate "AIMSlab RadioTrack (aka RadioReveal) support"
> depends on ISA || COMPILE_TEST
> depends on VIDEO_V4L2
> + select RADIO_ISA
> ---help---
> Choose Y here if you have one of these FM radio cards, and then fill
> in the port address below.
>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
https://marc.info/?l=linux-next&m=152778594005254&w=2
thanks,
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-05 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-05 11:33 [PATCH] media: radio: aimslab: restore RADIO_ISA dependency Arnd Bergmann
2018-06-05 15:20 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).