From: "Paraschiv, Andra-Irina" <andraprs@amazon.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>,
Anthony Liguori <aliguori@amazon.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Colm MacCarthaigh <colmmacc@amazon.com>,
Bjoern Doebel <doebel@amazon.de>,
David Woodhouse <dwmw@amazon.co.uk>,
Frank van der Linden <fllinden@amazon.com>,
"Alexander Graf" <graf@amazon.de>,
Martin Pohlack <mpohlack@amazon.de>, Matt Wilson <msw@amazon.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Balbir Singh <sblbir@amazon.com>,
Stefano Garzarella <sgarzare@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
Stewart Smith <trawets@amazon.com>,
"Uwe Dannowski" <uwed@amazon.de>, <kvm@vger.kernel.org>,
<ne-devel-upstream@amazon.com>
Subject: Re: [PATCH v3 02/18] nitro_enclaves: Define the PCI device interface
Date: Thu, 28 May 2020 19:37:06 +0300 [thread overview]
Message-ID: <ceca466d-4c2e-8693-08c7-1fea5ab68cb7@amazon.com> (raw)
In-Reply-To: <20200526222109.GB179549@kroah.com>
On 27/05/2020 01:21, Greg KH wrote:
> On Tue, May 26, 2020 at 08:01:36PM +0300, Paraschiv, Andra-Irina wrote:
>>
>> On 26/05/2020 09:44, Greg KH wrote:
>>> On Tue, May 26, 2020 at 01:13:18AM +0300, Andra Paraschiv wrote:
>>>> +struct enclave_get_slot_req {
>>>> + /* Context ID (CID) for the enclave vsock device. */
>>>> + u64 enclave_cid;
>>>> +} __attribute__ ((__packed__));
>>> Can you really "pack" a single member structure?
>>>
>>> Anyway, we have better ways to specify this instead of the "raw"
>>> __attribute__ option. But first see if you really need any of these, at
>>> first glance, I do not think you do at all, and they can all be removed.
>> There are a couple of data structures with more than one member and multiple
>> field sizes. And for the ones that are not, gathered as feedback from
>> previous rounds of review that should consider adding a "flags" field in
>> there for further extensibility.
> Please do not do that in ioctls. Just create new calls instead of
> trying to "extend" existing ones. It's always much easier.
>
>> I can modify to have "__packed" instead of the attribute callout.
> Make sure you even need that, as I don't think you do for structures
> like the above one, right?
For the ones like the above, not, I just customized the usage of "__packed".
Thanks,
Andra
Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
next prev parent reply other threads:[~2020-05-28 16:37 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 22:13 [PATCH v3 00/18] Add support for Nitro Enclaves Andra Paraschiv
2020-05-25 22:13 ` [PATCH v3 01/18] nitro_enclaves: Add ioctl interface definition Andra Paraschiv
2020-05-27 8:49 ` Stefan Hajnoczi
2020-05-28 18:05 ` Paraschiv, Andra-Irina
2020-06-01 3:02 ` Benjamin Herrenschmidt
2020-06-01 7:20 ` Paraschiv, Andra-Irina
2020-06-05 8:15 ` Stefan Hajnoczi
2020-06-05 15:39 ` Paraschiv, Andra-Irina
2020-05-25 22:13 ` [PATCH v3 02/18] nitro_enclaves: Define the PCI device interface Andra Paraschiv
2020-05-26 6:44 ` Greg KH
2020-05-26 17:01 ` Paraschiv, Andra-Irina
2020-05-26 22:21 ` Greg KH
2020-05-28 16:37 ` Paraschiv, Andra-Irina [this message]
2020-06-01 2:59 ` Benjamin Herrenschmidt
2020-06-01 7:07 ` Paraschiv, Andra-Irina
2020-06-01 2:53 ` Benjamin Herrenschmidt
2020-05-25 22:13 ` [PATCH v3 03/18] nitro_enclaves: Define enclave info for internal bookkeeping Andra Paraschiv
2020-05-26 6:46 ` Greg KH
2020-05-26 17:20 ` Paraschiv, Andra-Irina
2020-05-25 22:13 ` [PATCH v3 04/18] nitro_enclaves: Init PCI device driver Andra Paraschiv
2020-05-26 6:48 ` Greg KH
2020-05-26 18:35 ` Paraschiv, Andra-Irina
2020-05-26 22:19 ` Greg KH
2020-05-28 16:26 ` Paraschiv, Andra-Irina
2020-06-01 2:55 ` Benjamin Herrenschmidt
2020-06-01 6:42 ` Paraschiv, Andra-Irina
2020-05-25 22:13 ` [PATCH v3 05/18] nitro_enclaves: Handle PCI device command requests Andra Paraschiv
2020-05-25 22:13 ` [PATCH v3 06/18] nitro_enclaves: Handle out-of-band PCI device events Andra Paraschiv
2020-05-25 22:13 ` [PATCH v3 07/18] nitro_enclaves: Init misc device providing the ioctl interface Andra Paraschiv
2020-05-26 6:51 ` Greg KH
2020-05-26 11:42 ` Alexander Graf
2020-05-26 12:33 ` Greg KH
2020-05-26 12:44 ` Alexander Graf
2020-05-26 13:17 ` Greg KH
2020-05-26 13:44 ` Alexander Graf
2020-05-26 22:24 ` Greg KH
2020-05-28 13:01 ` Alexander Graf
2020-05-28 13:12 ` Greg KH
2020-05-28 17:06 ` Paraschiv, Andra-Irina
2020-06-01 3:04 ` Benjamin Herrenschmidt
2020-06-09 10:47 ` Alexander Graf
2020-06-01 3:01 ` Benjamin Herrenschmidt
2020-06-01 2:51 ` Benjamin Herrenschmidt
2020-05-26 13:40 ` Paraschiv, Andra-Irina
2020-06-01 2:47 ` Benjamin Herrenschmidt
2020-06-01 5:48 ` Greg KH
2020-05-25 22:13 ` [PATCH v3 08/18] nitro_enclaves: Add logic for enclave vm creation Andra Paraschiv
2020-05-25 22:13 ` [PATCH v3 09/18] nitro_enclaves: Add logic for enclave vcpu creation Andra Paraschiv
2020-05-25 22:13 ` [PATCH v3 10/18] nitro_enclaves: Add logic for enclave image load metadata Andra Paraschiv
2020-05-25 22:13 ` [PATCH v3 11/18] nitro_enclaves: Add logic for enclave memory region set Andra Paraschiv
2020-05-25 22:13 ` [PATCH v3 12/18] nitro_enclaves: Add logic for enclave start Andra Paraschiv
2020-05-25 22:13 ` [PATCH v3 13/18] nitro_enclaves: Add logic for enclave termination Andra Paraschiv
2020-05-25 22:13 ` [PATCH v3 14/18] nitro_enclaves: Add Kconfig for the Nitro Enclaves driver Andra Paraschiv
2020-05-25 22:13 ` [PATCH v3 15/18] nitro_enclaves: Add Makefile " Andra Paraschiv
2020-05-25 22:13 ` [PATCH v3 16/18] nitro_enclaves: Add sample for ioctl interface usage Andra Paraschiv
2020-05-26 6:52 ` Greg KH
2020-05-25 22:13 ` [PATCH v3 17/18] nitro_enclaves: Add overview documentation Andra Paraschiv
2020-05-25 22:13 ` [PATCH v3 18/18] MAINTAINERS: Add entry for the Nitro Enclaves driver Andra Paraschiv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceca466d-4c2e-8693-08c7-1fea5ab68cb7@amazon.com \
--to=andraprs@amazon.com \
--cc=aliguori@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=colmmacc@amazon.com \
--cc=doebel@amazon.de \
--cc=dwmw@amazon.co.uk \
--cc=fllinden@amazon.com \
--cc=graf@amazon.de \
--cc=gregkh@linuxfoundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpohlack@amazon.de \
--cc=msw@amazon.com \
--cc=ne-devel-upstream@amazon.com \
--cc=pbonzini@redhat.com \
--cc=sblbir@amazon.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=trawets@amazon.com \
--cc=uwed@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).