From: Sandeep Patil <sspatil@android.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable <stable@vger.kernel.org>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH 1/1] fs: pipe: wakeup readers everytime new data written is to pipe
Date: Fri, 30 Jul 2021 19:11:29 +0000 [thread overview]
Message-ID: <cee514d6-8551-8838-6d61-098d04e226ca@android.com> (raw)
In-Reply-To: <CAHk-=wh-DWvsFykwAy6uwyv24nasJ39d7SHT+15x+xEXBtSm_Q@mail.gmail.com>
On 7/29/21 11:01 PM, Linus Torvalds wrote:
> On Thu, Jul 29, 2021 at 3:27 PM Sandeep Patil <sspatil@android.com> wrote:
>>
>> So restore the old behavior to wakeup all readers if any new data is
>> written to the pipe.
>
> Ah-hahh.
>
> I've had this slightly smaller patch waiting for the better part of a year:
>
> https://lore.kernel.org/lkml/CAHk-=wgjR7Nd4CyDoi3SH9kPJp_Td9S-hhFJZMqvp6GS1Ww8eg@mail.gmail.com/
>
> waiting to see if some broken program actually depends on the bogus
> epollet semantics.
>
> Can you verify that that patch fixes the realm-core brokenness too?
Yes, your patch fixes all apps on Android I can test that include this
library.
fwiw, the library seems to have been fixed. However, I am not sure
how long it will be for all apps to take that update :(.
- ssp
next prev parent reply other threads:[~2021-07-30 19:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 22:26 [PATCH 0/1] Revert change in pipe reader wakeup behavior Sandeep Patil
2021-07-29 22:26 ` [PATCH 1/1] fs: pipe: wakeup readers everytime new data written is to pipe Sandeep Patil
2021-07-29 23:01 ` Linus Torvalds
2021-07-30 19:11 ` Sandeep Patil [this message]
2021-07-30 19:23 ` Linus Torvalds
2021-07-30 19:47 ` Sandeep Patil
2021-07-30 22:06 ` Linus Torvalds
2021-07-30 22:53 ` Linus Torvalds
2021-07-30 22:55 ` Linus Torvalds
2021-07-31 5:32 ` Greg Kroah-Hartman
2021-08-02 18:59 ` Sandeep Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cee514d6-8551-8838-6d61-098d04e226ca@android.com \
--to=sspatil@android.com \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).