From: Thorsten Leemhuis <regressions@leemhuis.info>
To: "An, Tedd" <tedd.an@intel.com>,
"ortwin.glueck@logobject.ch" <ortwin.glueck@logobject.ch>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix 5.15 init regression for Intel Bluetooth
Date: Sat, 8 Jan 2022 12:53:12 +0100 [thread overview]
Message-ID: <cf5b69c6-532b-4c6e-c046-eaad65019e8f@leemhuis.info> (raw)
In-Reply-To: <7b400964d7bcf052fb609bd1647936df03bdc667.camel@intel.com>
On 08.01.22 03:08, An, Tedd wrote:
> On Mon, 2021-12-27 at 11:26 +0100, Ortwin Glück wrote:
>> On all 5.15 kernels the Intel Bluetooth no longer works. All was fine in 5.14.
>> Apparently the quirk is needed for this device.
>>
>> vanilla 5.15.5:
>> Bluetooth: hci0: Reading Intel version command failed (-110)
>> Bluetooth: hci0: command tx timeout
>>
>> with patch:
>> Bluetooth: hci0: Legacy ROM 2.5 revision 1.0 build 3 week 17 2014
>> Bluetooth: hci0: Intel device is already patched. patch num: 32
>>
>> Please apply to stable too.
>
> The fix for this issue is in bluetooth-next and will be merged to mainline soon.
> https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=95655456e7cee858a23793f67025765b4c4c227b
Tedd, many thx for fixing this. Next time when you fix a issue, please
include a "Link:" tag to all issue reports on the list (IOW: the message
that started this thread) and in bug trackers, as explained in
Documentation/process/submitting-patches.rst. To quote:
```
If related discussions or any other background information behind the
change can be found on the web, add 'Link:' tags pointing to it. In case
your patch fixes a bug, for example, add a tag with a URL referencing
the report in the mailing list archives or a bug tracker;
```
This concept is old, but the text was reworked recently to make this use
case for the Link: tag clearer. For details see:
https://git.kernel.org/linus/1f57bd42b77c
These link help others that want to look into the issue now or in a year
from now. There are also tools out there that rely on these links to
connect reports and fixes. Regzbot, the regression tracking bot I use,
is one such tool which I'm running (there might be others). And because
the link was missing, I now have to tell the bot manually about the fix. :-/
#regzbot fixed-by: 95655456e7cee858a2
Ciao, Thorsten
prev parent reply other threads:[~2022-01-08 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <856c5dc7-9fb4-8438-3451-7b369832056a@odi.ch>
2021-12-27 10:26 ` [PATCH] fix 5.15 init regression for Intel Bluetooth Ortwin Glück
2021-12-28 7:20 ` Thorsten Leemhuis
2021-12-28 10:46 ` Paul Menzel
2022-01-08 2:08 ` An, Tedd
2022-01-08 11:53 ` Thorsten Leemhuis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf5b69c6-532b-4c6e-c046-eaad65019e8f@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=linux-kernel@vger.kernel.org \
--cc=ortwin.glueck@logobject.ch \
--cc=tedd.an@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).