* [PATCH] fix 5.15 init regression for Intel Bluetooth [not found] <856c5dc7-9fb4-8438-3451-7b369832056a@odi.ch> @ 2021-12-27 10:26 ` Ortwin Glück 2021-12-28 7:20 ` Thorsten Leemhuis ` (2 more replies) 0 siblings, 3 replies; 5+ messages in thread From: Ortwin Glück @ 2021-12-27 10:26 UTC (permalink / raw) To: linux-kernel Cc: linux-bluetooth, Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz [-- Attachment #1: Type: text/plain, Size: 449 bytes --] Hi On all 5.15 kernels the Intel Bluetooth no longer works. All was fine in 5.14. Apparently the quirk is needed for this device. vanilla 5.15.5: Bluetooth: hci0: Reading Intel version command failed (-110) Bluetooth: hci0: command tx timeout with patch: Bluetooth: hci0: Legacy ROM 2.5 revision 1.0 build 3 week 17 2014 Bluetooth: hci0: Intel device is already patched. patch num: 32 Please apply to stable too. Thanks Ortwin [-- Attachment #2: 0001-Bluetooth-btusb-Add-init-quitk.patch --] [-- Type: text/x-patch, Size: 1434 bytes --] From fb721988425ffd40e09603a3e8b141c0b46b74e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ortwin=20Gl=C3=BCck?= <odi@odi.ch> Date: Sat, 4 Dec 2021 14:25:56 +0100 Subject: [PATCH] Bluetooth: btusb: Add init quitk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes the boot regression against 5.14: Bluetooth: hci0: Reading Intel version command failed (-110) Bluetooth: hci0: command tx timeout Signed-off-by: Ortwin Glück <odi@odi.ch> Cc: stable@vger.kernel.org --- drivers/bluetooth/btusb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 79d0db542da3..232cfcb41734 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -366,7 +366,8 @@ static const struct usb_device_id blacklist_table[] = { { USB_DEVICE(0x8087, 0x07da), .driver_info = BTUSB_CSR }, { USB_DEVICE(0x8087, 0x07dc), .driver_info = BTUSB_INTEL_COMBINED | BTUSB_INTEL_BROKEN_INITIAL_NCMD }, - { USB_DEVICE(0x8087, 0x0a2a), .driver_info = BTUSB_INTEL_COMBINED }, + { USB_DEVICE(0x8087, 0x0a2a), .driver_info = BTUSB_INTEL_COMBINED | + BTUSB_INTEL_BROKEN_INITIAL_NCMD }, { USB_DEVICE(0x8087, 0x0a2b), .driver_info = BTUSB_INTEL_COMBINED }, { USB_DEVICE(0x8087, 0x0aa7), .driver_info = BTUSB_INTEL_COMBINED }, { USB_DEVICE(0x8087, 0x0aaa), .driver_info = BTUSB_INTEL_COMBINED }, -- 2.32.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fix 5.15 init regression for Intel Bluetooth 2021-12-27 10:26 ` [PATCH] fix 5.15 init regression for Intel Bluetooth Ortwin Glück @ 2021-12-28 7:20 ` Thorsten Leemhuis 2021-12-28 10:46 ` Paul Menzel 2022-01-08 2:08 ` An, Tedd 2 siblings, 0 replies; 5+ messages in thread From: Thorsten Leemhuis @ 2021-12-28 7:20 UTC (permalink / raw) To: Ortwin Glück, linux-kernel Cc: linux-bluetooth, Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz, regressions [TLDR: I'm adding this regression to regzbot, the Linux kernel regression tracking bot; most text you find below is compiled from a few templates paragraphs some of you might have seen already.] On 27.12.21 11:26, Ortwin Glück wrote: > > On all 5.15 kernels the Intel Bluetooth no longer works. All was fine in > 5.14. > Apparently the quirk is needed for this device. > > vanilla 5.15.5: > Bluetooth: hci0: Reading Intel version command failed (-110) > Bluetooth: hci0: command tx timeout > > with patch: > Bluetooth: hci0: Legacy ROM 2.5 revision 1.0 build 3 week 17 2014 > Bluetooth: hci0: Intel device is already patched. patch num: 32 > > Please apply to stable too. Hi, this is your Linux kernel regression tracker speaking. Thanks for the report. Adding the regression mailing list to the list of recipients, as it should be in the loop for all regressions, as explained here: https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html To be sure this issue doesn't fall through the cracks unnoticed, I'm adding it to regzbot, my Linux kernel regression tracking bot: #regzbot ^introduced v5.14..v5.15 #regzbot title bluetooth: Intel Bluetooth no longer works #regzbot ignore-activity Reminder: when fixing the issue, please add a 'Link:' tag with the URL to the report (the parent of this mail) using the kernel.org redirector, as explained in 'Documentation/process/submitting-patches.rst'. Regzbot then will automatically mark the regression as resolved once the fix lands in the appropriate tree. For more details about regzbot see footer. Sending this to everyone that got the initial report, to make all aware of the tracking. I also hope that messages like this motivate people to directly get at least the regression mailing list and ideally even regzbot involved when dealing with regressions, as messages like this wouldn't be needed then. Don't worry, I'll send further messages wrt to this regression just to the lists (with a tag in the subject so people can filter them away), as long as they are intended just for regzbot. With a bit of luck no such messages will be needed anyway. Ciao, Thorsten (wearing his 'Linux kernel regression tracker' hat). P.S.: As a Linux kernel regression tracker I'm getting a lot of reports on my table. I can only look briefly into most of them. Unfortunately therefore I sometimes will get things wrong or miss something important. I hope that's not the case here; if you think it is, don't hesitate to tell me about it in a public reply. That's in everyone's interest, as what I wrote above might be misleading to everyone reading this; any suggestion I gave thus might sent someone reading this down the wrong rabbit hole, which none of us wants. BTW, I have no personal interest in this issue, which is tracked using regzbot, my Linux kernel regression tracking bot (https://linux-regtracking.leemhuis.info/regzbot/). I'm only posting this mail to get things rolling again and hence don't need to be CC on all further activities wrt to this regression. --- Additional information about regzbot: If you want to know more about regzbot, check out its web-interface, the getting start guide, and/or the references documentation: https://linux-regtracking.leemhuis.info/regzbot/ https://gitlab.com/knurd42/regzbot/-/blob/main/docs/getting_started.md https://gitlab.com/knurd42/regzbot/-/blob/main/docs/reference.md The last two documents will explain how you can interact with regzbot yourself if your want to. Hint for reporters: when reporting a regression it's in your interest to tell #regzbot about it in the report, as that will ensure the regression gets on the radar of regzbot and the regression tracker. That's in your interest, as they will make sure the report won't fall through the cracks unnoticed. Hint for developers: you normally don't need to care about regzbot once it's involved. Fix the issue as you normally would, just remember to include a 'Link:' tag to the report in the commit message, as explained in Documentation/process/submitting-patches.rst That aspect was recently was made more explicit in commit 1f57bd42b77c: https://git.kernel.org/linus/1f57bd42b77c ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fix 5.15 init regression for Intel Bluetooth 2021-12-27 10:26 ` [PATCH] fix 5.15 init regression for Intel Bluetooth Ortwin Glück 2021-12-28 7:20 ` Thorsten Leemhuis @ 2021-12-28 10:46 ` Paul Menzel 2022-01-08 2:08 ` An, Tedd 2 siblings, 0 replies; 5+ messages in thread From: Paul Menzel @ 2021-12-28 10:46 UTC (permalink / raw) To: Ortwin Glück Cc: linux-bluetooth, Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz, linux-kernel Dear Ortwin, Am 27.12.21 um 11:26 schrieb Ortwin Glück: > On all 5.15 kernels the Intel Bluetooth no longer works. All was fine in > 5.14. > Apparently the quirk is needed for this device. > > vanilla 5.15.5: > Bluetooth: hci0: Reading Intel version command failed (-110) > Bluetooth: hci0: command tx timeout > > with patch: > Bluetooth: hci0: Legacy ROM 2.5 revision 1.0 build 3 week 17 2014 > Bluetooth: hci0: Intel device is already patched. patch num: 32 > > Please apply to stable too. This has been already reported in *[PATCH] Bluetooth: Apply initial command workaround for more Intel chips* [1]. As I replied there, on what device do you experience this, and how can it be reproduced? I have a Dell Latitude E7250 with the Bluetooth device 0x0a2a, and everything works fine under Debian sid/unstable with Linux 5.15 up to 5.16-rc6. Bus 002 Device 003: ID 8087:0a2a Intel Corp. Bluetooth wireless interface Kind regards, Paul [1]: https://lore.kernel.org/linux-bluetooth/20211202162256.31837-1-tiwai@suse.de/ ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fix 5.15 init regression for Intel Bluetooth 2021-12-27 10:26 ` [PATCH] fix 5.15 init regression for Intel Bluetooth Ortwin Glück 2021-12-28 7:20 ` Thorsten Leemhuis 2021-12-28 10:46 ` Paul Menzel @ 2022-01-08 2:08 ` An, Tedd 2022-01-08 11:53 ` Thorsten Leemhuis 2 siblings, 1 reply; 5+ messages in thread From: An, Tedd @ 2022-01-08 2:08 UTC (permalink / raw) To: ortwin.glueck, linux-kernel Hi Ortwin, On Mon, 2021-12-27 at 11:26 +0100, Ortwin Glück wrote: > > Hi > > On all 5.15 kernels the Intel Bluetooth no longer works. All was fine in 5.14. > Apparently the quirk is needed for this device. > > vanilla 5.15.5: > Bluetooth: hci0: Reading Intel version command failed (-110) > Bluetooth: hci0: command tx timeout > > with patch: > Bluetooth: hci0: Legacy ROM 2.5 revision 1.0 build 3 week 17 2014 > Bluetooth: hci0: Intel device is already patched. patch num: 32 > > Please apply to stable too. > > Thanks > > Ortwin The fix for this issue is in bluetooth-next and will be merged to mainline soon. https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=95655456e7cee858a23793f67025765b4c4c227b Regards, Tedd ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fix 5.15 init regression for Intel Bluetooth 2022-01-08 2:08 ` An, Tedd @ 2022-01-08 11:53 ` Thorsten Leemhuis 0 siblings, 0 replies; 5+ messages in thread From: Thorsten Leemhuis @ 2022-01-08 11:53 UTC (permalink / raw) To: An, Tedd, ortwin.glueck, linux-kernel On 08.01.22 03:08, An, Tedd wrote: > On Mon, 2021-12-27 at 11:26 +0100, Ortwin Glück wrote: >> On all 5.15 kernels the Intel Bluetooth no longer works. All was fine in 5.14. >> Apparently the quirk is needed for this device. >> >> vanilla 5.15.5: >> Bluetooth: hci0: Reading Intel version command failed (-110) >> Bluetooth: hci0: command tx timeout >> >> with patch: >> Bluetooth: hci0: Legacy ROM 2.5 revision 1.0 build 3 week 17 2014 >> Bluetooth: hci0: Intel device is already patched. patch num: 32 >> >> Please apply to stable too. > > The fix for this issue is in bluetooth-next and will be merged to mainline soon. > https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=95655456e7cee858a23793f67025765b4c4c227b Tedd, many thx for fixing this. Next time when you fix a issue, please include a "Link:" tag to all issue reports on the list (IOW: the message that started this thread) and in bug trackers, as explained in Documentation/process/submitting-patches.rst. To quote: ``` If related discussions or any other background information behind the change can be found on the web, add 'Link:' tags pointing to it. In case your patch fixes a bug, for example, add a tag with a URL referencing the report in the mailing list archives or a bug tracker; ``` This concept is old, but the text was reworked recently to make this use case for the Link: tag clearer. For details see: https://git.kernel.org/linus/1f57bd42b77c These link help others that want to look into the issue now or in a year from now. There are also tools out there that rely on these links to connect reports and fixes. Regzbot, the regression tracking bot I use, is one such tool which I'm running (there might be others). And because the link was missing, I now have to tell the bot manually about the fix. :-/ #regzbot fixed-by: 95655456e7cee858a2 Ciao, Thorsten ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-08 11:53 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <856c5dc7-9fb4-8438-3451-7b369832056a@odi.ch> 2021-12-27 10:26 ` [PATCH] fix 5.15 init regression for Intel Bluetooth Ortwin Glück 2021-12-28 7:20 ` Thorsten Leemhuis 2021-12-28 10:46 ` Paul Menzel 2022-01-08 2:08 ` An, Tedd 2022-01-08 11:53 ` Thorsten Leemhuis
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).