* [PATCH linux-next] fs:disk-io: emove unneeded variable
@ 2021-08-25 6:27 CGEL
2021-08-25 6:38 ` Qu Wenruo
0 siblings, 1 reply; 2+ messages in thread
From: CGEL @ 2021-08-25 6:27 UTC (permalink / raw)
To: Chris Mason
Cc: Josef Bacik, David Sterba, linux-btrfs, linux-kernel,
Jing Yangyang, Zeal Robot
From: Jing Yangyang <jing.yangyang@zte.com.cn>
Eliminate the following coccicheck warning:
./fs/btrfs/disk-io.c:4630: 5-8:
Unneeded variable "ret". Return "0" on line 4638
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
---
fs/btrfs/disk-io.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index a66e2cb..e531c4c 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -4627,7 +4627,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
struct rb_node *node;
struct btrfs_delayed_ref_root *delayed_refs;
struct btrfs_delayed_ref_node *ref;
- int ret = 0;
delayed_refs = &trans->delayed_refs;
@@ -4635,7 +4634,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
if (atomic_read(&delayed_refs->num_entries) == 0) {
spin_unlock(&delayed_refs->lock);
btrfs_debug(fs_info, "delayed_refs has NO entry");
- return ret;
+ return 0;
}
while ((node = rb_first_cached(&delayed_refs->href_root)) != NULL) {
@@ -4698,7 +4697,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
spin_unlock(&delayed_refs->lock);
- return ret;
+ return 0;
}
static void btrfs_destroy_delalloc_inodes(struct btrfs_root *root)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] fs:disk-io: emove unneeded variable
2021-08-25 6:27 [PATCH linux-next] fs:disk-io: emove unneeded variable CGEL
@ 2021-08-25 6:38 ` Qu Wenruo
0 siblings, 0 replies; 2+ messages in thread
From: Qu Wenruo @ 2021-08-25 6:38 UTC (permalink / raw)
To: CGEL, Chris Mason
Cc: Josef Bacik, David Sterba, linux-btrfs, linux-kernel,
Jing Yangyang, Zeal Robot
On 2021/8/25 下午2:27, CGEL wrote:
> From: Jing Yangyang <jing.yangyang@zte.com.cn>
>
> Eliminate the following coccicheck warning:
> ./fs/btrfs/disk-io.c:4630: 5-8:
> Unneeded variable "ret". Return "0" on line 4638
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
There is a big BUG_ON() in the code, indicating missing error handling.
Ignoring it and just removing the @ret is never a real fix, please add
proper error handling first.
Thanks,
Qu
> ---
> fs/btrfs/disk-io.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index a66e2cb..e531c4c 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -4627,7 +4627,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
> struct rb_node *node;
> struct btrfs_delayed_ref_root *delayed_refs;
> struct btrfs_delayed_ref_node *ref;
> - int ret = 0;
>
> delayed_refs = &trans->delayed_refs;
>
> @@ -4635,7 +4634,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
> if (atomic_read(&delayed_refs->num_entries) == 0) {
> spin_unlock(&delayed_refs->lock);
> btrfs_debug(fs_info, "delayed_refs has NO entry");
> - return ret;
> + return 0;
> }
>
> while ((node = rb_first_cached(&delayed_refs->href_root)) != NULL) {
> @@ -4698,7 +4697,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
>
> spin_unlock(&delayed_refs->lock);
>
> - return ret;
> + return 0;
> }
>
> static void btrfs_destroy_delalloc_inodes(struct btrfs_root *root)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-25 6:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 6:27 [PATCH linux-next] fs:disk-io: emove unneeded variable CGEL
2021-08-25 6:38 ` Qu Wenruo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).