* Build error: ‘EM_RISCV’ undeclared
@ 2021-09-12 10:29 Stefan Wahren
2021-09-13 2:49 ` Miles Chen
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Wahren @ 2021-09-12 10:29 UTC (permalink / raw)
To: Jisheng Zhang, open list, Palmer Dabbelt
Hi,
i tried to compile current torvalds tree
("78e709522d2c012cb0daad2e668506637bffb7c2") for arm/multi_v7_defconfig
and get the following build issue:
UPD include/generated/utsrelease.h
scripts/sorttable.c: In function ‘do_file’:
scripts/sorttable.c:352:7: error: ‘EM_RISCV’ undeclared (first use in
this function)
case EM_RISCV:
^
scripts/sorttable.c:352:7: note: each undeclared identifier is reported
only once for each function it appears in
I assume this is caused by:
54fed35fd3939398be292e4090b0b1c5ff2238b4 ("riscv: Enable
BUILDTIME_TABLE_SORT")
Best regards
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Build error: ‘EM_RISCV’ undeclared
2021-09-12 10:29 Build error: ‘EM_RISCV’ undeclared Stefan Wahren
@ 2021-09-13 2:49 ` Miles Chen
2021-09-24 9:30 ` Jon Hunter
0 siblings, 1 reply; 7+ messages in thread
From: Miles Chen @ 2021-09-13 2:49 UTC (permalink / raw)
To: Stefan Wahren, Jisheng Zhang, open list, Palmer Dabbelt
On Sun, 2021-09-12 at 12:29 +0200, Stefan Wahren wrote:
> Hi,
>
> i tried to compile current torvalds tree
> ("78e709522d2c012cb0daad2e668506637bffb7c2") for
> arm/multi_v7_defconfig
> and get the following build issue:
>
> UPD include/generated/utsrelease.h
> scripts/sorttable.c: In function ‘do_file’:
> scripts/sorttable.c:352:7: error: ‘EM_RISCV’ undeclared (first use in
> this function)
> case EM_RISCV:
> ^
> scripts/sorttable.c:352:7: note: each undeclared identifier is
> reported
> only once for each function it appears in
>
> I assume this is caused by:
>
> 54fed35fd3939398be292e4090b0b1c5ff2238b4 ("riscv: Enable
> BUILDTIME_TABLE_SORT")
I hit this error too. I add the follow conditional EM_RISCV
definition in sorttable.c to build pass (arm64/defconfig).
I will submit a patch out.
diff --git a/scripts/sorttable.c b/scripts/sorttable.c
index f355869c65cd..6ee4fa882919 100644
--- a/scripts/sorttable.c
+++ b/scripts/sorttable.c
@@ -54,6 +54,10 @@
#define EM_ARCV2 195
#endif
+#ifndef EM_RISCV
+#define EM_RISCV 243
+#endif
+
>
> Best regards
> Stefan
>
>
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: Build error: ‘EM_RISCV’ undeclared
2021-09-13 2:49 ` Miles Chen
@ 2021-09-24 9:30 ` Jon Hunter
2021-09-24 12:55 ` Jon Hunter
0 siblings, 1 reply; 7+ messages in thread
From: Jon Hunter @ 2021-09-24 9:30 UTC (permalink / raw)
To: Miles Chen, Stefan Wahren, Jisheng Zhang, open list, Palmer Dabbelt
Cc: linux-tegra
On 13/09/2021 03:49, Miles Chen wrote:
> On Sun, 2021-09-12 at 12:29 +0200, Stefan Wahren wrote:
>> Hi,
>>
>> i tried to compile current torvalds tree
>> ("78e709522d2c012cb0daad2e668506637bffb7c2") for
>> arm/multi_v7_defconfig
>> and get the following build issue:
>>
>> UPD include/generated/utsrelease.h
>> scripts/sorttable.c: In function ‘do_file’:
>> scripts/sorttable.c:352:7: error: ‘EM_RISCV’ undeclared (first use in
>> this function)
>> case EM_RISCV:
>> ^
>> scripts/sorttable.c:352:7: note: each undeclared identifier is
>> reported
>> only once for each function it appears in
>>
>> I assume this is caused by:
>>
>> 54fed35fd3939398be292e4090b0b1c5ff2238b4 ("riscv: Enable
>> BUILDTIME_TABLE_SORT")
>
> I hit this error too. I add the follow conditional EM_RISCV
> definition in sorttable.c to build pass (arm64/defconfig).
>
> I will submit a patch out.
>
> diff --git a/scripts/sorttable.c b/scripts/sorttable.c
> index f355869c65cd..6ee4fa882919 100644
> --- a/scripts/sorttable.c
> +++ b/scripts/sorttable.c
> @@ -54,6 +54,10 @@
> #define EM_ARCV2 195
> #endif
>
> +#ifndef EM_RISCV
> +#define EM_RISCV 243
> +#endif
> +
This is still broken in the mainline. Any plans to get this fix merged
there? I believe it has now been broken for nearly 2 weeks.
Thanks!
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Build error: ‘EM_RISCV’ undeclared
2021-09-24 9:30 ` Jon Hunter
@ 2021-09-24 12:55 ` Jon Hunter
2021-09-24 18:05 ` Stefan Wahren
0 siblings, 1 reply; 7+ messages in thread
From: Jon Hunter @ 2021-09-24 12:55 UTC (permalink / raw)
To: miles.chen, Stefan Wahren, Jisheng Zhang, open list, Palmer Dabbelt
Cc: linux-tegra
On 24/09/2021 13:15, miles.chen@mediatek.com wrote:
> From: Jon Hunter <jonathanh@nvidia.com>
>
>
>> This is still broken in the mainline. Any plans to get this fix merged
>> there? I believe it has now been broken for nearly 2 weeks.
>
> the fix [1] is in linux-next now, thanks.
Yes I know that. However, we need it in the mainline. It has been broken
for nearly 2 weeks now and all our automation for mainline is not
running because we cannot build. Please get this fix into mainline as
soon as possible.
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Build error: ‘EM_RISCV’ undeclared
2021-09-24 12:55 ` Jon Hunter
@ 2021-09-24 18:05 ` Stefan Wahren
2021-09-24 19:01 ` Jon Hunter
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Wahren @ 2021-09-24 18:05 UTC (permalink / raw)
To: Jon Hunter, miles.chen, Jisheng Zhang, open list, Palmer Dabbelt
Cc: linux-tegra
Hi,
Am 24.09.21 um 14:55 schrieb Jon Hunter:
>
>
> On 24/09/2021 13:15, miles.chen@mediatek.com wrote:
>> From: Jon Hunter <jonathanh@nvidia.com>
>>
>>
>>> This is still broken in the mainline. Any plans to get this fix
>>> merged there? I believe it has now been broken for nearly 2 weeks.
>>
>> the fix [1] is in linux-next now, thanks.
>
> Yes I know that. However, we need it in the mainline. It has been
> broken for nearly 2 weeks now and all our automation for mainline is
> not running because we cannot build. Please get this fix into mainline
> as soon as possible.
as stated in [1], you can try to update you build environment.
[1] -
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20210924&id=fe7118f4742f8c26e532c63bb498283b73e24d7d
>
> Jon
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Build error: ‘EM_RISCV’ undeclared
2021-09-24 18:05 ` Stefan Wahren
@ 2021-09-24 19:01 ` Jon Hunter
2021-09-24 19:42 ` Randy Dunlap
0 siblings, 1 reply; 7+ messages in thread
From: Jon Hunter @ 2021-09-24 19:01 UTC (permalink / raw)
To: Stefan Wahren, miles.chen, Jisheng Zhang, open list, Palmer Dabbelt
Cc: linux-tegra
On 24/09/2021 19:05, Stefan Wahren wrote:
> Hi,
>
> Am 24.09.21 um 14:55 schrieb Jon Hunter:
>>
>>
>> On 24/09/2021 13:15, miles.chen@mediatek.com wrote:
>>> From: Jon Hunter <jonathanh@nvidia.com>
>>>
>>>
>>>> This is still broken in the mainline. Any plans to get this fix
>>>> merged there? I believe it has now been broken for nearly 2 weeks.
>>>
>>> the fix [1] is in linux-next now, thanks.
>>
>> Yes I know that. However, we need it in the mainline. It has been
>> broken for nearly 2 weeks now and all our automation for mainline is
>> not running because we cannot build. Please get this fix into mainline
>> as soon as possible.
>
> as stated in [1], you can try to update you build environment.
These are farm build machines so not that easy or quick to update. Given
the change that introduced the breakage is in the mainline, the fix also
need to be merged into the mainline. Otherwise we need to revert the
initial change.
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Build error: ‘EM_RISCV’ undeclared
2021-09-24 19:01 ` Jon Hunter
@ 2021-09-24 19:42 ` Randy Dunlap
0 siblings, 0 replies; 7+ messages in thread
From: Randy Dunlap @ 2021-09-24 19:42 UTC (permalink / raw)
To: Jon Hunter, Stefan Wahren, miles.chen, Jisheng Zhang, open list,
Palmer Dabbelt, Andrew Morton
Cc: linux-tegra
On 9/24/21 12:01 PM, Jon Hunter wrote:
>
> On 24/09/2021 19:05, Stefan Wahren wrote:
>> Hi,
>>
>> Am 24.09.21 um 14:55 schrieb Jon Hunter:
>>>
>>>
>>> On 24/09/2021 13:15, miles.chen@mediatek.com wrote:
>>>> From: Jon Hunter <jonathanh@nvidia.com>
>>>>
>>>>
>>>>> This is still broken in the mainline. Any plans to get this fix
>>>>> merged there? I believe it has now been broken for nearly 2 weeks.
>>>>
>>>> the fix [1] is in linux-next now, thanks.
so who merged the patch [1] into linux-next? Andrew?
Seems to me that Andrew should be cc-ed here [added].
>>> Yes I know that. However, we need it in the mainline. It has been
>>> broken for nearly 2 weeks now and all our automation for mainline is
>>> not running because we cannot build. Please get this fix into mainline
>>> as soon as possible.
>>
>> as stated in [1], you can try to update you build environment.
>
> These are farm build machines so not that easy or quick to update. Given the change that introduced the breakage is in the mainline, the fix also need to be merged into the mainline. Otherwise we need to revert the initial change.
Yes.
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-09-24 19:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-12 10:29 Build error: ‘EM_RISCV’ undeclared Stefan Wahren
2021-09-13 2:49 ` Miles Chen
2021-09-24 9:30 ` Jon Hunter
2021-09-24 12:55 ` Jon Hunter
2021-09-24 18:05 ` Stefan Wahren
2021-09-24 19:01 ` Jon Hunter
2021-09-24 19:42 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).