linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] gpio: Add support for the PCAL9535
@ 2020-06-15  8:28 Jan Kiszka
  2020-06-15  8:28 ` [PATCH v2 1/2] dt-bindings: gpio: pca953x: add nxp,pcal9535 Jan Kiszka
  2020-06-15  8:28 ` [PATCH v2 2/2] gpio: pca953x: Add support for the PCAL9535 Jan Kiszka
  0 siblings, 2 replies; 4+ messages in thread
From: Jan Kiszka @ 2020-06-15  8:28 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski; +Cc: linux-gpio, linux-kernel

Changes in v2:
 - add dt binding update

Jan

Jan Kiszka (2):
  dt-bindings: gpio: pca953x: add nxp,pcal9535
  gpio: pca953x: Add support for the PCAL9535

 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
 drivers/gpio/gpio-pca953x.c                             | 1 +
 2 files changed, 2 insertions(+)

-- 
2.26.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/2] dt-bindings: gpio: pca953x: add nxp,pcal9535
  2020-06-15  8:28 [PATCH v2 0/2] gpio: Add support for the PCAL9535 Jan Kiszka
@ 2020-06-15  8:28 ` Jan Kiszka
  2020-06-15  8:28 ` [PATCH v2 2/2] gpio: pca953x: Add support for the PCAL9535 Jan Kiszka
  1 sibling, 0 replies; 4+ messages in thread
From: Jan Kiszka @ 2020-06-15  8:28 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski; +Cc: linux-gpio, linux-kernel

From: Jan Kiszka <jan.kiszka@siemens.com>

The NXP PCAL9535 is an extended variant of the PCA9535.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
index dab537c20def..3126c3817e2a 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
@@ -19,6 +19,7 @@ Required properties:
 	nxp,pca9698
 	nxp,pcal6416
 	nxp,pcal6524
+	nxp,pcal9535
 	nxp,pcal9555a
 	maxim,max7310
 	maxim,max7312
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] gpio: pca953x: Add support for the PCAL9535
  2020-06-15  8:28 [PATCH v2 0/2] gpio: Add support for the PCAL9535 Jan Kiszka
  2020-06-15  8:28 ` [PATCH v2 1/2] dt-bindings: gpio: pca953x: add nxp,pcal9535 Jan Kiszka
@ 2020-06-15  8:28 ` Jan Kiszka
  2020-06-15 13:14   ` Andy Shevchenko
  1 sibling, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2020-06-15  8:28 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski; +Cc: linux-gpio, linux-kernel

From: Jan Kiszka <jan.kiszka@siemens.com>

The PCAL9535 [1] is compatible to the PCA9535. Additionally, it comes
with interrupt support and input latching. Other features are not
supported by the GPIO subsystem.

[1] https://www.nxp.com/docs/en/data-sheet/PCAL9535A.pdf

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 drivers/gpio/gpio-pca953x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 1fca8dd7824f..34d635e51dda 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -1131,6 +1131,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
 	{ .compatible = "nxp,pca9505", .data = OF_953X(40, PCA_INT), },
 	{ .compatible = "nxp,pca9534", .data = OF_953X( 8, PCA_INT), },
 	{ .compatible = "nxp,pca9535", .data = OF_953X(16, PCA_INT), },
+	{ .compatible = "nxp,pcal9535", .data = OF_953X(16, PCA_LATCH_INT), },
 	{ .compatible = "nxp,pca9536", .data = OF_953X( 4, 0), },
 	{ .compatible = "nxp,pca9537", .data = OF_953X( 4, PCA_INT), },
 	{ .compatible = "nxp,pca9538", .data = OF_953X( 8, PCA_INT), },
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 2/2] gpio: pca953x: Add support for the PCAL9535
  2020-06-15  8:28 ` [PATCH v2 2/2] gpio: pca953x: Add support for the PCAL9535 Jan Kiszka
@ 2020-06-15 13:14   ` Andy Shevchenko
  0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2020-06-15 13:14 UTC (permalink / raw)
  To: Jan Kiszka
  Cc: Linus Walleij, Bartosz Golaszewski, open list:GPIO SUBSYSTEM,
	Linux Kernel Mailing List

On Mon, Jun 15, 2020 at 11:46 AM Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> The PCAL9535 [1] is compatible to the PCA9535. Additionally, it comes
> with interrupt support and input latching. Other features are not
> supported by the GPIO subsystem.

Same comments as per v1.

> [1] https://www.nxp.com/docs/en/data-sheet/PCAL9535A.pdf

Datasheet: ...

...

> @@ -1131,6 +1131,7 @@ static const struct of_device_id pca953x_dt_ids[] = {

i2c ID table

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-06-15 13:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-15  8:28 [PATCH v2 0/2] gpio: Add support for the PCAL9535 Jan Kiszka
2020-06-15  8:28 ` [PATCH v2 1/2] dt-bindings: gpio: pca953x: add nxp,pcal9535 Jan Kiszka
2020-06-15  8:28 ` [PATCH v2 2/2] gpio: pca953x: Add support for the PCAL9535 Jan Kiszka
2020-06-15 13:14   ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).