[PATCH v2 0/1] arm64: defconfig: Enable Librem 5 hardware

[PATCH v2 0/1] arm64: defconfig: Enable Librem 5 hardware

[Guido Günther]

This series enables components found on Purism's Librem 5
that are available in mainline.

- changes from v1
  - As per review comments from Krzysztof Kozlowski
    https://lore.kernel.org/linux-arm-kernel/CAJKOXPdEwiSTg+cMes_wes5oz2F1qEexsus6iHenuLs9SAXk6g@mail.gmail.com/
    - Squash config changes into a single commit
  - Add touch controller

Patches are on top of Shawn's imx/defconfig

Guido Günther (1):
  arm64: defconfig: Enable more Librem 5 hardware

 arch/arm64/configs/defconfig | 9 +++++++++
 1 file changed, 9 insertions(+)

-- 
2.29.2

[PATCH v2 1/1] arm64: defconfig: Enable more Librem 5 hardware

[Guido Günther]

This enables

- CONFIG_BATTERY_MAX17042: battery chip
- CONFIG_CHARGER_BQ25980: charge controller
- CONFIG_DRM_PANEL_MANTIX_MLAF057WE5: LCD panel
- CONFIG_IMX_DCSS: 2nd dislay controller
- CONFIG_LEDS_LM3692X: LCD backlight
- CONFIG_REGULATOR_TPS65132: regulator for the LCD panel
- CONFIG_TOUCHSCREEN_EDT_FT5X06: touch controller
- CONFIG_TYPEC_TPS6598X: USB PD controller
- CONFIG_VCNL4000: ambient light and proximiry sensor

as modules.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
 arch/arm64/configs/defconfig | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 270d326d5f28..9c0a9e014f28 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -381,6 +381,7 @@ CONFIG_KEYBOARD_IMX_SC_KEY=m
 CONFIG_KEYBOARD_CROS_EC=y
 CONFIG_INPUT_TOUCHSCREEN=y
 CONFIG_TOUCHSCREEN_ATMEL_MXT=m
+CONFIG_TOUCHSCREEN_EDT_FT5X06=m
 CONFIG_INPUT_MISC=y
 CONFIG_INPUT_PM8941_PWRKEY=y
 CONFIG_INPUT_PM8XXX_VIBRATOR=m
@@ -521,6 +522,8 @@ CONFIG_POWER_RESET_SYSCON=y
 CONFIG_SYSCON_REBOOT_MODE=y
 CONFIG_BATTERY_SBS=m
 CONFIG_BATTERY_BQ27XXX=y
+CONFIG_BATTERY_MAX17042=m
+CONFIG_CHARGER_BQ25980=m
 CONFIG_SENSORS_ARM_SCPI=y
 CONFIG_SENSORS_LM90=m
 CONFIG_SENSORS_PWM_FAN=m
@@ -595,6 +598,7 @@ CONFIG_REGULATOR_QCOM_SMD_RPM=y
 CONFIG_REGULATOR_QCOM_SPMI=y
 CONFIG_REGULATOR_RK808=y
 CONFIG_REGULATOR_S2MPS11=y
+CONFIG_REGULATOR_TPS65132=m
 CONFIG_REGULATOR_VCTRL=m
 CONFIG_RC_CORE=m
 CONFIG_RC_DECODERS=y
@@ -655,6 +659,7 @@ CONFIG_DRM_MSM=m
 CONFIG_DRM_TEGRA=m
 CONFIG_DRM_PANEL_LVDS=m
 CONFIG_DRM_PANEL_SIMPLE=m
+CONFIG_DRM_PANEL_MANTIX_MLAF057WE51=m
 CONFIG_DRM_PANEL_RAYDIUM_RM67191=m
 CONFIG_DRM_PANEL_SITRONIX_ST7703=m
 CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA=m
@@ -669,6 +674,7 @@ CONFIG_DRM_I2C_ADV7511=m
 CONFIG_DRM_I2C_ADV7511_AUDIO=y
 CONFIG_DRM_DW_HDMI_AHB_AUDIO=m
 CONFIG_DRM_DW_HDMI_CEC=m
+CONFIG_DRM_IMX_DCSS=m
 CONFIG_DRM_VC4=m
 CONFIG_DRM_ETNAVIV=m
 CONFIG_DRM_HISI_HIBMC=m
@@ -777,6 +783,7 @@ CONFIG_TYPEC=m
 CONFIG_TYPEC_TCPM=m
 CONFIG_TYPEC_FUSB302=m
 CONFIG_TYPEC_HD3SS3220=m
+CONFIG_TYPEC_TPS6598X=m
 CONFIG_MMC=y
 CONFIG_MMC_BLOCK_MINORS=32
 CONFIG_MMC_ARMMMCI=y
@@ -806,6 +813,7 @@ CONFIG_MMC_SDHCI_AM654=y
 CONFIG_MMC_OWL=y
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=y
+CONFIG_LEDS_LM3692X=m
 CONFIG_LEDS_GPIO=y
 CONFIG_LEDS_PWM=y
 CONFIG_LEDS_SYSCON=y
@@ -980,6 +988,7 @@ CONFIG_IIO_CROS_EC_SENSORS_CORE=m
 CONFIG_IIO_CROS_EC_SENSORS=m
 CONFIG_IIO_CROS_EC_LIGHT_PROX=m
 CONFIG_SENSORS_ISL29018=m
+CONFIG_VCNL4000=m
 CONFIG_IIO_CROS_EC_BARO=m
 CONFIG_MPL3115=m
 CONFIG_PWM=y
-- 
2.29.2

Re: [PATCH v2 1/1] arm64: defconfig: Enable more Librem 5 hardware

[Geert Uytterhoeven]

Hi Guido,

Thanks for your patch!

On Fri, Nov 27, 2020 at 5:42 PM Guido Günther <agx@sigxcpu.org> wrote:
> This enables
>
> - CONFIG_BATTERY_MAX17042: battery chip
> - CONFIG_CHARGER_BQ25980: charge controller
> - CONFIG_DRM_PANEL_MANTIX_MLAF057WE5: LCD panel
> - CONFIG_IMX_DCSS: 2nd dislay controller

display

> - CONFIG_LEDS_LM3692X: LCD backlight
> - CONFIG_REGULATOR_TPS65132: regulator for the LCD panel
> - CONFIG_TOUCHSCREEN_EDT_FT5X06: touch controller
> - CONFIG_TYPEC_TPS6598X: USB PD controller
> - CONFIG_VCNL4000: ambient light and proximiry sensor

proximity

>
> as modules.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 1/1] arm64: defconfig: Enable more Librem 5 hardware

[Guido Günther]

Hi,
On Fri, Nov 27, 2020 at 05:45:03PM +0100, Geert Uytterhoeven wrote:
> Hi Guido,
> 
> Thanks for your patch!
> 
> On Fri, Nov 27, 2020 at 5:42 PM Guido Günther <agx@sigxcpu.org> wrote:
> > This enables
> >
> > - CONFIG_BATTERY_MAX17042: battery chip
> > - CONFIG_CHARGER_BQ25980: charge controller
> > - CONFIG_DRM_PANEL_MANTIX_MLAF057WE5: LCD panel
> > - CONFIG_IMX_DCSS: 2nd dislay controller
> 
> display
> 
> > - CONFIG_LEDS_LM3692X: LCD backlight
> > - CONFIG_REGULATOR_TPS65132: regulator for the LCD panel
> > - CONFIG_TOUCHSCREEN_EDT_FT5X06: touch controller
> > - CONFIG_TYPEC_TPS6598X: USB PD controller
> > - CONFIG_VCNL4000: ambient light and proximiry sensor
> 
> proximity

Both fixed in v2 - odd that checkpatch didn't scream.
Thanks!
 -- Guido

> 
> >
> > as modules.
> >
> > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

Re: [PATCH v2 0/1] arm64: defconfig: Enable Librem 5 hardware

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

Hi!

> This series enables components found on Purism's Librem 5
> that are available in mainline.
> 
> - changes from v1
>   - As per review comments from Krzysztof Kozlowski
>     https://lore.kernel.org/linux-arm-kernel/CAJKOXPdEwiSTg+cMes_wes5oz2F1qEexsus6iHenuLs9SAXk6g@mail.gmail.com/
>     - Squash config changes into a single commit
>   - Add touch controller
> 
> Patches are on top of Shawn's imx/defconfig

Thanks for bringing support for your hardware to the mainline.

Can I ask phone-devel@vger.kernel.org to be cc-ed for phone-related
changes?

How complete is the support?

In particular, what interface do you use to configure audio routing
for the modem?

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH v2 0/1] arm64: defconfig: Enable Librem 5 hardware

[Guido Günther]

Hi Pavel,
On Fri, Nov 27, 2020 at 09:09:08PM +0100, Pavel Machek wrote:
> Hi!
> 
> > This series enables components found on Purism's Librem 5
> > that are available in mainline.
> > 
> > - changes from v1
> >   - As per review comments from Krzysztof Kozlowski
> >     https://lore.kernel.org/linux-arm-kernel/CAJKOXPdEwiSTg+cMes_wes5oz2F1qEexsus6iHenuLs9SAXk6g@mail.gmail.com/
> >     - Squash config changes into a single commit
> >   - Add touch controller
> > 
> > Patches are on top of Shawn's imx/defconfig
> 
> Thanks for bringing support for your hardware to the mainline.
> 
> Can I ask phone-devel@vger.kernel.org to be cc-ed for phone-related
> changes?

Good point. Done with v3.

> How complete is the support?

The components enabled should work in 5.11 (there's some LCD/DSI patches
in flight (that's why i did not send the corresponding DT addition yet)
and we need to submit a DT for Evergreen (imx8mq-librem5r4).

https://git.sigxcpu.org/cgit/talks/2020-debconf-mobile/plain/talk.pdf

is a bit outdated but has some numbers starting on page 24.

> In particular, what interface do you use to configure audio routing
> for the modem?

https://salsa.debian.org/DebianOnMobile-team/callaudiod manages that.

Cheers,
 -- Guido

> 
> Best regards,
> 								Pavel
> -- 
> http://www.livejournal.com/~pavelmachek

Re: [PATCH v2 0/1] arm64: defconfig: Enable Librem 5 hardware

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]

Hi!

> > > This series enables components found on Purism's Librem 5
> > > that are available in mainline.
> > > 
> > > - changes from v1
> > >   - As per review comments from Krzysztof Kozlowski
> > >     https://lore.kernel.org/linux-arm-kernel/CAJKOXPdEwiSTg+cMes_wes5oz2F1qEexsus6iHenuLs9SAXk6g@mail.gmail.com/
> > >     - Squash config changes into a single commit
> > >   - Add touch controller
> > > 
> > > Patches are on top of Shawn's imx/defconfig
> > 
> > Thanks for bringing support for your hardware to the mainline.
> > 
> > Can I ask phone-devel@vger.kernel.org to be cc-ed for phone-related
> > changes?
> 
> Good point. Done with v3.
> 
> > How complete is the support?
> 
> The components enabled should work in 5.11 (there's some LCD/DSI patches
> in flight (that's why i did not send the corresponding DT addition yet)
> and we need to submit a DT for Evergreen (imx8mq-librem5r4).
> 
> https://git.sigxcpu.org/cgit/talks/2020-debconf-mobile/plain/talk.pdf
> 
> is a bit outdated but has some numbers starting on page 24.

Thanks for pointer :-).

> > In particular, what interface do you use to configure audio routing
> > for the modem?
> 
> https://salsa.debian.org/DebianOnMobile-team/callaudiod manages
> > that.

Does kernel provide mixer interface for callaudiod to do its job?

Best regards,

								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH v2 0/1] arm64: defconfig: Enable Librem 5 hardware

[Guido Günther]

Hi Pavel,
On Sat, Nov 28, 2020 at 09:58:48PM +0100, Pavel Machek wrote:
> Hi!
> 
> > > > This series enables components found on Purism's Librem 5
> > > > that are available in mainline.
> > > > 
> > > > - changes from v1
> > > >   - As per review comments from Krzysztof Kozlowski
> > > >     https://lore.kernel.org/linux-arm-kernel/CAJKOXPdEwiSTg+cMes_wes5oz2F1qEexsus6iHenuLs9SAXk6g@mail.gmail.com/
> > > >     - Squash config changes into a single commit
> > > >   - Add touch controller
> > > > 
> > > > Patches are on top of Shawn's imx/defconfig
> > > 
> > > Thanks for bringing support for your hardware to the mainline.
> > > 
> > > Can I ask phone-devel@vger.kernel.org to be cc-ed for phone-related
> > > changes?
> > 
> > Good point. Done with v3.
> > 
> > > How complete is the support?
> > 
> > The components enabled should work in 5.11 (there's some LCD/DSI patches
> > in flight (that's why i did not send the corresponding DT addition yet)
> > and we need to submit a DT for Evergreen (imx8mq-librem5r4).
> > 
> > https://git.sigxcpu.org/cgit/talks/2020-debconf-mobile/plain/talk.pdf
> > 
> > is a bit outdated but has some numbers starting on page 24.
> 
> Thanks for pointer :-).
> 
> > > In particular, what interface do you use to configure audio routing
> > > for the modem?
> > 
> > https://salsa.debian.org/DebianOnMobile-team/callaudiod manages
> > > that.
> 
> Does kernel provide mixer interface for callaudiod to do its job?

callaudiod handles selecting e.g. earpiece vs. speaker by selecting the
right pulseaudio ports (it's invoked by calls (the phone call handling
application via DBus) and only relies on the codec being an alsa
device and hence handled by pulseaudio/alsa-ucm.

Wys (https://source.puri.sm/Librem5/wys) manages the routing between the
modem and codec by listening to ModemManager's state and connecting audio
source and sink (again solely via pulsaudio so again just relying on
modem and codec being alsa devices). Since the modem is not part of the
SoC on the Librem 5 it's a completely separate device.

Cheers,
 -- Guido


> 
> Best regards,
> 
> 								Pavel
> -- 
> http://www.livejournal.com/~pavelmachek

Re: [PATCH v2 0/1] arm64: defconfig: Enable Librem 5 hardware

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1937 bytes --]

Hi!

> > > > > Patches are on top of Shawn's imx/defconfig
> > > > 
> > > > Thanks for bringing support for your hardware to the mainline.
> > > > 
> > > > Can I ask phone-devel@vger.kernel.org to be cc-ed for phone-related
> > > > changes?
> > > 
> > > Good point. Done with v3.
> > > 
> > > > How complete is the support?
> > > 
> > > The components enabled should work in 5.11 (there's some LCD/DSI patches
> > > in flight (that's why i did not send the corresponding DT addition yet)
> > > and we need to submit a DT for Evergreen (imx8mq-librem5r4).
> > > 
> > > https://git.sigxcpu.org/cgit/talks/2020-debconf-mobile/plain/talk.pdf
> > > 
> > > is a bit outdated but has some numbers starting on page 24.
> > 
> > Thanks for pointer :-).
> > 
> > > > In particular, what interface do you use to configure audio routing
> > > > for the modem?
> > > 
> > > https://salsa.debian.org/DebianOnMobile-team/callaudiod manages
> > > > that.
> > 
> > Does kernel provide mixer interface for callaudiod to do its job?
> 
> callaudiod handles selecting e.g. earpiece vs. speaker by selecting the
> right pulseaudio ports (it's invoked by calls (the phone call handling
> application via DBus) and only relies on the codec being an alsa
> device and hence handled by pulseaudio/alsa-ucm.
> 
> Wys (https://source.puri.sm/Librem5/wys) manages the routing between the
> modem and codec by listening to ModemManager's state and connecting audio
> source and sink (again solely via pulsaudio so again just relying on
> modem and codec being alsa devices). Since the modem is not part of the
> SoC on the Librem 5 it's a completely separate device.

Aha, yep, sorry -- I forgot. I was hoping to copy solution for Librem
5 to Droid 4, but that won't work, as Droid 4 is doing audio in
hardware, while Librem does it in wys.

Best regards,

								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[PATCH v2 0/1] arm64: defconfig: Enable Librem 5 hardware

[Guido Günther]

This series enables components found on Purism's Librem 5
that are available in mainline.

- changes from v2
  - As per review comments from Geert Uytterhoeven
    https://lore.kernel.org/lkml/CAMuHMdUK3gbHwR94BcjRBkNvdpQSJrMn0itrs65Ay5KqUCA-Hg@mail.gmail.com/
    - Fix commit messages typos
  - Add GNSS receiver and IMU

- changes from v1
  - As per review comments from Krzysztof Kozlowski
    https://lore.kernel.org/linux-arm-kernel/CAJKOXPdEwiSTg+cMes_wes5oz2F1qEexsus6iHenuLs9SAXk6g@mail.gmail.com/
    - Squash config changes into a single commit
  - Add touch controller

Patches are on top of Shawn's imx/defconfig

Guido Günther (1):
  arm64: defconfig: Enable more Librem 5 hardware

 arch/arm64/configs/defconfig | 12 ++++++++++++
 1 file changed, 12 insertions(+)

-- 
2.29.2