linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/5] drm: Adjust end of block comment
@ 2021-04-21 19:46 Beatriz Martins de Carvalho
  2021-04-21 19:46 ` [PATCH 1/5] drm: drm_atomic.c: " Beatriz Martins de Carvalho
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Beatriz Martins de Carvalho @ 2021-04-21 19:46 UTC (permalink / raw)
  To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel
  Cc: melissa.srw, dri-devel, linux-kernel, outreachy-kernel

Add a new line with */ on the last line of a block comment to follow 
the Linux kernel coding conventions. 
Problem found by checkpatch.
in tree dpu/drm

Beatriz Martins de Carvalho (5):
  drm: drm_atomic.c: Adjust end of block comment
  drm: drm_auth.c: Adjust end of block comment
  drm: drm_bufs.c: Adjust end of block comment
  drm: drm_connector.c: Adjust end of block comment
  drm: drm_context.c: Adjust end of block comment

 drivers/gpu/drm/drm_atomic.c    | 3 ++-
 drivers/gpu/drm/drm_auth.c      | 3 ++-
 drivers/gpu/drm/drm_bufs.c      | 3 ++-
 drivers/gpu/drm/drm_connector.c | 9 ++++++---
 drivers/gpu/drm/drm_context.c   | 3 ++-
 5 files changed, 14 insertions(+), 7 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/5] drm: drm_atomic.c: Adjust end of block comment
  2021-04-21 19:46 [PATCH 0/5] drm: Adjust end of block comment Beatriz Martins de Carvalho
@ 2021-04-21 19:46 ` Beatriz Martins de Carvalho
  2021-04-21 19:46 ` [PATCH 2/5] drm: drm_auth.c: " Beatriz Martins de Carvalho
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Beatriz Martins de Carvalho @ 2021-04-21 19:46 UTC (permalink / raw)
  To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel
  Cc: melissa.srw, dri-devel, linux-kernel, outreachy-kernel

Add a new line with */ on the last line of a block comment to follow the
Linux kernel coding conventions.
Problem found by checkpatch.

Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
---
 drivers/gpu/drm/drm_atomic.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 46dceb51c90f..e42d9fc5d9ff 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -385,7 +385,8 @@ static int drm_atomic_crtc_check(const struct drm_crtc_state *old_crtc_state,
 
 	/* The state->enable vs. state->mode_blob checks can be WARN_ON,
 	 * as this is a kernel-internal detail that userspace should never
-	 * be able to trigger. */
+	 * be able to trigger.
+	 */
 	if (drm_core_check_feature(crtc->dev, DRIVER_ATOMIC) &&
 	    WARN_ON(new_crtc_state->enable && !new_crtc_state->mode_blob)) {
 		DRM_DEBUG_ATOMIC("[CRTC:%d:%s] enabled without mode blob\n",
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/5] drm: drm_auth.c: Adjust end of block comment
  2021-04-21 19:46 [PATCH 0/5] drm: Adjust end of block comment Beatriz Martins de Carvalho
  2021-04-21 19:46 ` [PATCH 1/5] drm: drm_atomic.c: " Beatriz Martins de Carvalho
@ 2021-04-21 19:46 ` Beatriz Martins de Carvalho
  2021-04-21 19:46 ` [PATCH 3/5] drm: drm_bufs.c: " Beatriz Martins de Carvalho
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Beatriz Martins de Carvalho @ 2021-04-21 19:46 UTC (permalink / raw)
  To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel
  Cc: melissa.srw, dri-devel, linux-kernel, outreachy-kernel

Add a new line with */ on the last line of a block comment to follow the
Linux kernel coding conventions.
Problem found by checkpatch.

Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
---
 drivers/gpu/drm/drm_auth.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_auth.c
index f2d46b7ac6f9..f00e5abdbbf4 100644
--- a/drivers/gpu/drm/drm_auth.c
+++ b/drivers/gpu/drm/drm_auth.c
@@ -300,7 +300,8 @@ int drm_master_open(struct drm_file *file_priv)
 	int ret = 0;
 
 	/* if there is no current master make this fd it, but do not create
-	 * any master object for render clients */
+	 * any master object for render clients
+	 */
 	mutex_lock(&dev->master_mutex);
 	if (!dev->master)
 		ret = drm_new_set_master(dev, file_priv);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/5] drm: drm_bufs.c: Adjust end of block comment
  2021-04-21 19:46 [PATCH 0/5] drm: Adjust end of block comment Beatriz Martins de Carvalho
  2021-04-21 19:46 ` [PATCH 1/5] drm: drm_atomic.c: " Beatriz Martins de Carvalho
  2021-04-21 19:46 ` [PATCH 2/5] drm: drm_auth.c: " Beatriz Martins de Carvalho
@ 2021-04-21 19:46 ` Beatriz Martins de Carvalho
  2021-04-21 19:46 ` [PATCH 4/5] drm: drm_connector.c: " Beatriz Martins de Carvalho
  2021-04-21 19:46 ` [PATCH 5/5] drm: drm_context.c: " Beatriz Martins de Carvalho
  4 siblings, 0 replies; 6+ messages in thread
From: Beatriz Martins de Carvalho @ 2021-04-21 19:46 UTC (permalink / raw)
  To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel
  Cc: melissa.srw, dri-devel, linux-kernel, outreachy-kernel

Add a new line with */ on the last line of a block comment to follow the
Linux kernel coding conventions.
Problem found by checkpatch.

Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
---
 drivers/gpu/drm/drm_bufs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
index e3d77dfefb0a..731a42a31c44 100644
--- a/drivers/gpu/drm/drm_bufs.c
+++ b/drivers/gpu/drm/drm_bufs.c
@@ -325,7 +325,8 @@ static int drm_addmap_core(struct drm_device *dev, resource_size_t offset,
 		/* dma_addr_t is 64bit on i386 with CONFIG_HIGHMEM64G,
 		 * As we're limiting the address to 2^32-1 (or less),
 		 * casting it down to 32 bits is no problem, but we
-		 * need to point to a 64bit variable first. */
+		 * need to point to a 64bit variable first.
+		 */
 		map->handle = dma_alloc_coherent(dev->dev,
 						 map->size,
 						 &map->offset,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 4/5] drm: drm_connector.c: Adjust end of block comment
  2021-04-21 19:46 [PATCH 0/5] drm: Adjust end of block comment Beatriz Martins de Carvalho
                   ` (2 preceding siblings ...)
  2021-04-21 19:46 ` [PATCH 3/5] drm: drm_bufs.c: " Beatriz Martins de Carvalho
@ 2021-04-21 19:46 ` Beatriz Martins de Carvalho
  2021-04-21 19:46 ` [PATCH 5/5] drm: drm_context.c: " Beatriz Martins de Carvalho
  4 siblings, 0 replies; 6+ messages in thread
From: Beatriz Martins de Carvalho @ 2021-04-21 19:46 UTC (permalink / raw)
  To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel
  Cc: melissa.srw, dri-devel, linux-kernel, outreachy-kernel

Add a new line with */ on the last line of a block comment to follow the
Linux kernel coding conventions.
Problem found by checkpatch.

Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
---
 drivers/gpu/drm/drm_connector.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index 7631f76e7f34..8714f2d021f9 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -279,7 +279,8 @@ int drm_connector_init(struct drm_device *dev,
 	drm_connector_get_cmdline_mode(connector);
 
 	/* We should add connectors at the end to avoid upsetting the connector
-	 * index too much. */
+	 * index too much.
+	 */
 	spin_lock_irq(&config->connector_list_lock);
 	list_add_tail(&connector->head, &config->connector_list);
 	config->num_connector++;
@@ -2288,7 +2289,8 @@ int drm_connector_property_set_ioctl(struct drm_device *dev,
 static struct drm_encoder *drm_connector_get_encoder(struct drm_connector *connector)
 {
 	/* For atomic drivers only state objects are synchronously updated and
-	 * protected by modeset locks, so check those first. */
+	 * protected by modeset locks, so check those first.
+	 */
 	if (connector->state)
 		return connector->state->best_encoder;
 	return connector->encoder;
@@ -2450,7 +2452,8 @@ int drm_mode_getconnector(struct drm_device *dev, void *data,
 		out_resp->encoder_id = 0;
 
 	/* Only grab properties after probing, to make sure EDID and other
-	 * properties reflect the latest status. */
+	 * properties reflect the latest status.
+	 */
 	ret = drm_mode_object_get_properties(&connector->base, file_priv->atomic,
 			(uint32_t __user *)(unsigned long)(out_resp->props_ptr),
 			(uint64_t __user *)(unsigned long)(out_resp->prop_values_ptr),
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 5/5] drm: drm_context.c: Adjust end of block comment
  2021-04-21 19:46 [PATCH 0/5] drm: Adjust end of block comment Beatriz Martins de Carvalho
                   ` (3 preceding siblings ...)
  2021-04-21 19:46 ` [PATCH 4/5] drm: drm_connector.c: " Beatriz Martins de Carvalho
@ 2021-04-21 19:46 ` Beatriz Martins de Carvalho
  4 siblings, 0 replies; 6+ messages in thread
From: Beatriz Martins de Carvalho @ 2021-04-21 19:46 UTC (permalink / raw)
  To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel
  Cc: melissa.srw, dri-devel, linux-kernel, outreachy-kernel

Add a new line with */ on the last line of a block comment to follow the
Linux kernel coding conventions.
Problem found by checkpatch.

Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
---
 drivers/gpu/drm/drm_context.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_context.c b/drivers/gpu/drm/drm_context.c
index c99be950bf17..54e3c513d6a5 100644
--- a/drivers/gpu/drm/drm_context.c
+++ b/drivers/gpu/drm/drm_context.c
@@ -312,7 +312,8 @@ static int drm_context_switch_complete(struct drm_device *dev,
 
 	/* If a context switch is ever initiated
 	   when the kernel holds the lock, release
-	   that lock here. */
+	   that lock here.
+	 */
 	clear_bit(0, &dev->context_flag);
 
 	return 0;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-04-21 19:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 19:46 [PATCH 0/5] drm: Adjust end of block comment Beatriz Martins de Carvalho
2021-04-21 19:46 ` [PATCH 1/5] drm: drm_atomic.c: " Beatriz Martins de Carvalho
2021-04-21 19:46 ` [PATCH 2/5] drm: drm_auth.c: " Beatriz Martins de Carvalho
2021-04-21 19:46 ` [PATCH 3/5] drm: drm_bufs.c: " Beatriz Martins de Carvalho
2021-04-21 19:46 ` [PATCH 4/5] drm: drm_connector.c: " Beatriz Martins de Carvalho
2021-04-21 19:46 ` [PATCH 5/5] drm: drm_context.c: " Beatriz Martins de Carvalho

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).