From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: mturquette@baylibre.com, sboyd@kernel.org, gregory.clement@bootlin.com, thomas.petazzoni@free-electrons.com Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr> Subject: [PATCH 0/4] clk: mvebu: Fix some error handling paths + do some clean-up Date: Fri, 23 Apr 2021 08:24:52 +0200 [thread overview] Message-ID: <cover.1619157996.git.christophe.jaillet@wanadoo.fr> (raw) This serie fixes some (unlikely) error handlings paths. The 4th patch is completely speculative. When I compile-tested the changes, I had to remove this line in order for it to compile. As it works fine (at least for me) without it, I wonder if it is needed at all. Also, I wonder if the drivers in drivers/clk/mvebu are used by anyone. In order to compile-test the changes, I also had to change the 'bool' in Kconfig by 'bool "blah"'. Without this change, it was not possible to set CONFIG_MVEBU_CLK_CPU required by Makefile. I don't know if I did something wrong, if it is an issue only on my environment or if something got broken at some time in the build chain but it looks spurious. If I'm right and that these drivers never compile and no-one noticed it, maybe removing them is better than fixing some unlikely issues and style. If these drivers should stay, Kconfig may need some love from someone. Christophe JAILLET (4): clk: mvebu: Fix a memory leak in an error handling path clk: mvebu: Fix a another memory leak in an error handling path clk: mvebu: Fix a checkpatch warning clk: mvebu: Remove an unneeded include drivers/clk/mvebu/clk-cpu.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: arnd@arndb.de, gregkh@linuxfoundation.org, mihai.carabas@oracle.com, andriy.shevchenko@linux.intel.com, pizhenwei@bytedance.com, pbonzini@redhat.com, bobo.shaobowang@huawei.com, linqiheng@huawei.com Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr> Subject: [PATCH 0/4] clk: mvebu: Fix some error handling paths + do some clean-up Date: Sat, 22 May 2021 08:51:51 +0200 [thread overview] Message-ID: <cover.1619157996.git.christophe.jaillet@wanadoo.fr> (raw) Message-ID: <20210522065151.F4SYPZSGdXpt_Awm29WPXemA4Dzoy7NRRc6pX_pea7E@z> (raw) This serie fixes some (unlikely) error handlings paths. The 4th patch is completely speculative. When I compile-tested the changes, I had to remove this line in order for it to compile. As it works fine (at least for me) without it, I wonder if it is needed at all. Also, I wonder if the drivers in drivers/clk/mvebu are used by anyone. In order to compile-test the changes, I also had to change the 'bool' in Kconfig by 'bool "blah"'. Without this change, it was not possible to set CONFIG_MVEBU_CLK_CPU required by Makefile. I don't know if I did something wrong, if it is an issue only on my environment or if something got broken at some time in the build chain but it looks spurious. If I'm right and that these drivers never compile and no-one noticed it, maybe removing them is better than fixing some unlikely issues and style. If these drivers should stay, Kconfig may need some love from someone. Christophe JAILLET (4): clk: mvebu: Fix a memory leak in an error handling path clk: mvebu: Fix a another memory leak in an error handling path clk: mvebu: Fix a checkpatch warning clk: mvebu: Remove an unneeded include drivers/clk/mvebu/clk-cpu.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) -- 2.27.0
next reply other threads:[~2021-04-23 6:25 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-23 6:24 Christophe JAILLET [this message] 2021-04-23 6:25 ` [PATCH 1/4] clk: mvebu: Fix a memory leak in an error handling path Christophe JAILLET 2021-04-23 11:42 ` AW: " Walter Harms 2021-04-23 12:02 ` Christophe JAILLET 2021-04-23 15:34 ` Walter Harms 2021-04-23 6:25 ` [PATCH 2/4] clk: mvebu: Fix a another " Christophe JAILLET 2021-04-23 6:25 ` [PATCH 3/4] clk: mvebu: Add a missing space Christophe JAILLET 2021-04-23 6:25 ` [PATCH 4/4] clk: mvebu: Remove an unneeded include Christophe JAILLET 2021-04-23 7:27 ` [PATCH 0/4] clk: mvebu: Fix some error handling paths + do some clean-up Thomas Petazzoni 2021-04-23 8:49 ` Christophe JAILLET 2021-05-22 6:51 ` Christophe JAILLET 2021-05-22 7:17 ` Marion & Christophe JAILLET
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1619157996.git.christophe.jaillet@wanadoo.fr \ --to=christophe.jaillet@wanadoo.fr \ --cc=gregory.clement@bootlin.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=sboyd@kernel.org \ --cc=thomas.petazzoni@free-electrons.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).