* [PATCH] Input: synaptics-rmi4 - fix debug for sensor clip
@ 2016-12-05 1:04 Nick Dyer
2016-12-05 18:04 ` Andrew Duggan
2016-12-08 1:22 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Nick Dyer @ 2016-12-05 1:04 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Andrew Duggan, Chris Healy, Benjamin Tissoires, linux-input,
linux-kernel, Nick Dyer
The debug would only ever output zero for the clip information.
Signed-off-by: Nick Dyer <nick@shmanahar.org>
---
drivers/input/rmi4/rmi_f12.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
index 8c5360c..e35c64b 100644
--- a/drivers/input/rmi4/rmi_f12.c
+++ b/drivers/input/rmi4/rmi_f12.c
@@ -71,10 +71,6 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
u8 buf[15];
int pitch_x = 0;
int pitch_y = 0;
- int clip_x_low = 0;
- int clip_x_high = 0;
- int clip_y_low = 0;
- int clip_y_high = 0;
int rx_receivers = 0;
int tx_receivers = 0;
int sensor_flags = 0;
@@ -127,7 +123,8 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
}
rmi_dbg(RMI_DEBUG_FN, &fn->dev, "%s: x low: %d x high: %d y low: %d y high: %d\n",
- __func__, clip_x_low, clip_x_high, clip_y_low, clip_y_high);
+ __func__, sensor->axis_align.clip_x_low, sensor->axis_align.clip_x_high,
+ sensor->axis_align.clip_y_low, sensor->axis_align.clip_y_high);
if (rmi_register_desc_has_subpacket(item, 3)) {
rx_receivers = buf[offset];
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: synaptics-rmi4 - fix debug for sensor clip
2016-12-05 1:04 [PATCH] Input: synaptics-rmi4 - fix debug for sensor clip Nick Dyer
@ 2016-12-05 18:04 ` Andrew Duggan
2016-12-08 1:22 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Duggan @ 2016-12-05 18:04 UTC (permalink / raw)
To: Nick Dyer, Dmitry Torokhov
Cc: Chris Healy, Benjamin Tissoires, linux-input, linux-kernel
On 12/04/2016 05:04 PM, Nick Dyer wrote:
> The debug would only ever output zero for the clip information.
>
> Signed-off-by: Nick Dyer <nick@shmanahar.org>
Reviewed-by: Andrew Duggan <aduggan@synaptics.com>
> ---
>
> drivers/input/rmi4/rmi_f12.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
> index 8c5360c..e35c64b 100644
> --- a/drivers/input/rmi4/rmi_f12.c
> +++ b/drivers/input/rmi4/rmi_f12.c
> @@ -71,10 +71,6 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
> u8 buf[15];
> int pitch_x = 0;
> int pitch_y = 0;
> - int clip_x_low = 0;
> - int clip_x_high = 0;
> - int clip_y_low = 0;
> - int clip_y_high = 0;
> int rx_receivers = 0;
> int tx_receivers = 0;
> int sensor_flags = 0;
> @@ -127,7 +123,8 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
> }
>
> rmi_dbg(RMI_DEBUG_FN, &fn->dev, "%s: x low: %d x high: %d y low: %d y high: %d\n",
> - __func__, clip_x_low, clip_x_high, clip_y_low, clip_y_high);
> + __func__, sensor->axis_align.clip_x_low, sensor->axis_align.clip_x_high,
> + sensor->axis_align.clip_y_low, sensor->axis_align.clip_y_high);
>
> if (rmi_register_desc_has_subpacket(item, 3)) {
> rx_receivers = buf[offset];
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: synaptics-rmi4 - fix debug for sensor clip
2016-12-05 1:04 [PATCH] Input: synaptics-rmi4 - fix debug for sensor clip Nick Dyer
2016-12-05 18:04 ` Andrew Duggan
@ 2016-12-08 1:22 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2016-12-08 1:22 UTC (permalink / raw)
To: Nick Dyer
Cc: Andrew Duggan, Chris Healy, Benjamin Tissoires, linux-input,
linux-kernel
On Mon, Dec 05, 2016 at 01:04:41AM +0000, Nick Dyer wrote:
> The debug would only ever output zero for the clip information.
>
> Signed-off-by: Nick Dyer <nick@shmanahar.org>
Applied, thank you.
> ---
>
> drivers/input/rmi4/rmi_f12.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
> index 8c5360c..e35c64b 100644
> --- a/drivers/input/rmi4/rmi_f12.c
> +++ b/drivers/input/rmi4/rmi_f12.c
> @@ -71,10 +71,6 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
> u8 buf[15];
> int pitch_x = 0;
> int pitch_y = 0;
> - int clip_x_low = 0;
> - int clip_x_high = 0;
> - int clip_y_low = 0;
> - int clip_y_high = 0;
> int rx_receivers = 0;
> int tx_receivers = 0;
> int sensor_flags = 0;
> @@ -127,7 +123,8 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12)
> }
>
> rmi_dbg(RMI_DEBUG_FN, &fn->dev, "%s: x low: %d x high: %d y low: %d y high: %d\n",
> - __func__, clip_x_low, clip_x_high, clip_y_low, clip_y_high);
> + __func__, sensor->axis_align.clip_x_low, sensor->axis_align.clip_x_high,
> + sensor->axis_align.clip_y_low, sensor->axis_align.clip_y_high);
>
> if (rmi_register_desc_has_subpacket(item, 3)) {
> rx_receivers = buf[offset];
> --
> 2.7.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-08 1:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-05 1:04 [PATCH] Input: synaptics-rmi4 - fix debug for sensor clip Nick Dyer
2016-12-05 18:04 ` Andrew Duggan
2016-12-08 1:22 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).