From: Mugunthan V N <mugunthanvnm@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>
Cc: Sekhar Nori <nsekhar@ti.com>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] drivers: net: cpsw: fix wrong regs access in cpsw_remove
Date: Fri, 29 Jul 2016 14:01:59 +0530 [thread overview]
Message-ID: <d01a86a6-4f0b-7ea7-a69d-9fcc5b2967e3@ti.com> (raw)
In-Reply-To: <20160728175037.22053-3-grygorii.strashko@ti.com>
On Thursday 28 July 2016 11:20 PM, Grygorii Strashko wrote:
> The L3 error will be generated and system will crash during unloading
> of CPSW driver if CPSW is used as module and ethX devices are down.
> This happens because CPSW can be power off by PM runtime now when ethX
> devices are down.
>
> Hence, ensure that CPSW powered up by PM runtime before performing any
> deinitialization actions which require CPSW registers access. In case
> of PM runtime error just leave cpsw_remove() as we can't do anything
> anymore.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
next prev parent reply other threads:[~2016-07-29 8:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 17:50 [PATCH v2 0/4] drivers: net: cpsw: fix driver loading/unloading Grygorii Strashko
2016-07-28 17:50 ` [PATCH v2 1/4] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy() Grygorii Strashko
2016-07-29 8:16 ` Mugunthan V N
2016-07-28 17:50 ` [PATCH v2 2/4] drivers: net: cpsw: fix wrong regs access in cpsw_remove Grygorii Strashko
2016-07-29 8:31 ` Mugunthan V N [this message]
2016-07-28 17:50 ` [PATCH v2 3/4] drivers: net: cpsw: use of_platform_depopulate() Grygorii Strashko
2016-07-29 8:36 ` Mugunthan V N
2016-07-28 17:50 ` [PATCH v2 4/4] ARM: OMAP2+: omap_device: fix crash on omap_device removal Grygorii Strashko
2016-07-29 5:15 ` Peter Ujfalusi
2016-07-29 12:52 ` Grygorii Strashko
2016-07-31 4:00 ` [PATCH v2 0/4] drivers: net: cpsw: fix driver loading/unloading David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d01a86a6-4f0b-7ea7-a69d-9fcc5b2967e3@ti.com \
--to=mugunthanvnm@ti.com \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).