* [PATCH] md/bcache: Remove NULL check.
@ 2018-08-13 9:38 Sean Fu
2018-08-13 10:00 ` Coly Li
0 siblings, 1 reply; 3+ messages in thread
From: Sean Fu @ 2018-08-13 9:38 UTC (permalink / raw)
To: colyli; +Cc: kent.overstreet, linux-bcache, linux-kernel, Sean Fu
Remove unnessesary NULL check before kmem_cache_destroy() in
drivers/md/bcache/request.c
Signed-off-by: Sean Fu <fxinrong@gmail.com>
---
drivers/md/bcache/request.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index ae67f5f..0ddee35 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -1306,8 +1306,7 @@ void bch_flash_dev_request_init(struct bcache_device *d)
void bch_request_exit(void)
{
- if (bch_search_cache)
- kmem_cache_destroy(bch_search_cache);
+ kmem_cache_destroy(bch_search_cache);
}
int __init bch_request_init(void)
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] md/bcache: Remove NULL check.
2018-08-13 9:38 [PATCH] md/bcache: Remove NULL check Sean Fu
@ 2018-08-13 10:00 ` Coly Li
2018-08-14 2:28 ` Sean Fu
0 siblings, 1 reply; 3+ messages in thread
From: Coly Li @ 2018-08-13 10:00 UTC (permalink / raw)
To: Sean Fu; +Cc: kent.overstreet, linux-bcache, linux-kernel
On 2018/8/13 5:38 PM, Sean Fu wrote:
> Remove unnessesary NULL check before kmem_cache_destroy() in
> drivers/md/bcache/request.c
>
> Signed-off-by: Sean Fu <fxinrong@gmail.com>
Hi Sean,
A same change is posted in my previous checkpatch fixes series. You may
find it from,
https://git.kernel.org/pub/scm/linux/kernel/git/colyli/linux-bcache.git/?h=for-next
The identical patch is,
https://git.kernel.org/pub/scm/linux/kernel/git/colyli/linux-bcache.git/commit/?h=for-next&id=26b39d0732955ecb839d0afe8d6211d70f213384
Thanks.
Coly Li
> ---
> drivers/md/bcache/request.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index ae67f5f..0ddee35 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1306,8 +1306,7 @@ void bch_flash_dev_request_init(struct bcache_device *d)
>
> void bch_request_exit(void)
> {
> - if (bch_search_cache)
> - kmem_cache_destroy(bch_search_cache);
> + kmem_cache_destroy(bch_search_cache);
> }
>
> int __init bch_request_init(void)
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] md/bcache: Remove NULL check.
2018-08-13 10:00 ` Coly Li
@ 2018-08-14 2:28 ` Sean Fu
0 siblings, 0 replies; 3+ messages in thread
From: Sean Fu @ 2018-08-14 2:28 UTC (permalink / raw)
To: Coly Li; +Cc: kent.overstreet, linux-bcache, linux-kernel
On Mon, Aug 13, 2018 at 06:00:11PM +0800, Coly Li wrote:
> On 2018/8/13 5:38 PM, Sean Fu wrote:
> > Remove unnessesary NULL check before kmem_cache_destroy() in
> > drivers/md/bcache/request.c
> >
> > Signed-off-by: Sean Fu <fxinrong@gmail.com>
>
> Hi Sean,
>
> A same change is posted in my previous checkpatch fixes series. You may
> find it from,
> https://git.kernel.org/pub/scm/linux/kernel/git/colyli/linux-bcache.git/?h=for-next
>
> The identical patch is,
> https://git.kernel.org/pub/scm/linux/kernel/git/colyli/linux-bcache.git/commit/?h=for-next&id=26b39d0732955ecb839d0afe8d6211d70f213384
>
Thank you for your reply.
Sean Fu
> Thanks.
>
> Coly Li
>
> > ---
> > drivers/md/bcache/request.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> > index ae67f5f..0ddee35 100644
> > --- a/drivers/md/bcache/request.c
> > +++ b/drivers/md/bcache/request.c
> > @@ -1306,8 +1306,7 @@ void bch_flash_dev_request_init(struct bcache_device *d)
> >
> > void bch_request_exit(void)
> > {
> > - if (bch_search_cache)
> > - kmem_cache_destroy(bch_search_cache);
> > + kmem_cache_destroy(bch_search_cache);
> > }
> >
> > int __init bch_request_init(void)
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-14 2:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-13 9:38 [PATCH] md/bcache: Remove NULL check Sean Fu
2018-08-13 10:00 ` Coly Li
2018-08-14 2:28 ` Sean Fu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).