* [PATCH] dmaengine: idxd: Remove unused status variable in irq_process_work_list()
@ 2021-08-02 17:58 Nathan Chancellor
2021-08-02 18:02 ` Dave Jiang
2021-08-06 13:46 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Nathan Chancellor @ 2021-08-02 17:58 UTC (permalink / raw)
To: Dave Jiang, Vinod Koul; +Cc: dmaengine, linux-kernel, Nathan Chancellor
status is no longer used within this block:
drivers/dma/idxd/irq.c:255:6: warning: unused variable 'status'
[-Wunused-variable]
u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
^
1 warning generated.
Fixes: b60bb6e2bfc1 ("dmaengine: idxd: fix abort status check")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/dma/idxd/irq.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
index 65dc7bbb0a13..91e46ca3a0ad 100644
--- a/drivers/dma/idxd/irq.c
+++ b/drivers/dma/idxd/irq.c
@@ -252,8 +252,6 @@ static int irq_process_work_list(struct idxd_irq_entry *irq_entry,
spin_unlock_irqrestore(&irq_entry->list_lock, flags);
list_for_each_entry(desc, &flist, list) {
- u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
-
/*
* Check against the original status as ABORT is software defined
* and 0xff, which DSA_COMP_STATUS_MASK can mask out.
base-commit: e9c5b0b53ccca81dd0a35c62309e243a57c7959d
--
2.32.0.264.g75ae10bc75
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: idxd: Remove unused status variable in irq_process_work_list()
2021-08-02 17:58 [PATCH] dmaengine: idxd: Remove unused status variable in irq_process_work_list() Nathan Chancellor
@ 2021-08-02 18:02 ` Dave Jiang
2021-08-06 13:46 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2021-08-02 18:02 UTC (permalink / raw)
To: Nathan Chancellor, Vinod Koul; +Cc: dmaengine, linux-kernel
On 8/2/2021 10:58 AM, Nathan Chancellor wrote:
> status is no longer used within this block:
>
> drivers/dma/idxd/irq.c:255:6: warning: unused variable 'status'
> [-Wunused-variable]
> u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
> ^
> 1 warning generated.
>
> Fixes: b60bb6e2bfc1 ("dmaengine: idxd: fix abort status check")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Thanks.
> ---
> drivers/dma/idxd/irq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
> index 65dc7bbb0a13..91e46ca3a0ad 100644
> --- a/drivers/dma/idxd/irq.c
> +++ b/drivers/dma/idxd/irq.c
> @@ -252,8 +252,6 @@ static int irq_process_work_list(struct idxd_irq_entry *irq_entry,
> spin_unlock_irqrestore(&irq_entry->list_lock, flags);
>
> list_for_each_entry(desc, &flist, list) {
> - u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
> -
> /*
> * Check against the original status as ABORT is software defined
> * and 0xff, which DSA_COMP_STATUS_MASK can mask out.
>
> base-commit: e9c5b0b53ccca81dd0a35c62309e243a57c7959d
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: idxd: Remove unused status variable in irq_process_work_list()
2021-08-02 17:58 [PATCH] dmaengine: idxd: Remove unused status variable in irq_process_work_list() Nathan Chancellor
2021-08-02 18:02 ` Dave Jiang
@ 2021-08-06 13:46 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-08-06 13:46 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: Dave Jiang, dmaengine, linux-kernel
On 02-08-21, 10:58, Nathan Chancellor wrote:
> status is no longer used within this block:
>
> drivers/dma/idxd/irq.c:255:6: warning: unused variable 'status'
> [-Wunused-variable]
> u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
> ^
> 1 warning generated.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-06 13:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 17:58 [PATCH] dmaengine: idxd: Remove unused status variable in irq_process_work_list() Nathan Chancellor
2021-08-02 18:02 ` Dave Jiang
2021-08-06 13:46 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).