From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Kalle Valo" <kvalo@kernel.org>,
"Alvin Šipraga" <ALSI@bang-olufsen.dk>,
"Hector Martin" <marcan@marcan.st>,
"~postmarketos/upstreaming@lists.sr.ht"
<~postmarketos/upstreaming@lists.sr.ht>,
"martin.botka@somainline.org" <martin.botka@somainline.org>,
"angelogioacchino.delregno@somainline.org"
<angelogioacchino.delregno@somainline.org>,
"marijn.suijten@somainline.org" <marijn.suijten@somainline.org>,
"jamipkettunen@somainline.org" <jamipkettunen@somainline.org>,
"Arend van Spriel" <aspriel@gmail.com>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, "Marek Vasut" <marex@denx.de>,
"Zhao, Jiaqing" <jiaqing.zhao@intel.com>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
"Soon Tak Lee" <soontak.lee@cypress.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"brcm80211-dev-list.pdl@broadcom.com"
<brcm80211-dev-list.pdl@broadcom.com>,
"SHA-cyfmac-dev-list@infineon.com"
<SHA-cyfmac-dev-list@infineon.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi
Date: Fri, 25 Nov 2022 12:42:29 +0100 [thread overview]
Message-ID: <d03bd4d4-e4ef-681b-b4a5-02822e1eee75@linaro.org> (raw)
In-Reply-To: <CACRpkdax-3VVDd29iH51mfumakqM7jyEc8Pbb=AQwAgp2WsqFQ@mail.gmail.com>
On 21.11.2022 14:56, Linus Walleij wrote:
> On Fri, Nov 18, 2022 at 5:47 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>> I can think of a couple of hacky ways to force use of 43596 fw, but I
>> don't think any would be really upstreamable..
>
> If it is only known to affect the Sony Xperias mentioned then
> a thing such as:
>
> if (of_machine_is_compatible("sony,xyz") ||
> of_machine_is_compatible("sony,zzz")... ) {
> // Enforce FW version
> }
>
> would be completely acceptable in my book. It hammers the
> problem from the top instead of trying to figure out itsy witsy
> details about firmware revisions.
>
> Yours,
> Linus Walleij
Actually, I think I came up with a better approach by pulling a page
out of Asahi folks' book - please take a look and tell me what you
think about this:
[1] https://github.com/SoMainline/linux/commit/4b6fccc995cd79109b0dae4e4ab2e48db97695e7
[2] https://github.com/SoMainline/linux/commit/e3ea1dc739634f734104f37fdbed046873921af7
Konrad
next prev parent reply other threads:[~2022-11-25 11:42 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 0:16 [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi Konrad Dybcio
2022-09-21 4:37 ` Hector Martin
2022-09-21 21:26 ` Konrad Dybcio
2022-09-22 6:40 ` Hector Martin
2022-09-22 10:21 ` Konrad Dybcio
2022-09-22 13:02 ` Linus Walleij
2022-09-22 13:08 ` Hector Martin
2022-09-22 13:30 ` Alvin Šipraga
2022-09-22 20:18 ` Linus Walleij
2022-09-26 8:20 ` Stockholm syndrome with Linux wireless? Kalle Valo
2022-09-26 8:59 ` Russell King (Oracle)
2022-10-03 19:40 ` Linus Walleij
2022-10-20 14:09 ` Linus Walleij
2022-10-20 14:44 ` Dave Taht
2022-09-26 9:27 ` [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi Kalle Valo
2022-11-18 16:47 ` Konrad Dybcio
2022-11-21 13:56 ` Linus Walleij
2022-11-25 11:42 ` Konrad Dybcio [this message]
2022-11-25 11:53 ` Kalle Valo
2022-11-25 12:10 ` Konrad Dybcio
2022-11-25 12:25 ` Kalle Valo
2022-11-26 21:45 ` Linus Walleij
2022-11-28 11:17 ` Kalle Valo
2022-11-28 14:40 ` Konrad Dybcio
2022-11-29 9:19 ` Krzysztof Kozlowski
2022-12-01 11:31 ` Arend van Spriel
2022-12-02 10:33 ` Konrad Dybcio
2022-12-02 15:26 ` Arend van Spriel
2022-12-02 19:28 ` Arend Van Spriel
2022-12-06 9:58 ` Konrad Dybcio
2022-12-06 11:22 ` Arend van Spriel
2022-12-07 10:12 ` Konrad Dybcio
2022-12-06 23:37 ` Linus Walleij
2022-12-07 7:41 ` Arend Van Spriel
2022-12-07 13:42 ` Linus Walleij
2022-12-07 22:26 ` Arend van Spriel
2022-12-07 8:57 ` Konrad Dybcio
2022-12-07 11:10 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d03bd4d4-e4ef-681b-b4a5-02822e1eee75@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=ALSI@bang-olufsen.dk \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=angelogioacchino.delregno@somainline.org \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=jamipkettunen@somainline.org \
--cc=jiaqing.zhao@intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=marex@denx.de \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=soontak.lee@cypress.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).