Re: [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi

From: Kalle Valo <kvalo@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Alvin Šipraga" <ALSI@bang-olufsen.dk>,
	"Hector Martin" <marcan@marcan.st>,
	"~postmarketos/upstreaming@lists.sr.ht"
	<~postmarketos/upstreaming@lists.sr.ht>,
	"martin.botka@somainline.org" <martin.botka@somainline.org>,
	"angelogioacchino.delregno@somainline.org"
	<angelogioacchino.delregno@somainline.org>,
	"marijn.suijten@somainline.org" <marijn.suijten@somainline.org>,
	"jamipkettunen@somainline.org" <jamipkettunen@somainline.org>,
	"Arend van Spriel" <aspriel@gmail.com>,
	"Franky Lin" <franky.lin@broadcom.com>,
	"Hante Meuleman" <hante.meuleman@broadcom.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>, "Marek Vasut" <marex@denx.de>,
	"Zhao, Jiaqing" <jiaqing.zhao@intel.com>,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
	"Soon Tak Lee" <soontak.lee@cypress.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"brcm80211-dev-list.pdl@broadcom.com"
	<brcm80211-dev-list.pdl@broadcom.com>,
	"SHA-cyfmac-dev-list@infineon.com"
	<SHA-cyfmac-dev-list@infineon.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi
Date: Mon, 28 Nov 2022 13:17:06 +0200	[thread overview]
Message-ID: <87wn7f5nwt.fsf@kernel.org> (raw)
In-Reply-To: <CACRpkdbpJ8fw0UsuHXGX43JRyPy6j8P41_5gesXOmitHvyoRwQ@mail.gmail.com> (Linus Walleij's message of "Sat, 26 Nov 2022 22:45:33 +0100")

Linus Walleij <linus.walleij@linaro.org> writes:

>> >> Instead of a directory path ("brcm/brcmfmac43596-pcie") why not provide
>> >> just the chipset name ("brcmfmac43596-pcie")? IMHO it's unnecessary to
>> >> have directory names in Device Tree.
>> >
>> > I think it's common practice to include a full $FIRMWARE_DIR-relative
>> > path when specifying firmware in DT, though here I left out the board
>> > name bit as that's assigned dynamically anyway. That said, if you don't
>> > like it, I can change it.
>>
>> It's just that I have understood that Device Tree is supposed to
>> describe hardware and to me a firmware directory "brcm/" is a software
>> property, not a hardware property. But this is really for the Device
>> Tree maintainers to decide, they know this best :)
>
> I would personally just minimize the amount of information
> put into the device tree to be exactly what is needed to find
> the right firmware.
>
> brcm,firmware-compatible = "43596";
>
> since the code already knows how to conjure the rest of the string.

FWIW I like this.

> But check with Rob/Krzysztof.

Indeed, they are the experts here.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches