* dmar compile failure in -git
@ 2020-10-16 21:23 Jens Axboe
2020-10-17 7:03 ` David Woodhouse
0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2020-10-16 21:23 UTC (permalink / raw)
To: David Woodhouse, joro, linux-kernel
Hi,
Ran into this one yesterday:
drivers/iommu/intel/dmar.c: In function ‘free_iommu’:
drivers/iommu/intel/dmar.c:1139:41: error: ‘struct iommu_device’ has no member named ‘ops’
1139 | if (intel_iommu_enabled && iommu->iommu.ops) {
| ^
make[3]: *** [scripts/Makefile.build:283: drivers/iommu/intel/dmar.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [scripts/Makefile.build:500: drivers/iommu/intel] Error 2
make[1]: *** [scripts/Makefile.build:500: drivers/iommu] Error 2
make: *** [Makefile:1777: drivers] Error 2
which is due to the config I use:
axboe@amd ~/g/linux-block (master)> cat .config | grep IOMMU
# CONFIG_GART_IOMMU is not set
CONFIG_IOMMU_SUPPORT=y
# Generic IOMMU Pagetable Support
# end of Generic IOMMU Pagetable Support
# CONFIG_IOMMU_DEBUGFS is not set
# CONFIG_AMD_IOMMU is not set
# CONFIG_INTEL_IOMMU is not set
axboe@amd ~/g/linux-block (master)> cat .config | grep DMAR
CONFIG_DMAR_TABLE=y
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: dmar compile failure in -git
2020-10-16 21:23 dmar compile failure in -git Jens Axboe
@ 2020-10-17 7:03 ` David Woodhouse
2020-10-20 16:26 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: David Woodhouse @ 2020-10-17 7:03 UTC (permalink / raw)
To: Jens Axboe, joro, linux-kernel
On 16 October 2020 22:23:46 BST, Jens Axboe <axboe@kernel.dk> wrote:
>Hi,
>
>Ran into this one yesterday:
>
>drivers/iommu/intel/dmar.c: In function ‘free_iommu’:
>drivers/iommu/intel/dmar.c:1139:41: error: ‘struct iommu_device’ has no
>member named ‘ops’
> 1139 | if (intel_iommu_enabled && iommu->iommu.ops) {
> | ^
>make[3]: *** [scripts/Makefile.build:283: drivers/iommu/intel/dmar.o]
>Error 1
>make[3]: *** Waiting for unfinished jobs....
>make[2]: *** [scripts/Makefile.build:500: drivers/iommu/intel] Error 2
>make[1]: *** [scripts/Makefile.build:500: drivers/iommu] Error 2
>make: *** [Makefile:1777: drivers] Error 2
>
>which is due to the config I use:
Thanks. Should be fixed by https://www.mail-archive.com/iommu@lists.linux-foundation.org/msg45697.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: dmar compile failure in -git
2020-10-17 7:03 ` David Woodhouse
@ 2020-10-20 16:26 ` Jens Axboe
2020-10-20 17:12 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2020-10-20 16:26 UTC (permalink / raw)
To: David Woodhouse; +Cc: joro, linux-kernel
On Sat, Oct 17, 2020 at 1:03 AM David Woodhouse <dwmw2@infradead.org> wrote:
> On 16 October 2020 22:23:46 BST, Jens Axboe <axboe@kernel.dk> wrote:
> >Hi,
> >
> >Ran into this one yesterday:
> >
> >drivers/iommu/intel/dmar.c: In function ‘free_iommu’:
> >drivers/iommu/intel/dmar.c:1139:41: error: ‘struct iommu_device’ has no
> >member named ‘ops’
> > 1139 | if (intel_iommu_enabled && iommu->iommu.ops) {
> > | ^
> >make[3]: *** [scripts/Makefile.build:283: drivers/iommu/intel/dmar.o]
> >Error 1
> >make[3]: *** Waiting for unfinished jobs....
> >make[2]: *** [scripts/Makefile.build:500: drivers/iommu/intel] Error 2
> >make[1]: *** [scripts/Makefile.build:500: drivers/iommu] Error 2
> >make: *** [Makefile:1777: drivers] Error 2
> >
> >which is due to the config I use:
>
> Thanks. Should be fixed by
> https://www.mail-archive.com/iommu@lists.linux-foundation.org/msg45697.html
Can we please get this known build breakage fix upstream? It keeps
breaking my test box compiles, which is pretty annoying.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: dmar compile failure in -git
2020-10-20 16:26 ` Jens Axboe
@ 2020-10-20 17:12 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2020-10-20 17:12 UTC (permalink / raw)
To: David Woodhouse; +Cc: joro, linux-kernel
On 10/20/20 10:26 AM, Jens Axboe wrote:
> On Sat, Oct 17, 2020 at 1:03 AM David Woodhouse <dwmw2@infradead.org> wrote:
>> On 16 October 2020 22:23:46 BST, Jens Axboe <axboe@kernel.dk> wrote:
>>> Hi,
>>>
>>> Ran into this one yesterday:
>>>
>>> drivers/iommu/intel/dmar.c: In function ‘free_iommu’:
>>> drivers/iommu/intel/dmar.c:1139:41: error: ‘struct iommu_device’ has no
>>> member named ‘ops’
>>> 1139 | if (intel_iommu_enabled && iommu->iommu.ops) {
>>> | ^
>>> make[3]: *** [scripts/Makefile.build:283: drivers/iommu/intel/dmar.o]
>>> Error 1
>>> make[3]: *** Waiting for unfinished jobs....
>>> make[2]: *** [scripts/Makefile.build:500: drivers/iommu/intel] Error 2
>>> make[1]: *** [scripts/Makefile.build:500: drivers/iommu] Error 2
>>> make: *** [Makefile:1777: drivers] Error 2
>>>
>>> which is due to the config I use:
>>
>> Thanks. Should be fixed by
>> https://www.mail-archive.com/iommu@lists.linux-foundation.org/msg45697.html
>
> Can we please get this known build breakage fix upstream? It keeps
> breaking my test box compiles, which is pretty annoying.
Nevermind, looks like it went upstream about the same time as I sent
this email. Thanks!
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-20 17:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 21:23 dmar compile failure in -git Jens Axboe
2020-10-17 7:03 ` David Woodhouse
2020-10-20 16:26 ` Jens Axboe
2020-10-20 17:12 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).