* [PATCH] wifi: ath12k: Remove some dead code
@ 2023-04-25 11:57 Christophe JAILLET
2023-04-25 12:10 ` AW: " Walter Harms
2023-04-28 16:53 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Christophe JAILLET @ 2023-04-25 11:57 UTC (permalink / raw)
To: Kalle Valo, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, ath12k,
linux-wireless, netdev
ATH12K_HE_MCS_MAX = 11, so this test and the following one are the same.
Remove the one with the hard coded 11 value.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/net/wireless/ath/ath12k/dp_rx.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.c b/drivers/net/wireless/ath/ath12k/dp_rx.c
index e78478a5b978..79386562562f 100644
--- a/drivers/net/wireless/ath/ath12k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath12k/dp_rx.c
@@ -1362,11 +1362,6 @@ ath12k_update_per_peer_tx_stats(struct ath12k *ar,
* Firmware rate's control to be skipped for this?
*/
- if (flags == WMI_RATE_PREAMBLE_HE && mcs > 11) {
- ath12k_warn(ab, "Invalid HE mcs %d peer stats", mcs);
- return;
- }
-
if (flags == WMI_RATE_PREAMBLE_HE && mcs > ATH12K_HE_MCS_MAX) {
ath12k_warn(ab, "Invalid HE mcs %d peer stats", mcs);
return;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* AW: [PATCH] wifi: ath12k: Remove some dead code
2023-04-25 11:57 [PATCH] wifi: ath12k: Remove some dead code Christophe JAILLET
@ 2023-04-25 12:10 ` Walter Harms
2023-05-18 6:17 ` Christophe JAILLET
2023-04-28 16:53 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Walter Harms @ 2023-04-25 12:10 UTC (permalink / raw)
To: Christophe JAILLET, Kalle Valo, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: linux-kernel, kernel-janitors, ath12k, linux-wireless, netdev
Does mcs = ATH12K_HE_MCS_MAX make sense ?
re,
wh
________________________________________
Von: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Gesendet: Dienstag, 25. April 2023 13:57:19
An: Kalle Valo; David S. Miller; Eric Dumazet; Jakub Kicinski; Paolo Abeni
Cc: linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Christophe JAILLET; ath12k@lists.infradead.org; linux-wireless@vger.kernel.org; netdev@vger.kernel.org
Betreff: [PATCH] wifi: ath12k: Remove some dead code
ATH12K_HE_MCS_MAX = 11, so this test and the following one are the same.
Remove the one with the hard coded 11 value.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/net/wireless/ath/ath12k/dp_rx.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.c b/drivers/net/wireless/ath/ath12k/dp_rx.c
index e78478a5b978..79386562562f 100644
--- a/drivers/net/wireless/ath/ath12k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath12k/dp_rx.c
@@ -1362,11 +1362,6 @@ ath12k_update_per_peer_tx_stats(struct ath12k *ar,
* Firmware rate's control to be skipped for this?
*/
- if (flags == WMI_RATE_PREAMBLE_HE && mcs > 11) {
- ath12k_warn(ab, "Invalid HE mcs %d peer stats", mcs);
- return;
- }
-
if (flags == WMI_RATE_PREAMBLE_HE && mcs > ATH12K_HE_MCS_MAX) {
ath12k_warn(ab, "Invalid HE mcs %d peer stats", mcs);
return;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] wifi: ath12k: Remove some dead code
2023-04-25 11:57 [PATCH] wifi: ath12k: Remove some dead code Christophe JAILLET
2023-04-25 12:10 ` AW: " Walter Harms
@ 2023-04-28 16:53 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2023-04-28 16:53 UTC (permalink / raw)
To: Christophe JAILLET
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
linux-kernel, kernel-janitors, Christophe JAILLET, ath12k,
linux-wireless, netdev
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> ATH12K_HE_MCS_MAX = 11, so this test and the following one are the same.
> Remove the one with the hard coded 11 value.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
33f83a23f4cc wifi: ath12k: Remove some dead code
--
https://patchwork.kernel.org/project/linux-wireless/patch/c17edf0811156a33bae6c5cf1906d751cc87edd4.1682423828.git.christophe.jaillet@wanadoo.fr/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: AW: [PATCH] wifi: ath12k: Remove some dead code
2023-04-25 12:10 ` AW: " Walter Harms
@ 2023-05-18 6:17 ` Christophe JAILLET
0 siblings, 0 replies; 4+ messages in thread
From: Christophe JAILLET @ 2023-05-18 6:17 UTC (permalink / raw)
To: Walter Harms, Kalle Valo, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: linux-kernel, kernel-janitors, ath12k, linux-wireless, netdev
Le 25/04/2023 à 14:10, Walter Harms a écrit :
> Does mcs = ATH12K_HE_MCS_MAX make sense ?
>
Based on [1], I would say yes, WMI_RATE_PREAMBLE_HE (i.e. 11) looks like
a valid value.
CJ
[1]: https://www.7signal.com/info/mcs
> re,
> wh
> ________________________________________
> Von: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Gesendet: Dienstag, 25. April 2023 13:57:19
> An: Kalle Valo; David S. Miller; Eric Dumazet; Jakub Kicinski; Paolo Abeni
> Cc: linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Christophe JAILLET; ath12k@lists.infradead.org; linux-wireless@vger.kernel.org; netdev@vger.kernel.org
> Betreff: [PATCH] wifi: ath12k: Remove some dead code
>
> ATH12K_HE_MCS_MAX = 11, so this test and the following one are the same.
> Remove the one with the hard coded 11 value.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/wireless/ath/ath12k/dp_rx.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.c b/drivers/net/wireless/ath/ath12k/dp_rx.c
> index e78478a5b978..79386562562f 100644
> --- a/drivers/net/wireless/ath/ath12k/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath12k/dp_rx.c
> @@ -1362,11 +1362,6 @@ ath12k_update_per_peer_tx_stats(struct ath12k *ar,
> * Firmware rate's control to be skipped for this?
> */
>
> - if (flags == WMI_RATE_PREAMBLE_HE && mcs > 11) {
> - ath12k_warn(ab, "Invalid HE mcs %d peer stats", mcs);
> - return;
> - }
> -
> if (flags == WMI_RATE_PREAMBLE_HE && mcs > ATH12K_HE_MCS_MAX) {
> ath12k_warn(ab, "Invalid HE mcs %d peer stats", mcs);
> return;
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-18 6:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-25 11:57 [PATCH] wifi: ath12k: Remove some dead code Christophe JAILLET
2023-04-25 12:10 ` AW: " Walter Harms
2023-05-18 6:17 ` Christophe JAILLET
2023-04-28 16:53 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).