From: Grygorii Strashko <grygorii.strashko@ti.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <kuba@kernel.org>,
<m-karicheri2@ti.com>, <nsekhar@ti.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: ethernet: ti: add NETIF_F_HW_TC hw feature flag for taprio offload
Date: Tue, 21 Jul 2020 23:05:48 +0300 [thread overview]
Message-ID: <d0cef407-9340-2d4d-9fa7-d708f5568d25@ti.com> (raw)
In-Reply-To: <20200717.184701.2071890437316814619.davem@davemloft.net>
hi David,
On 18/07/2020 04:47, David Miller wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
> Date: Fri, 17 Jul 2020 15:19:32 +0300
>
>> From: Murali Karicheri <m-karicheri2@ti.com>
>>
>> Currently drive supports taprio offload which is a tc feature offloaded
>> to cpsw hardware. So driver has to set the hw feature flag, NETIF_F_HW_TC
>> in the net device to be compliant. This patch adds the flag.
>>
>> Fixes: 8127224c2708 ("ethernet: ti: am65-cpsw-qos: add TAPRIO offload support")
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
> How was the commit adding TAPRIO support even tested since without the
> NETIF_F_HW_TC bit set tc_can_offload() always returns false?
>
The sch_taprio doesn't check for NETIF_F_HW_TC (no calls of tc_can_offload()).
It only checks for !ndo_setup_tc(). Therefore our basic offload tests are working.
It's not critical patch.
--
Best regards,
grygorii
next prev parent reply other threads:[~2020-07-21 20:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 12:19 [PATCH] net: ethernet: ti: add NETIF_F_HW_TC hw feature flag for taprio offload Grygorii Strashko
2020-07-18 1:47 ` David Miller
2020-07-21 20:05 ` Grygorii Strashko [this message]
2020-07-22 1:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0cef407-9340-2d4d-9fa7-d708f5568d25@ti.com \
--to=grygorii.strashko@ti.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).