[PATCH] net: ethernet: ti: add NETIF_F_HW_TC hw feature flag for taprio offload

[PATCH] net: ethernet: ti: add NETIF_F_HW_TC hw feature flag for taprio offload

[Grygorii Strashko]

From: Murali Karicheri <m-karicheri2@ti.com>

Currently drive supports taprio offload which is a tc feature offloaded
to cpsw hardware. So driver has to set the hw feature flag, NETIF_F_HW_TC
in the net device to be compliant. This patch adds the flag.

Fixes: 8127224c2708 ("ethernet: ti: am65-cpsw-qos: add TAPRIO offload support")
Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index 1492648247d9..6d778bc3d012 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -1850,7 +1850,8 @@ static int am65_cpsw_nuss_init_ndev_2g(struct am65_cpsw_common *common)
 	port->ndev->max_mtu = AM65_CPSW_MAX_PACKET_SIZE;
 	port->ndev->hw_features = NETIF_F_SG |
 				  NETIF_F_RXCSUM |
-				  NETIF_F_HW_CSUM;
+				  NETIF_F_HW_CSUM |
+				  NETIF_F_HW_TC;
 	port->ndev->features = port->ndev->hw_features |
 			       NETIF_F_HW_VLAN_CTAG_FILTER;
 	port->ndev->vlan_features |=  NETIF_F_SG;
-- 
2.17.1

Re: [PATCH] net: ethernet: ti: add NETIF_F_HW_TC hw feature flag for taprio offload

[David Miller]

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Fri, 17 Jul 2020 15:19:32 +0300

> From: Murali Karicheri <m-karicheri2@ti.com>
> 
> Currently drive supports taprio offload which is a tc feature offloaded
> to cpsw hardware. So driver has to set the hw feature flag, NETIF_F_HW_TC
> in the net device to be compliant. This patch adds the flag.
> 
> Fixes: 8127224c2708 ("ethernet: ti: am65-cpsw-qos: add TAPRIO offload support")
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

How was the commit adding TAPRIO support even tested since without the
NETIF_F_HW_TC bit set tc_can_offload() always returns false?

Re: [PATCH] net: ethernet: ti: add NETIF_F_HW_TC hw feature flag for taprio offload

[Grygorii Strashko]

hi David,

On 18/07/2020 04:47, David Miller wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
> Date: Fri, 17 Jul 2020 15:19:32 +0300
> 
>> From: Murali Karicheri <m-karicheri2@ti.com>
>>
>> Currently drive supports taprio offload which is a tc feature offloaded
>> to cpsw hardware. So driver has to set the hw feature flag, NETIF_F_HW_TC
>> in the net device to be compliant. This patch adds the flag.
>>
>> Fixes: 8127224c2708 ("ethernet: ti: am65-cpsw-qos: add TAPRIO offload support")
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> 
> How was the commit adding TAPRIO support even tested since without the
> NETIF_F_HW_TC bit set tc_can_offload() always returns false?
> 

The sch_taprio doesn't check for NETIF_F_HW_TC (no calls of tc_can_offload()).
It only checks for !ndo_setup_tc(). Therefore our basic offload tests are working.

It's not critical patch.

-- 
Best regards,
grygorii

Re: [PATCH] net: ethernet: ti: add NETIF_F_HW_TC hw feature flag for taprio offload

[David Miller]

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Fri, 17 Jul 2020 15:19:32 +0300

> From: Murali Karicheri <m-karicheri2@ti.com>
> 
> Currently drive supports taprio offload which is a tc feature offloaded
> to cpsw hardware. So driver has to set the hw feature flag, NETIF_F_HW_TC
> in the net device to be compliant. This patch adds the flag.
> 
> Fixes: 8127224c2708 ("ethernet: ti: am65-cpsw-qos: add TAPRIO offload support")
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Applied.