* [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.
@ 2017-08-31 18:54 Eric Anholt
2017-08-31 18:54 ` [PATCH 2/2] ARM: dts: Add the PWM node " Eric Anholt
2017-08-31 20:16 ` [PATCH 1/2] ARM: dts: Add the CLCD controller " Scott Branden
0 siblings, 2 replies; 7+ messages in thread
From: Eric Anholt @ 2017-08-31 18:54 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, Stefan Wahren,
bcm-kernel-feedback-list, Ray Jui, Scott Branden, Jon Mason,
devicetree, Rob Herring, Mark Rutland, Eric Anholt
This doesn't yet enable it on any particular platform, as we still
need a panel driver for bcm911360_entphn.
Signed-off-by: Eric Anholt <eric@anholt.net>
---
These bits are just carving off a little bit of my 911360_entphn panel
series, to reduce conflicts when rebasing (which I just did for
testing pl111 changes for cygnus regressions). I'm waiting to get my
current RPi panel driver in before working on the 911360 panel again.
arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
index 7c957ea06c66..74f73ff24aec 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -575,6 +575,16 @@
status = "disabled";
};
+ clcd: clcd@180a0000 {
+ compatible = "arm,pl111", "arm,primecell";
+ reg = <0x180a0000 0x1000>;
+ interrupts = <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "combined";
+ clocks = <&axi41_clk>, <&apb_clk>;
+ clock-names = "clcdclk", "apb_pclk";
+ status = "disabled";
+ };
+
keypad: keypad@180ac000 {
compatible = "brcm,bcm-keypad";
reg = <0x180ac000 0x14c>;
--
2.14.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] ARM: dts: Add the PWM node to Cygnus
2017-08-31 18:54 [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus Eric Anholt
@ 2017-08-31 18:54 ` Eric Anholt
2017-08-31 20:10 ` Scott Branden
2017-08-31 20:16 ` [PATCH 1/2] ARM: dts: Add the CLCD controller " Scott Branden
1 sibling, 1 reply; 7+ messages in thread
From: Eric Anholt @ 2017-08-31 18:54 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, Stefan Wahren,
bcm-kernel-feedback-list, Ray Jui, Scott Branden, Jon Mason,
devicetree, Rob Herring, Mark Rutland, Eric Anholt
This is connected up to the backlight on 911360_entphn, which we'll
need for a panel driver. For now, leave the node disabled in the
shared dtsi.
Signed-off-by: Eric Anholt <eric@anholt.net>
---
arch/arm/boot/dts/bcm-cygnus.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
index 74f73ff24aec..b9a654d733ae 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -585,6 +585,14 @@
status = "disabled";
};
+ pwm: pwm@180aa500 {
+ compatible = "brcm,kona-pwm";
+ reg = <0x180aa500 0xc4>;
+ #pwm-cells = <3>;
+ clocks = <&asiu_clks BCM_CYGNUS_ASIU_PWM_CLK>;
+ status = "disabled";
+ };
+
keypad: keypad@180ac000 {
compatible = "brcm,bcm-keypad";
reg = <0x180ac000 0x14c>;
--
2.14.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] ARM: dts: Add the PWM node to Cygnus
2017-08-31 18:54 ` [PATCH 2/2] ARM: dts: Add the PWM node " Eric Anholt
@ 2017-08-31 20:10 ` Scott Branden
2017-09-02 2:11 ` Florian Fainelli
0 siblings, 1 reply; 7+ messages in thread
From: Scott Branden @ 2017-08-31 20:10 UTC (permalink / raw)
To: Eric Anholt, Florian Fainelli
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, Stefan Wahren,
bcm-kernel-feedback-list, Ray Jui, Scott Branden, Jon Mason,
devicetree, Rob Herring, Mark Rutland
pwm node is correct.
On 17-08-31 11:54 AM, Eric Anholt wrote:
> This is connected up to the backlight on 911360_entphn, which we'll
> need for a panel driver. For now, leave the node disabled in the
> shared dtsi.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> arch/arm/boot/dts/bcm-cygnus.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 74f73ff24aec..b9a654d733ae 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -585,6 +585,14 @@
> status = "disabled";
> };
>
> + pwm: pwm@180aa500 {
> + compatible = "brcm,kona-pwm";
> + reg = <0x180aa500 0xc4>;
> + #pwm-cells = <3>;
> + clocks = <&asiu_clks BCM_CYGNUS_ASIU_PWM_CLK>;
> + status = "disabled";
> + };
> +
> keypad: keypad@180ac000 {
> compatible = "brcm,bcm-keypad";
> reg = <0x180ac000 0x14c>;
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.
2017-08-31 18:54 [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus Eric Anholt
2017-08-31 18:54 ` [PATCH 2/2] ARM: dts: Add the PWM node " Eric Anholt
@ 2017-08-31 20:16 ` Scott Branden
2017-09-02 2:10 ` Florian Fainelli
1 sibling, 1 reply; 7+ messages in thread
From: Scott Branden @ 2017-08-31 20:16 UTC (permalink / raw)
To: Eric Anholt, Florian Fainelli
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, Stefan Wahren,
bcm-kernel-feedback-list, Ray Jui, Scott Branden, Jon Mason,
devicetree, Rob Herring, Mark Rutland
Hi Eric,
mode is correct, location in file needs to be moved.
On 17-08-31 11:54 AM, Eric Anholt wrote:
> This doesn't yet enable it on any particular platform, as we still
> need a panel driver for bcm911360_entphn.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>
> These bits are just carving off a little bit of my 911360_entphn panel
> series, to reduce conflicts when rebasing (which I just did for
> testing pl111 changes for cygnus regressions). I'm waiting to get my
> current RPi panel driver in before working on the 911360 panel again.
>
> arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 7c957ea06c66..74f73ff24aec 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -575,6 +575,16 @@
> status = "disabled";
> };
>
> + clcd: clcd@180a0000 {
please place in correct address ordered location in file
> + compatible = "arm,pl111", "arm,primecell";
> + reg = <0x180a0000 0x1000>;
> + interrupts = <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "combined";
> + clocks = <&axi41_clk>, <&apb_clk>;
> + clock-names = "clcdclk", "apb_pclk";
> + status = "disabled";
> + };
> +
> keypad: keypad@180ac000 {
> compatible = "brcm,bcm-keypad";
> reg = <0x180ac000 0x14c>;
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.
2017-08-31 20:16 ` [PATCH 1/2] ARM: dts: Add the CLCD controller " Scott Branden
@ 2017-09-02 2:10 ` Florian Fainelli
[not found] ` <CA+Jzhd+cX6MW9O+BzSU0NDTEgBet=wbgMdwW9A+fi7HVvxAArA@mail.gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: Florian Fainelli @ 2017-09-02 2:10 UTC (permalink / raw)
To: Scott Branden, Eric Anholt, Florian Fainelli
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, Stefan Wahren,
bcm-kernel-feedback-list, Ray Jui, Scott Branden, Jon Mason,
devicetree, Rob Herring, Mark Rutland
On 08/31/2017 01:16 PM, Scott Branden wrote:
> Hi Eric,
>
> mode is correct, location in file needs to be moved.
>
>
> On 17-08-31 11:54 AM, Eric Anholt wrote:
>> This doesn't yet enable it on any particular platform, as we still
>> need a panel driver for bcm911360_entphn.
>>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>>
>> These bits are just carving off a little bit of my 911360_entphn panel
>> series, to reduce conflicts when rebasing (which I just did for
>> testing pl111 changes for cygnus regressions). I'm waiting to get my
>> current RPi panel driver in before working on the 911360 panel again.
>>
>> arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> index 7c957ea06c66..74f73ff24aec 100644
>> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> @@ -575,6 +575,16 @@
>> status = "disabled";
>> };
>> + clcd: clcd@180a0000 {
> please place in correct address ordered location in file
I moved it right above the v3d node to keep the nodes ordered by unit
address, please check the result here:
https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75
>> + compatible = "arm,pl111", "arm,primecell";
>> + reg = <0x180a0000 0x1000>;
>> + interrupts = <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "combined";
>> + clocks = <&axi41_clk>, <&apb_clk>;
>> + clock-names = "clcdclk", "apb_pclk";
>> + status = "disabled";
>> + };
>> +
>> keypad: keypad@180ac000 {
>> compatible = "brcm,bcm-keypad";
>> reg = <0x180ac000 0x14c>;
>
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] ARM: dts: Add the PWM node to Cygnus
2017-08-31 20:10 ` Scott Branden
@ 2017-09-02 2:11 ` Florian Fainelli
0 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2017-09-02 2:11 UTC (permalink / raw)
To: Scott Branden, Eric Anholt, Florian Fainelli
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, Stefan Wahren,
bcm-kernel-feedback-list, Ray Jui, Scott Branden, Jon Mason,
devicetree, Rob Herring, Mark Rutland
On 08/31/2017 01:10 PM, Scott Branden wrote:
> pwm node is correct.
>
>
> On 17-08-31 11:54 AM, Eric Anholt wrote:
>> This is connected up to the backlight on 911360_entphn, which we'll
>> need for a panel driver. For now, leave the node disabled in the
>> shared dtsi.
>>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
> Acked-by: Scott Branden <scott.branden@broadcom.com>
Applied to devicetree/next:
https://github.com/Broadcom/stblinux/commit/31807d46f85c4d86ef3b6df9c5a4e69d35f75bc0
>> ---
>> arch/arm/boot/dts/bcm-cygnus.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> index 74f73ff24aec..b9a654d733ae 100644
>> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
>> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
>> @@ -585,6 +585,14 @@
>> status = "disabled";
>> };
>> + pwm: pwm@180aa500 {
>> + compatible = "brcm,kona-pwm";
>> + reg = <0x180aa500 0xc4>;
>> + #pwm-cells = <3>;
>> + clocks = <&asiu_clks BCM_CYGNUS_ASIU_PWM_CLK>;
>> + status = "disabled";
>> + };
>> +
>> keypad: keypad@180ac000 {
>> compatible = "brcm,bcm-keypad";
>> reg = <0x180ac000 0x14c>;
>
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus.
[not found] ` <CA+JzhdK9feJzk-TJe5HkHfqZOfDm9gOkDQmSSEHYhcuPu0wX5g@mail.gmail.com>
@ 2017-09-02 16:25 ` Florian Fainelli
0 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2017-09-02 16:25 UTC (permalink / raw)
To: Scott Branden, Florian Fainelli
Cc: Mark Rutland, Ray Jui, Rob Herring, linux-kernel, devicetree,
Stefan Wahren, linux-arm-kernel, Eric Anholt, Jon Mason,
Scott Branden, linux-rpi-kernel, bcm-kernel-feedback-list
On 09/02/2017 08:48 AM, Scott Branden wrote:
> Looks good
>
> On Sep 1, 2017 7:10 PM, "Florian Fainelli" <f.fainelli@gmail.com
> <mailto:f.fainelli@gmail.com>> wrote:
>
>
>
> On 08/31/2017 01:16 PM, Scott Branden wrote:
> > Hi Eric,
> >
> > mode is correct, location in file needs to be moved.
> >
> >
> > On 17-08-31 11:54 AM, Eric Anholt wrote:
> >> This doesn't yet enable it on any particular platform, as we still
> >> need a panel driver for bcm911360_entphn.
> >>
> >> Signed-off-by: Eric Anholt <eric@anholt.net <mailto:eric@anholt.net>>
> >> ---
> >>
> >> These bits are just carving off a little bit of my 911360_entphn
> panel
> >> series, to reduce conflicts when rebasing (which I just did for
> >> testing pl111 changes for cygnus regressions). I'm waiting to get my
> >> current RPi panel driver in before working on the 911360 panel again.
> >>
> >> arch/arm/boot/dts/bcm-cygnus.dtsi | 10 ++++++++++
> >> 1 file changed, 10 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> b/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> index 7c957ea06c66..74f73ff24aec 100644
> >> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> >> @@ -575,6 +575,16 @@
> >> status = "disabled";
> >> };
> >> + clcd: clcd@180a0000 {
> > please place in correct address ordered location in file
>
> I moved it right above the v3d node to keep the nodes ordered by unit
> address, please check the result here:
>
> https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75
> <https://github.com/Broadcom/stblinux/commit/4d1e42c6b9d28ce7b74d92258435f9d16834ae75>
>
>
> With Moved location
> Acked-by: Scott Branden <scott.branden@broadcom.com
> <mailto:scott.branden@broadcom.com>>
Pushed in place with your tag added, thanks!
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-09-02 16:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-31 18:54 [PATCH 1/2] ARM: dts: Add the CLCD controller to Cygnus Eric Anholt
2017-08-31 18:54 ` [PATCH 2/2] ARM: dts: Add the PWM node " Eric Anholt
2017-08-31 20:10 ` Scott Branden
2017-09-02 2:11 ` Florian Fainelli
2017-08-31 20:16 ` [PATCH 1/2] ARM: dts: Add the CLCD controller " Scott Branden
2017-09-02 2:10 ` Florian Fainelli
[not found] ` <CA+Jzhd+cX6MW9O+BzSU0NDTEgBet=wbgMdwW9A+fi7HVvxAArA@mail.gmail.com>
[not found] ` <CA+JzhdK9feJzk-TJe5HkHfqZOfDm9gOkDQmSSEHYhcuPu0wX5g@mail.gmail.com>
2017-09-02 16:25 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).