linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 1/2] dt-bindings: gpio: sprd: Use SoC compatible string instead of wildcard string
@ 2019-02-19  2:29 Baolin Wang
  2019-02-19  2:29 ` [PATCH v3 2/2] gpio: sprd: Change to use SoC compatible string Baolin Wang
  2019-02-21 12:18 ` [PATCH v3 1/2] dt-bindings: gpio: sprd: Use SoC compatible string instead of wildcard string Linus Walleij
  0 siblings, 2 replies; 4+ messages in thread
From: Baolin Wang @ 2019-02-19  2:29 UTC (permalink / raw)
  To: robh+dt, mark.rutland, linus.walleij, bgolaszewski
  Cc: orsonzhai, zhang.lyra, baolin.wang, broonie, devicetree,
	linux-gpio, linux-kernel

Use SoC compatible string instead of wildcard string.

Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
Changes from v2:
 - Add reviewed tag from Rob.

Changes from v1:
 - Add 'sprd' to indicate the module in subject line.
---
 .../devicetree/bindings/gpio/gpio-eic-sprd.txt     |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt b/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
index 93d98d0..54040a2 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
@@ -33,7 +33,7 @@ Required properties:
   "sprd,sc9860-eic-latch",
   "sprd,sc9860-eic-async",
   "sprd,sc9860-eic-sync",
-  "sprd,sc27xx-eic".
+  "sprd,sc2731-eic".
 - reg: Define the base and range of the I/O address space containing
   the GPIO controller registers.
 - gpio-controller: Marks the device node as a GPIO controller.
@@ -86,7 +86,7 @@ Example:
 	};
 
 	pmic_eic: gpio@300 {
-		compatible = "sprd,sc27xx-eic";
+		compatible = "sprd,sc2731-eic";
 		reg = <0x300>;
 		interrupt-parent = <&sc2731_pmic>;
 		interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v3 2/2] gpio: sprd: Change to use SoC compatible string
  2019-02-19  2:29 [PATCH v3 1/2] dt-bindings: gpio: sprd: Use SoC compatible string instead of wildcard string Baolin Wang
@ 2019-02-19  2:29 ` Baolin Wang
  2019-02-21 12:19   ` Linus Walleij
  2019-02-21 12:18 ` [PATCH v3 1/2] dt-bindings: gpio: sprd: Use SoC compatible string instead of wildcard string Linus Walleij
  1 sibling, 1 reply; 4+ messages in thread
From: Baolin Wang @ 2019-02-19  2:29 UTC (permalink / raw)
  To: robh+dt, mark.rutland, linus.walleij, bgolaszewski
  Cc: orsonzhai, zhang.lyra, baolin.wang, broonie, devicetree,
	linux-gpio, linux-kernel

Change to use SoC compatible string instead of wildcard string.

The Spreadtrum SC9860 platform device trees and drivers' development
are still in progress, and now we will always recompile and ship
device trees at the same time as we will compile and ship the kernel,
so we do not need care about the backwards compatibility.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
Changes from v2:
 - Add some comments to explain why we do not care backwards compatibility.

Changes from v1:
 - None.
---
 drivers/gpio/gpio-pmic-eic-sprd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
index ac573da..24228cf 100644
--- a/drivers/gpio/gpio-pmic-eic-sprd.c
+++ b/drivers/gpio/gpio-pmic-eic-sprd.c
@@ -364,7 +364,7 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id sprd_pmic_eic_of_match[] = {
-	{ .compatible = "sprd,sc27xx-eic", },
+	{ .compatible = "sprd,sc2731-eic", },
 	{ /* end of list */ }
 };
 MODULE_DEVICE_TABLE(of, sprd_pmic_eic_of_match);
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: gpio: sprd: Use SoC compatible string instead of wildcard string
  2019-02-19  2:29 [PATCH v3 1/2] dt-bindings: gpio: sprd: Use SoC compatible string instead of wildcard string Baolin Wang
  2019-02-19  2:29 ` [PATCH v3 2/2] gpio: sprd: Change to use SoC compatible string Baolin Wang
@ 2019-02-21 12:18 ` Linus Walleij
  1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2019-02-21 12:18 UTC (permalink / raw)
  To: Baolin Wang
  Cc: Rob Herring, Mark Rutland, Bartosz Golaszewski, Orson Zhai,
	Lyra Zhang, Mark Brown,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:GPIO SUBSYSTEM, linux-kernel

On Tue, Feb 19, 2019 at 3:30 AM Baolin Wang <baolin.wang@linaro.org> wrote:

> Use SoC compatible string instead of wildcard string.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 2/2] gpio: sprd: Change to use SoC compatible string
  2019-02-19  2:29 ` [PATCH v3 2/2] gpio: sprd: Change to use SoC compatible string Baolin Wang
@ 2019-02-21 12:19   ` Linus Walleij
  0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2019-02-21 12:19 UTC (permalink / raw)
  To: Baolin Wang
  Cc: Rob Herring, Mark Rutland, Bartosz Golaszewski, Orson Zhai,
	Lyra Zhang, Mark Brown,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:GPIO SUBSYSTEM, linux-kernel

On Tue, Feb 19, 2019 at 3:30 AM Baolin Wang <baolin.wang@linaro.org> wrote:

> Change to use SoC compatible string instead of wildcard string.
>
> The Spreadtrum SC9860 platform device trees and drivers' development
> are still in progress, and now we will always recompile and ship
> device trees at the same time as we will compile and ship the kernel,
> so we do not need care about the backwards compatibility.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
> Changes from v2:
>  - Add some comments to explain why we do not care backwards compatibility.

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-02-21 12:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-19  2:29 [PATCH v3 1/2] dt-bindings: gpio: sprd: Use SoC compatible string instead of wildcard string Baolin Wang
2019-02-19  2:29 ` [PATCH v3 2/2] gpio: sprd: Change to use SoC compatible string Baolin Wang
2019-02-21 12:19   ` Linus Walleij
2019-02-21 12:18 ` [PATCH v3 1/2] dt-bindings: gpio: sprd: Use SoC compatible string instead of wildcard string Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).