From: Markus Elfring <Markus.Elfring@web.de>
To: Stephen Boyd <swboyd@chromium.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Andrzej Hajda <a.hajda@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH v4 1/3] driver core: platform: Add an error message to platform_get_irq*()
Date: Wed, 24 Jul 2019 17:00:43 +0200 [thread overview]
Message-ID: <d12a32e6-fd82-71f8-c320-ea6e844db3f4@web.de> (raw)
In-Reply-To: <20190723181624.203864-2-swboyd@chromium.org>
> Let's consolidate all these error messages into the API itself,
> allowing us to get rid of the error messages in each driver.
Such information from the commit descriptions sounds positive.
> +++ b/drivers/base/platform.c
…
> @@ -163,6 +158,22 @@ int platform_get_irq(struct platform_device *dev, unsigned int num)
…
> +/**
> + * platform_get_irq - get an IRQ for a device
> + * @dev: platform device
> + * @num: IRQ number index
> + */
Do you find the provided description for the programming interface
really sufficient then?
Would it be more helpful to indicate the existence of an appropriate error message
also in this software documentation (besides the C source code)?
Regards,
Markus
next prev parent reply other threads:[~2019-07-24 15:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 18:16 [PATCH v4 0/3] Add error message to platform_get_irq*() Stephen Boyd
2019-07-23 18:16 ` [PATCH v4 1/3] driver core: platform: Add an " Stephen Boyd
2019-07-24 15:00 ` Markus Elfring [this message]
2019-07-24 18:17 ` Stephen Boyd
2019-07-25 5:55 ` Markus Elfring
2019-07-23 18:16 ` [PATCH v4 2/3] treewide: Remove dev_err() usage after platform_get_irq() Stephen Boyd
2019-07-23 18:31 ` Andy Shevchenko
2019-07-23 22:23 ` Stephen Boyd
2019-07-24 11:17 ` [v4 " Markus Elfring
2019-07-23 19:30 ` [PATCH v4 " Rob Herring
2019-07-23 22:24 ` Stephen Boyd
2019-07-24 17:08 ` Mark Brown
2019-07-24 6:35 ` Greg Kroah-Hartman
2019-07-24 17:06 ` Mark Brown
2019-07-23 18:16 ` [PATCH v4 3/3] coccinelle: Add script to check for platform_get_irq() excessive prints Stephen Boyd
2019-07-24 9:30 ` Markus Elfring
2019-07-24 18:21 ` Stephen Boyd
2019-07-24 18:38 ` [v4 " Markus Elfring
2019-07-24 13:18 ` [PATCH v4 " Markus Elfring
2019-07-24 18:23 ` Stephen Boyd
2019-07-24 18:45 ` [v4 " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d12a32e6-fd82-71f8-c320-ea6e844db3f4@web.de \
--to=markus.elfring@web.de \
--cc=a.hajda@samsung.com \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=javierm@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).