linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8723bs: remove set but not used 'pregistrypriv'
@ 2020-04-26  9:43 Jason Yan
  2020-04-27  2:17 ` Jason Yan
  0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-26  9:43 UTC (permalink / raw)
  To: gregkh, hariprasad.kelam, devel, linux-kernel; +Cc: Jason Yan, Hulk Robot

Fix the following gcc warning:

drivers/staging/rtl8723bs/hal/sdio_halinit.c:547:24: warning: variable
‘pregistrypriv’ set but not used [-Wunused-but-set-variable]
  struct registry_priv *pregistrypriv;
                        ^~~~~~~~~~~~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 7853af53051d..e42d8c18e1ae 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -544,13 +544,9 @@ static void _InitRetryFunction(struct adapter *padapter)
 
 static void HalRxAggr8723BSdio(struct adapter *padapter)
 {
-	struct registry_priv *pregistrypriv;
 	u8 valueDMATimeout;
 	u8 valueDMAPageCount;
 
-
-	pregistrypriv = &padapter->registrypriv;
-
 	valueDMATimeout = 0x06;
 	valueDMAPageCount = 0x06;
 
-- 
2.21.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: rtl8723bs: remove set but not used 'pregistrypriv'
  2020-04-26  9:43 [PATCH] staging: rtl8723bs: remove set but not used 'pregistrypriv' Jason Yan
@ 2020-04-27  2:17 ` Jason Yan
  0 siblings, 0 replies; 2+ messages in thread
From: Jason Yan @ 2020-04-27  2:17 UTC (permalink / raw)
  To: gregkh, hariprasad.kelam, devel, linux-kernel; +Cc: Hulk Robot

Sorry, it has already been fixed by YueHaibing. Please ignore this.

在 2020/4/26 17:43, Jason Yan 写道:
> Fix the following gcc warning:
> 
> drivers/staging/rtl8723bs/hal/sdio_halinit.c:547:24: warning: variable
> ‘pregistrypriv’ set but not used [-Wunused-but-set-variable]
>    struct registry_priv *pregistrypriv;
>                          ^~~~~~~~~~~~~
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>   drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> index 7853af53051d..e42d8c18e1ae 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
> @@ -544,13 +544,9 @@ static void _InitRetryFunction(struct adapter *padapter)
>   
>   static void HalRxAggr8723BSdio(struct adapter *padapter)
>   {
> -	struct registry_priv *pregistrypriv;
>   	u8 valueDMATimeout;
>   	u8 valueDMAPageCount;
>   
> -
> -	pregistrypriv = &padapter->registrypriv;
> -
>   	valueDMATimeout = 0x06;
>   	valueDMAPageCount = 0x06;
>   
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-27  2:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-26  9:43 [PATCH] staging: rtl8723bs: remove set but not used 'pregistrypriv' Jason Yan
2020-04-27  2:17 ` Jason Yan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).