From: Arun Parameswaran <arun.parameswaran@broadcom.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v2 6/7] net: phy: Add support to configure clock in Broadcom iProc mdio mux
Date: Mon, 30 Jul 2018 09:49:48 -0700 [thread overview]
Message-ID: <d19bb673-9088-bbee-ce9f-f2a4d8f404bf@broadcom.com> (raw)
In-Reply-To: <20180728212224.GF4792@lunn.ch>
Hi Andrew,
On 18-07-28 02:22 PM, Andrew Lunn wrote:
>> @@ -198,10 +219,22 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
>> return PTR_ERR(md->base);
>> }
>>
>> + md->core_clk = devm_clk_get(&pdev->dev, NULL);
>> + if (IS_ERR(md->core_clk)) {
>> + md->core_clk = NULL;
>> + } else {
>> + rc = clk_prepare_enable(md->core_clk);
>> + if (rc) {
>> + dev_err(&pdev->dev, "failed to enable core clk\n");
>> + return rc;
>> + }
>> + }
>> +
>> md->mii_bus = mdiobus_alloc();
>> if (!md->mii_bus) {
>> dev_err(&pdev->dev, "mdiomux bus alloc failed\n");
>> - return -ENOMEM;
>> + rc = -ENOMEM;
>> + goto out;
>
> Hi Arun
>
> There is a devm_mdiobus_alloc() which could make the cleanup on error
> simple.
>
Should I do this as a separate patch ?
Thanks
Arun
>> }
>>
>> bus = md->mii_bus;
>> @@ -217,7 +250,7 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
>> rc = mdiobus_register(bus);
>> if (rc) {
>> dev_err(&pdev->dev, "mdiomux registration failed\n");
>> - goto out;
>> + goto out_alloc;
>> }
>>
>> platform_set_drvdata(pdev, md);
>> @@ -236,8 +269,11 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
>>
>> out_register:
>> mdiobus_unregister(bus);
>> -out:
>> +out_alloc:
>> mdiobus_free(bus);
>> +out:
>> + if (md->core_clk)
>> + clk_disable_unprepare(md->core_clk);
>> return rc;
>> }
>
> Andrew
>
next prev parent reply other threads:[~2018-07-30 16:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 21:23 [PATCH v2 0/7] Add clock config and pm support to bcm iProc mdio mux Arun Parameswaran
2018-07-27 21:23 ` [PATCH v2 1/7] dt-bindings: net: Fix Broadcom iProc mdio mux driver base address Arun Parameswaran
2018-07-28 21:09 ` Andrew Lunn
2018-07-30 22:48 ` Florian Fainelli
2018-07-31 20:47 ` Rob Herring
2018-07-27 21:23 ` [PATCH v2 2/7] net: phy: Fix the register offsets in Broadcom iProc mdio mux driver Arun Parameswaran
2018-07-28 21:10 ` Andrew Lunn
2018-07-30 22:50 ` Florian Fainelli
2018-07-27 21:23 ` [PATCH v2 3/7] arm64: dts: Fix the base address of the Broadcom iProc mdio mux Arun Parameswaran
2018-07-28 21:11 ` Andrew Lunn
2018-07-30 22:50 ` Florian Fainelli
2018-07-27 21:23 ` [PATCH v2 4/7] net: phy: Disable external master access in bcm mdio mux driver Arun Parameswaran
2018-07-28 21:13 ` Andrew Lunn
2018-07-30 22:51 ` Florian Fainelli
2018-07-27 21:23 ` [PATCH v2 5/7] dt-bindings: net: Add clock handle to Broadcom iProc mdio mux Arun Parameswaran
2018-07-28 21:15 ` Andrew Lunn
2018-07-30 22:51 ` Florian Fainelli
2018-07-31 20:48 ` Rob Herring
2018-07-27 21:23 ` [PATCH v2 6/7] net: phy: Add support to configure clock in " Arun Parameswaran
2018-07-28 0:03 ` Andrew Lunn
2018-07-30 16:47 ` Arun Parameswaran
2018-07-28 21:22 ` Andrew Lunn
2018-07-30 16:49 ` Arun Parameswaran [this message]
2018-07-30 18:04 ` Andrew Lunn
2018-07-31 17:57 ` Florian Fainelli
2018-07-27 21:23 ` [PATCH v2 7/7] net: phy: Add pm support to Broadcom iProc mdio mux driver Arun Parameswaran
2018-07-28 21:27 ` Andrew Lunn
2018-07-30 22:53 ` Florian Fainelli
2018-07-31 17:51 ` Arun Parameswaran
2018-07-28 21:32 ` [PATCH v2 0/7] Add clock config and pm support to bcm iProc mdio mux Andrew Lunn
2018-07-30 16:57 ` Arun Parameswaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d19bb673-9088-bbee-ce9f-f2a4d8f404bf@broadcom.com \
--to=arun.parameswaran@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).