From: Arun Parameswaran <arun.parameswaran@broadcom.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v2 7/7] net: phy: Add pm support to Broadcom iProc mdio mux driver
Date: Tue, 31 Jul 2018 10:51:48 -0700 [thread overview]
Message-ID: <f298c64e-d8de-0e6d-3c4d-f62b257329f9@broadcom.com> (raw)
In-Reply-To: <8d732031-c5e8-d6ea-5b61-3b9baf79796f@gmail.com>
Hi Florian,
On 18-07-30 03:53 PM, Florian Fainelli wrote:
> On 07/27/2018 02:23 PM, Arun Parameswaran wrote:
>> Add support for suspend and resume to the Broadcom iProc mdio
>> mux driver.
>>
>> Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
>> ---
>> drivers/net/phy/mdio-mux-bcm-iproc.c | 28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/drivers/net/phy/mdio-mux-bcm-iproc.c b/drivers/net/phy/mdio-mux-bcm-iproc.c
>> index 51d1003..d89dce0 100644
>> --- a/drivers/net/phy/mdio-mux-bcm-iproc.c
>> +++ b/drivers/net/phy/mdio-mux-bcm-iproc.c
>> @@ -290,6 +290,33 @@ static int mdio_mux_iproc_remove(struct platform_device *pdev)
>> return 0;
>> }
>>
>> +#ifdef CONFIG_PM_SLEEP
>> +static int mdio_mux_iproc_suspend(struct device *dev)
>> +{
>> + struct iproc_mdiomux_desc *md = dev_get_drvdata(dev);
>> +
>> + if (md->core_clk)
>> + clk_disable_unprepare(md->core_clk);
>
> Since you are assigning md->core_clk to NULL in case clk_get() returned
> an error, checking for md->core_clk is not necessary since the Linux
> common clock framework perform that NULL check already.
>
Will remove the check.
I am working on Andrew's comments (which will add one more patch to the series).
I will send the whole patchset again, with reviewed-by tags (From Florian
and Andrew on the ones that apply).
Thanks
Arun
next prev parent reply other threads:[~2018-07-31 17:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 21:23 [PATCH v2 0/7] Add clock config and pm support to bcm iProc mdio mux Arun Parameswaran
2018-07-27 21:23 ` [PATCH v2 1/7] dt-bindings: net: Fix Broadcom iProc mdio mux driver base address Arun Parameswaran
2018-07-28 21:09 ` Andrew Lunn
2018-07-30 22:48 ` Florian Fainelli
2018-07-31 20:47 ` Rob Herring
2018-07-27 21:23 ` [PATCH v2 2/7] net: phy: Fix the register offsets in Broadcom iProc mdio mux driver Arun Parameswaran
2018-07-28 21:10 ` Andrew Lunn
2018-07-30 22:50 ` Florian Fainelli
2018-07-27 21:23 ` [PATCH v2 3/7] arm64: dts: Fix the base address of the Broadcom iProc mdio mux Arun Parameswaran
2018-07-28 21:11 ` Andrew Lunn
2018-07-30 22:50 ` Florian Fainelli
2018-07-27 21:23 ` [PATCH v2 4/7] net: phy: Disable external master access in bcm mdio mux driver Arun Parameswaran
2018-07-28 21:13 ` Andrew Lunn
2018-07-30 22:51 ` Florian Fainelli
2018-07-27 21:23 ` [PATCH v2 5/7] dt-bindings: net: Add clock handle to Broadcom iProc mdio mux Arun Parameswaran
2018-07-28 21:15 ` Andrew Lunn
2018-07-30 22:51 ` Florian Fainelli
2018-07-31 20:48 ` Rob Herring
2018-07-27 21:23 ` [PATCH v2 6/7] net: phy: Add support to configure clock in " Arun Parameswaran
2018-07-28 0:03 ` Andrew Lunn
2018-07-30 16:47 ` Arun Parameswaran
2018-07-28 21:22 ` Andrew Lunn
2018-07-30 16:49 ` Arun Parameswaran
2018-07-30 18:04 ` Andrew Lunn
2018-07-31 17:57 ` Florian Fainelli
2018-07-27 21:23 ` [PATCH v2 7/7] net: phy: Add pm support to Broadcom iProc mdio mux driver Arun Parameswaran
2018-07-28 21:27 ` Andrew Lunn
2018-07-30 22:53 ` Florian Fainelli
2018-07-31 17:51 ` Arun Parameswaran [this message]
2018-07-28 21:32 ` [PATCH v2 0/7] Add clock config and pm support to bcm iProc mdio mux Andrew Lunn
2018-07-30 16:57 ` Arun Parameswaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f298c64e-d8de-0e6d-3c4d-f62b257329f9@broadcom.com \
--to=arun.parameswaran@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).